firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,153 Commits 1 Branch 0 Tags
a88e4cd7cbb401ed1394de5cb5ffce193f33de97
Commit Graph

18842 Commits

Author SHA1 Message Date
Gary Qian
a562b3cb3d Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Dan Field
a4f5a5871a Avoid retaining routes when subscriptions are cleared (#88310) 2021-08-16 14:47:03 -07:00
Jason Simmons
ddb8bfb72b Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00
Kate Lovett
e761e64983 Add theme support for choosing android overscroll indicator (#88295) 2021-08-16 13:42:02 -07:00
xubaolin
a4b724d944 fix a scrollbar updating bug (#88152) 2021-08-16 12:17:02 -07:00
LongCatIsLooong
c49eba6c3f [TextInput] minor fixes (#87973) 2021-08-16 12:12:04 -07:00
YeungKC
a40c5c29e6 Migration text selection manipulation. (#86986) 
Consolidate duplicated cut/copy/paste/selectall code so it can be done via Actions in the future.
 2021-08-16 10:38:49 -07:00
Jenn Magder
57efbd5310 Rename IOSDeviceInterface to IOSDeviceConnectionInterface (#88144) 2021-08-16 10:27:03 -07:00
Tong Mu
31d0787d20 Revert "Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297)" (#88293) 
This reverts commit 91f8b6be51.
 2021-08-16 09:38:25 -07:00
Swiftaxe
e7f9bcba2d Removed no-shuffle tag and fixed leak in debug_test.dart (#88268) 
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

The TapGestureRecognizer in the test named 'TapGestureRecognizer _sentTapDown toString' was not disposed, which was breaking a couple of other tests.
This worked fine when not shuffling the tests as the test was executed last.
 2021-08-16 09:29:19 -07:00
Swiftaxe
fe337dcaf5 Animation controller test (#88251) 
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

Fixes test/animation/animation_controller_test.dart in #85160

Problem:
The test 'animateTo can deal with duration == Duration.Zero' was failing with the following error:

Expected: <0>
Actual: <5>
Expected no animation.
package:test_api expect
package:flutter_test/src/widget_tester.dart 484:3 expect
test/animation/animation_controller_test.dart 511:5 main.

Following line finds 5 transientCallbacks scheduled, while expecting zero, if shuffled with seed 123:

expect(SchedulerBinding.instance!.transientCallbackCount, equals(0), reason: 'Expected no animation.');

This is caused by some other test leaving transientCallbacks scheduled.

Fix:
By disposing the AnimationController after each test, the transientCallbacks get cleaned up.
I chose to dispose all controllers in every test, to make sure there is no risk of leaks.
 2021-08-16 09:28:11 -07:00
Pierre-Louis
85ffa8ce18 [Fonts] Improved icons update script (#88153) 
* Improved update_icons.dart

* Handle _

* Update dartdoc

* Rename function

* formatting

* fix type

* Refactor ID generation

* rename

* cleanup

* update comment

* replace typedef with type
 2021-08-15 12:56:58 +02:00
LongCatIsLooong
b3d12ebd77 Revert "[EditableText] call onSelectionChanged only when there're actual selection/cause changes (#87971)" (#88183) 2021-08-13 17:17:04 -07:00
Zachary Anderson
c5d5463c30 [flutter_tools] Fix hang in DesktopLogReader (#88178) 2021-08-13 17:12:04 -07:00
Jenn Magder
325cfb0f4c Make doctor Xcode version requirement clearer (#88137) 2021-08-13 17:07:03 -07:00
Abhishek Ghaskata
10aad08a34 add ? (#88019) 2021-08-13 17:02:09 -07:00
zuvola
93d69544a1 Fix AnimatedCrossFade would focus on a hidden widget (#87618) 
Moving the focus with the tab key on the external keyboard will move the focus to the widget that is hidden by AnimatedCrossFade.
 2021-08-13 08:49:43 -07:00
嘟囔
bf3ff7ec71 feat: migrate fuchsia/application_package.dart to null-safe (#88095) 2021-08-13 00:22:07 -07:00
Justin McCandless
4bd8b288bb ScaleUpDetails focalPointDelta (#85718) 
Corrects the exact definition in code and docs of ScaleUpDetails delta.
 2021-08-12 18:02:02 -07:00
chunhtai
b860982938 remove _AbortingSemanticsFragment (#88067) 2021-08-12 17:32:03 -07:00
LongCatIsLooong
6e224ee0e6 [EditableText] call onSelectionChanged only when there're actual selection/cause changes (#87971) 2021-08-12 17:27:03 -07:00
Michael Goderbauer
fbc4e9bcc5 Revert "Update MaterialScrollBehavior.buildScrollbar for horizontal axes (#87740)" (#88129) 2021-08-12 16:12:06 -07:00
Anurag Roy
758c28b813 [flutter_tools] Reland "Make upgrade only work with standard remotes" (#87731) 2021-08-12 15:52:07 -07:00
Ian Hickson
7bedd0f122 Fix incorrect logging. (#88042) 2021-08-12 15:32:06 -07:00
Zachary Anderson
f0e832cdea [flutter_tool] Fix DesktopLogReader to capture all output (#88116) 2021-08-12 14:57:07 -07:00
Ahmed Ashour
5848a1620d [gen_l10n] to handle arbitrary DateFormat patterns (#86844) 2021-08-12 14:34:52 -07:00
Jenn Magder
9764d861ca Support flutter create --platform singular flag (#88076) 2021-08-12 11:42:04 -07:00
Jenn Magder
9b1ed4639d Update flutter create templates for Xcode 13 (#88074) 2021-08-12 11:37:04 -07:00
嘟囔
047d35d8ba feat: refactor IosProject and MacOSProject to extends XcodeBasedProject to share common (#87930) 2021-08-11 21:47:05 -07:00
Justin McCandless
9e9ca69808 Home/End key support for Linux (#87294) 
Support for more desktop keyboard keys/shortcuts.
 2021-08-11 21:05:16 -07:00
嘟囔
a17723d46b feat: migrate windows/application_package.dart to null-safety (#88081) 2021-08-11 21:02:03 -07:00
Greg Spencer
10e4b04010 Switch document generation to use the snippets package (#87231) 
Switch document generation to use the snippets package instead of the snippets code in the Flutter repo. In the process, some bugs in sample code analysis have been fixed, and I've fixed some more errors in the samples.

This will allow the snippets package to be developed separately from the Flutter repo, and reduce the code in the Flutter repo.

The snippets code is deleted in this PR.

I also converted some comments in the snippet templates to be regular comments instead of doc comments, because having a doc comment block before the imports causes the Dart import sorter to lose the comment. They should have been regular comments in the first place.

The snippets package resides in the assets-for-api-docs repo.

The sample analysis has also been converted to be run in parallel, and I've bumped the Dartdoc version to 1.0.2.
 2021-08-11 19:48:29 -07:00
Hans Muller
871386bbb4 Revert "Changing ElevatedButton.child to be non-nullable (#87901)" (#88071) 
This reverts commit 724c0eb65c.
 2021-08-11 17:29:29 -07:00
Kate Lovett
e127665795 Update MaterialScrollBehavior.buildScrollbar for horizontal axes (#87740) 2021-08-11 14:52:04 -07:00
嘟囔
d2f9c6c752 feat: migrate base/dds.dart to null-safety (#88015) 2021-08-11 14:47:06 -07:00
嘟囔
4ef8088ce8 feat: migrate macos/application_package.dart to null-safety (#87976) 2021-08-11 14:42:05 -07:00
Greg Spencer
cb651352dd Fix errors in examples (#87962) 2021-08-11 14:37:06 -07:00
Kate Lovett
d8da091751 Android 12 overscroll stretch effect (#87839) 2021-08-11 16:36:53 -05:00
Ian Hickson
8d89632fdd Notification doc fixes (#87767) 2021-08-11 14:32:06 -07:00
Tong Mu
91f8b6be51 Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297) 
This reverts commit ccf6f0353a.

New impl

Remove temp

Format
 2021-08-11 00:37:54 -07:00
Darren Austin
b08366ce7b Updated skipped tests for flutter_tools. (#87925) 
* Updated skipped tests for flutter_tools.

* Turned the flaky overall_experience test off as it was still failing on CI.
 2021-08-10 22:22:08 -07:00
xubaolin
a628e4f422 showModalBottomSheet should not dispose the controller provided by user (#87707) 2021-08-10 17:07:07 -07:00
Viren Khatri
66597ffb78 Fixed mouse cursor of disabled IconButton (#84946) 2021-08-10 16:32:40 -07:00
LongCatIsLooong
1ca0333ce1 Overridable action (#85743) 2021-08-10 15:32:07 -07:00
Viren Khatri
724c0eb65c Changing ElevatedButton.child to be non-nullable (#87901) 2021-08-10 11:06:34 -07:00
Darren Austin
7d76a827c0 Updated skipped tests for services directory. (#87874) 2021-08-09 15:21:17 -07:00
Darren Austin
e2fb5cc318 Updated skipped tests for widgets directory. (#87879) 2021-08-09 15:05:44 -07:00
chunhtai
11a0284a28 Reland "update ScrollMetricsNotification (#87421)" (#87818) 
* Reland "update ScrollMetricsNotification (#87421)"

This reverts commit 0f465e5b2a.

* fix test
 2021-08-09 13:36:57 -07:00
Thomas Leung
4c7af3b123 Fix compile error in SliverAppBar sample code (#87872) 2021-08-09 11:45:04 -07:00
Darren Austin
271ed8b21f Updated skipped tests for flutter_test directory. (#87880) 2021-08-09 11:06:35 -07:00