Commit Graph

18842 Commits

Author SHA1 Message Date
Jonah Williams
6b191841f3 Allow filtering devices to only those supported by current project (#31446) 2019-04-25 12:25:12 -07:00
Kate Lovett
e332ab859a Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well. 2019-04-25 12:18:56 -07:00
Phil Quitslund
5ec33654b1 fix transform assert (#31568)
* fix transform assert
2019-04-25 10:56:44 -07:00
Kate Lovett
a38311e6c8 Fixing duplicate test names. 2019-04-25 10:05:13 -07:00
Dan Field
1db5d66932 Capture JSON RPC errors that presently get swallowed (#31584)
* Update packages
* Capture JSON RPC errors that presently get swallowed
2019-04-25 08:27:00 -07:00
sjindel-google
e84b4c47b8 Allow all tests to run with --update-goldens. (#31562)
Previously benchmark_test.dart would break if run with --update-goldens.
Now the entire test suite can be run with --update-goldens.
2019-04-25 17:13:26 +02:00
Jonah Williams
482078387e make sure we exit early if the Runner.xcodeproj file is missing (#31591) 2019-04-25 00:12:17 -07:00
xster
8cfc92465d CupertinoPicker fidelity revision (#31464) 2019-04-25 00:03:04 -07:00
Jonah Williams
9e51e13e91 add printError messages and tool exit to android device (#31400) 2019-04-24 19:30:39 -07:00
Dan Field
06e1f8fc15 Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 (#31569)
* Manual roll with updated test
2019-04-24 17:20:02 -07:00
Hans Muller
0ba67226ee Add support for the Kazakh language (#31578) 2019-04-24 17:18:28 -07:00
Darren Austin
0aec08c08d TimePicker moves to minute mode after hour selection (#31566)
Adds a feature of the native Android Time Picker to our Material Time Picker. When the user selects an hour, it automatically switches to minute mode.

This is a merging of two pull requests:

Code changes from @sdolski #24677
Tests from @lucaslcode #29876

Thanks to both of you for your contributions!
2019-04-24 17:02:19 -07:00
Tom Robiquet
bfaa4a5bce Added required parameters to FlexibleSpaceBarSettings (#30612) 2019-04-24 16:05:02 -07:00
liyuqian
e51947241b Don't add empty OpacityLayer to the engine (#31520)
Fixes https://github.com/flutter/flutter/issues/31517
2019-04-24 15:39:36 -07:00
Kate Lovett
ba011fd353 nits 2019-04-24 15:35:48 -07:00
rami-a
d4e4726ac2 Update SnackBar to allow for support of the new style from Material spec (#31275)
This PR introduces a number of changes and improvements to snack bars. This includes the ability to specify:

floating style of snack bars that adhere to the updated Material spec
elevation and shape on the SnackBar itself instead of relying on fixed values
a snackBarTheme as part of ThemeData which allows you to customize all of the above on an app-wide level.
This PR is includes the changes from #21484 as well as additional fixes and modifications. Thanks to @NikoYuwono for providing these changes and getting this off the ground!
2019-04-24 17:22:30 -04:00
Kate Lovett
1fcd1b02de Changes for uploading baseline images. 2019-04-24 13:38:49 -07:00
Jonah Williams
37c73e77f1 Remove need for build/name scripts on Linux desktop (#31567) 2019-04-24 13:34:56 -07:00
Anthony
0572f158fb [Material] Adaptive Slider constructor (#30572)
Adds an adaptive constructor for the Material Slider. An adaptive widget is one that renders itself as Material on Android, and Cupertino on iOS. This work is based off of a similar feature on Switches: bbb080b#diff-fe2bb980c6207699cbf45538fe927afa.

The motivation for this change is that we should provide adaptive constructors for as many widgets as necessary in the Material library. In Material, it is suggested that the slider is an iOS-style slider.
2019-04-24 16:26:22 -04:00
Shi-Hao Hong
1da7f1b9d5 Improve Radio Documentation with Example (#31294) 2019-04-24 13:09:50 -07:00
xster
c7a09a415d Cupertino localization step 8: create a gen_cupertino_localizations and generate one for cupertino english and french (#29824) 2019-04-24 12:40:17 -07:00
Anthony
96f15c74ad [Material] Update slider and slider theme with new sizes, shapes, and color mappings (2nd attempt) (#31564)
#30390 was rolled back. This PR will re-roll it forward.

This PR makes a number of changes to the visual appearance of material sliders:

Sizes/Shapes
** enabled thumb radius from 6 to 10
** disabled thumb radius from 4 to 10 with no gap
** default track shape is a rounded rect rather than a rect
**
Colors
** all of the colors now use the new color scheme
** overlay opacity has been reduce from 16% to 12%
** value indicator text color now respects the indicator it is on by using onPrimary
** disabledThumb color no respects the surface it is on by using onSurface
The slider theme is also now constructed consistently with other theme objects within the ThemeData. By default, all values are null, and have default values that are resolved in the slider itself, rather than in the slider theme.
2019-04-24 14:23:44 -04:00
Kate Lovett
95d74481d0 Removed unused imports 2019-04-24 10:58:03 -07:00
Kate Lovett
c5ba689e41 Commented out skips in golden framework tests and transitioned from matchesGoldenFile to matchesSkiaGoldFile. 2019-04-24 10:37:31 -07:00
Shi-Hao Hong
b27b3d7446 Improve Tabs documentation (#31502)
Added info regarding matching lengths requirement and included links to sample implementation
2019-04-24 10:27:32 -07:00
Todd Volkert
e00f1a3c17 Fix typo in docs (#31538) 2019-04-24 07:43:01 -07:00
Jonah Williams
e4a1913e01 Support local engine and asset sync for macOS (#31515) 2019-04-23 17:20:22 -07:00
Jonah Williams
15ba39560a replace no-op log reader with real implementation (#31526) 2019-04-23 17:19:47 -07:00
Kate Lovett
8c59c524c9 Swapping out matchesGoldenFile for matchesSkiaGoldFile for framework tests. 2019-04-23 17:18:23 -07:00
Justin McCandless
fee1d3db90 Unbounded TextField width error (#30796)
Improve the error message shown when a TextField ends up with an unbounded width.
2019-04-23 15:22:05 -07:00
Jonah Williams
6a22f41239 add desktop artifacts to run/target_platform selectors (#31505) 2019-04-23 15:08:47 -07:00
Keerti Parthasarathy
ca0e778972 Relax the string matching for path in test (#31456) 2019-04-23 13:46:53 -07:00
Jonah Williams
661e0350fb Disable all Dart fingerprinters (#31463) 2019-04-23 11:58:37 -07:00
chunhtai
5c5ddd1fc2 Revert "Fix 25807: implement move for sliver multibox widget (#29188)" (#31497)
This reverts commit 77ab0b8321.
2019-04-23 10:41:19 -07:00
liyuqian
981e922aa1 Improve docs to address flutter/flutter#31202 (#31454)
## Description

Clarify that ClipRect can be added to ensure that CustomPainter will be drawing within bounds.

## Related Issues

https://github.com/flutter/flutter/issues/31202
2019-04-23 09:57:05 -07:00
Jonah Williams
15f271ef07 if there is no .ios or ios sub-project, don't attempt building for iOS (#31406) 2019-04-23 09:49:49 -07:00
Jonah Williams
be73969657 Add more context to flutter create sample (#31434) 2019-04-22 22:22:46 -07:00
Jonah Williams
abbb66ad79 Set SYMROOT as absolute in Generated.xcconfig for macOS (#31451) 2019-04-22 22:22:17 -07:00
Greg Spencer
590cc27b31 Revert "Implement focus traversal for desktop platforms, shoehorn edition. (#30040)" (#31461)
This reverts commit 4218c0bc38.
2019-04-22 18:02:35 -07:00
Jonah Williams
096439b417 add ignorable track-widget-creation flag to build and remove --track-widget-creation from xcode backend aot build aot (#31399) 2019-04-22 16:21:17 -07:00
Jonah Williams
a476a08e62 check if project exists before regenerating platform specific tooling (#31342) 2019-04-22 15:18:15 -07:00
Jonah Williams
7f959d8b78 Add Xcode build script for macOS target (#31329) 2019-04-22 13:51:00 -07:00
xster
30637bfe28 Add more shuffle cupertino icons (#31326) 2019-04-22 11:21:47 -07:00
Stanislav Baranov
e2a3c2ee45 Remove support for building dynamic patches on Android. (#31359) 2019-04-22 10:40:50 -07:00
Tong Mu
0fb6a05054 PointerDownEvent and PointerMoveEvent default buttons to 1 (#30579)
* Down and Move have default buttons = kPrimary.
2019-04-22 10:15:26 -07:00
Jonah Williams
18e294dbd7 throw toolExit instead of rethrowing on filesystem exceptions (#31404) 2019-04-22 09:56:14 -07:00
Todd Volkert
b9170a9d9a Add more breadcrumb docs to Transformation (#31420) 2019-04-22 09:53:03 -07:00
Todd Volkert
9a4a3fc62a Add Widget of the Week video to SizedBox (#31421) 2019-04-22 09:52:41 -07:00
Greg Spencer
4218c0bc38 Implement focus traversal for desktop platforms, shoehorn edition. (#30040)
Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.

This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.

It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:

FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.

Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.

Addresses #11344, #1608, #13264, and #1678
Fixes #30084
Fixes #26704
2019-04-22 09:51:40 -07:00
Dan Field
37bc48f26e rectMoreOrLess equals, prep for 64bit rects (#30942)
* rectMoreOrLess equals, prep for 64bit rects
2019-04-22 09:40:19 -07:00