Commit Graph

18842 Commits

Author SHA1 Message Date
Michael Goderbauer
9114f4456c Add localFocalPoint to ScaleDetector (#33955) 2019-06-06 11:09:39 -07:00
Rubens de Melo
23174c34b1 Include advice about dispose in TextEditingController api (#33653)
* include advice about dispose

The same note in https://flutter.dev/docs/cookbook/forms/text-field-changes

* Include remember to dispose texteditingcontroller

Almost the same note here https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller .

* include remember to dispose TextEditingController and link to see also

* remove extras spaces and duplicated comment

* include details about using Positioned.fill

* Revert "include details about using Positioned.fill"

This reverts commit c06196f8884d20c547d97edae71d26f7a61701be.

* rever comment about Positioned.fill

* Include of and remove extra white space

Include of and remove extra white space in the end of line

* improve link description to cookbook

///  * Learn how to use a [TextEditingController] in one of our [cookbook recipe]s.(https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller)

* include of, remove extra white space and improve description link to cookbook.

include of, remove extra white space and improve description link to cookbook.

* include of, remove extra white space and improve link description to cookbook

include of, remove extra white space and improve link description to cookbook

* include of, remove extra white space and improve link description to cookbook

include of, remove extra white space and improve link description to cookbook

* remove extra white spaces

* remove extra white space
2019-06-06 10:41:48 -07:00
sjindel-google
f83df74b6b Don't print warning message when running benchmarks test. (#33842)
# Description
Currently the benchmarks test prints a scary warning message, even when it passes, that a benchmark is being run with asserts enabled.

Normally we don't want developers to do this, because the performance of code with asserts is not characteristic of what end-users will experience. However, we need to unit-test benchmarkWidgets, so I've added a contraindicated option to suppress the warning for the test.

# Related Issues
25049 (comment)
2019-06-06 19:39:32 +02:00
Zachary Anderson
366dcb1588 Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 (#33982)
Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d320e.
2019-06-06 09:50:45 -07:00
Gary Qian
14414f350a Reland "Text inline widgets, TextSpan rework" (#33946) 2019-06-05 18:14:17 -07:00
Michael Goderbauer
61b83d320e Add currentSystemFrameTimeStamp to SchedulerBinding (#33886) 2019-06-05 18:02:01 -07:00
Greg Spencer
947bd7524a Fix a bug in Shortcuts with synonyms, and add tests. (#33949)
This fixes a rather embarrassing bug in ShortcutManager that happened because I forgot to add the tests I meant to add.

This fixes the bug, and adds the tests.
2019-06-05 17:13:25 -07:00
Jason Simmons
95818d2b7a Reland "Framework support for font features in text styles" (#33876)
See https://github.com/flutter/flutter/issues/31691
2019-06-05 16:36:05 -07:00
Greg Spencer
f0978c225a Game controller button support (#33868)
This adds support for game controller buttons. It adds some supplemental USB HID codes that aren't available from the Chromium source code, and maps those on Android to the game pad buttons that Android supports. Other platforms are not supported yet.
2019-06-05 16:23:17 -07:00
Zachary Anderson
5180201fe1 [flutter_tool] Track APK sha calculation time (#33923) 2019-06-05 15:28:19 -07:00
Jonah Williams
b3382b9907 Reland support flutter test on platform chrome (#33859) 2019-06-05 15:27:49 -07:00
Jonah Williams
7548614350 Prevent windows web doctor from launching chrome (#33874) 2019-06-05 15:16:50 -07:00
K. P. Sroka
ab707aca8f Prevent exception being thrown on hasScrolledBody (#31485)
Convert scheduling to use `scheduleMicrotask` instead of `Timer.run`
2019-06-05 13:30:59 -07:00
MH Johnson
1b87f558d5 [Material] Add support for hovered, pressed, and focused text color on Buttons. (#33090)
* Support for stateful text colors in buttons

* Add color and a11y tests for buttons
2019-06-05 15:46:53 -04:00
Jonah Williams
50ea6f32d3 add benchmarks to track web size (#33892) 2019-06-05 12:40:21 -07:00
Gary Qian
2db7918eb5 Revert "Text inline widgets, TextSpan rework (#33794)" (#33928)
This reverts commit 86862c1e62.
2019-06-05 11:35:46 -07:00
Kate Lovett
5a6a664094 The the doc fix (#33917) 2019-06-05 09:07:53 -07:00
Hans Muller
5948b3daca Updated localizations (#33883) 2019-06-04 17:49:15 -07:00
Gary Qian
86862c1e62 Text inline widgets, TextSpan rework (#33794)
* Merge in changes for inline widgets

* Make analyzer happy, fix tests

* Fix analyzer

* Add missing doc

* Docs on RichText

* Fix analyzer some more

* Remove whitespace at end of line

* Update goldens

* Text fixes

* Analyzer
2019-06-04 16:27:53 -07:00
Jenn Magder
035e3d37d7 Revert "Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system (#33852)" (#33882)
This reverts commit d053fe5cb3.
2019-06-04 15:35:35 -07:00
Kaushik Iska
92bfc99132 Added a benchmark for ImageCache (#33814)
* Add an image cache benchmark for a monochrome image
2019-06-04 12:32:52 -07:00
Jenn Magder
d053fe5cb3 Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system (#33852)
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-04 12:17:57 -07:00
Greg Spencer
387e2b0602 Add actions and keyboard shortcut map support (#33298)
This implements the keyboard shortcut handling and action invocation in order to provide a place in the infrastructure for keyboard events to trigger actions. This will allow binding of key events to actions like "move the focus to the next widget" and "activate button".
2019-06-04 11:30:24 -07:00
Justin McCandless
a35d6615ee Double double tap toggles instead of error (#33802)
Fix exception that was happening when double-double-tapping a TextField (or double long tapping).
2019-06-04 10:39:08 -07:00
Tong Mu
c482edac4f Revert "Move declaration of semantic handlers from detectors to recognizers (#33475)" (#33851)
This reverts commit 572f349f5c.
2019-06-04 10:13:15 -07:00
Justin McCandless
fce54ae685 Handles hidden by keyboard (#32838)
Extra space when scrolling to selected input so that the selection caret is visible.
2019-06-04 08:37:29 -07:00
Kate Lovett
04015b987b Fixing duplicate test names. (#33805) 2019-06-04 07:01:52 -07:00
Jonah Williams
7442eeafe5 Reland https://github.com/flutter/flutter/pull/33663 (#33828) 2019-06-04 00:41:21 -07:00
Jonah Williams
83986acbdb Add a real-er web restart, doctor, workflow (#33786) 2019-06-03 23:19:42 -07:00
Todd Volkert
6d554827b6 Revert "Use conditional imports for flutter foundation libraries (#33663)" (#33825)
This reverts commit 90500a5dc4.
2019-06-03 22:00:45 -07:00
Greg Spencer
a70b020e18 Add pseudo-key synonyms for keys like shift, meta, alt, and control. (#33695)
This adds a list of key synonyms for non-printable keyboard keys that appear in more than one place So keys like LogicalKeyboardKey.shiftLeft and LogicalKeyboardKey.shiftRight now can be mapped to just LogicalKeyboardKey.shift.

I also fixed a bug in the gen_keycodes tool where GLFW entries would get removed if they weren't parsed from the source on the web.
2019-06-03 18:41:04 -07:00
Todd Volkert
cb90617911 Revert "ModalRoute resumes previous focus on didPopNext (#33152)" (#33815)
This reverts commit 0f2254a5c3.
2019-06-03 17:24:56 -07:00
Jenn Magder
9734f4ed43 Revert "Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system (#33684)"
This reverts commit ef792fc30d.
2019-06-03 17:19:53 -07:00
Shi-Hao Hong
3b75fbe31d Move dropdownValue into State in sample (#33665) 2019-06-03 16:22:16 -07:00
Jenn Magder
ef792fc30d Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system (#33684)
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-03 16:11:33 -07:00
Tong Mu
572f349f5c Move declaration of semantic handlers from detectors to recognizers (#33475)
- A refactor that moves the semantics declaration from detectors to recognizers to allow custom recognizers to respond to semantic gectures.
- Renames all handlers related to semantics from Gesture* to Semantics*.
2019-06-03 15:07:23 -07:00
Jonah Williams
90500a5dc4 Use conditional imports for flutter foundation libraries (#33663) 2019-06-03 14:56:15 -07:00
Todd Volkert
52fc807dd2 Remove references to HttpClientResponseCompressionState (#33792)
https://github.com/flutter/flutter/issues/33791
2019-06-03 14:53:43 -07:00
Todd Volkert
b835b45a3c Revert "Add capability to flutter test --platform=chrome" (#33800)
This reverts https://github.com/flutter/flutter/pull/33525
2019-06-03 14:53:01 -07:00
Dan Field
639c9935ae wire in fuchsiaApp (#33781) 2019-06-03 14:31:56 -07:00
chunhtai
730025fa17 fix issue 14014 read only text field (#32059) 2019-06-03 14:00:43 -07:00
Todd Volkert
5441044132 Revert "Update consolidateHttpClientResponseBytes() to use compressionState (#33729)" (#33790)
This reverts commit 306a09a384.
2019-06-03 13:48:27 -07:00
Zachary Anderson
590dbbd924 [flutter_tool] Log an Android X related failure to analytics (#33782) 2019-06-03 13:16:44 -07:00
Jonah Williams
6619ab8fea Add web safe indirection to Platform.isPlatform getters (2) (#33780) 2019-06-03 13:16:14 -07:00
Jonah Williams
cd1d40a7c9 Revert "Add web safe indirection to Platform.isPlatform getters (#33406)" (#33776)
This reverts commit d92b3b40d2.
2019-06-03 11:08:30 -07:00
Jonah Williams
d92b3b40d2 Add web safe indirection to Platform.isPlatform getters (#33406) 2019-06-03 10:55:36 -07:00
SimonIT
683238e82a Fix disabled CupertinoTextField style (#32974) 2019-06-03 10:34:47 -07:00
Ian Hickson
2767d37c96 RTL caret in text fields (#33461) 2019-06-03 10:25:54 -07:00
Brandon
f7bfd54934 fix GridView documentation (#33442) 2019-06-03 10:25:20 -07:00
Kate Lovett
89d4267299 Removing old golden checkout for integration test (#33676)
* Removing old golden checkout for integration test

* Removed unused import
2019-06-03 09:59:59 -07:00