Commit Graph

18842 Commits

Author SHA1 Message Date
Greg Spencer
c6fe7bb9e1 Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Tong Mu
f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Jenn Magder
fb69a393b8 Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson
e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Zachary Anderson
99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Alexandre Ardhuin
649e188562 implicit-casts:false in flutter/lib/src/painting (#45621) 2019-12-05 09:41:49 +01:00
Jenn Magder
d01de941b9 Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0 Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Greg Spencer
f7d1616173 Overridable default platform key bindings (#45102)
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
2019-12-04 16:07:01 -08:00
Kate Lovett
9011cece25 Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Emmanuel Garcia
9e94eb93bc Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Greg Spencer
09927b94c3 Add a VisualDensity manual test (#46083)
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
2019-12-04 10:48:06 -08:00
Christopher Fujino
dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
Brian Egan
3ea8c87ce9 Api Samples and Diagrams for 10 more classes / functions (#45603)
* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"
2019-12-04 13:27:23 +01:00
Alexandre Ardhuin
4956bcc2f9 implicit-casts:false in flutter_driver (#45175)
* implicit-casts:false in flutter_driver

* address review comments
2019-12-04 11:10:50 +01:00
Alexandre Ardhuin
a5f9b3b036 implicit-casts:false in flutter/lib/src/rendering (#45720)
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
2019-12-04 10:27:04 +01:00
Alexandre Ardhuin
166d422b05 implicit-casts:false in flutter/lib/src/widgets (#45728)
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
2019-12-04 09:43:54 +01:00
Alexandre Ardhuin
4049460d31 implicit-casts:false in flutter/lib/src/semantics (#45722) 2019-12-04 08:59:19 +01:00
Alexandre Ardhuin
1c7a1c3873 implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
Sebastian Döll
417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Jacek Marchwicki
50532f387a [Driver] correct type for getWidgetDiagnostics (#45985) 2019-12-03 20:33:02 -08:00
Zachary Anderson
4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Greg Spencer
185da9b0af Add Density API to ThemeData, implement for buttons. (#43547)
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
2019-12-03 19:49:56 -08:00
Michael Goderbauer
1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
Emmanuel Garcia
09126abb22 Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
Ian Hickson
97495d8938 Simplify logging code in flutter_driver (#45945)
* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206ef4 (PR #45924).
2019-12-03 17:14:43 -08:00
Dan Field
b61dec79c7 Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Jonah Williams
b96d818c19 Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Jonah Williams
c95dafc4c6 Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams
0dace48932 Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams
0b2bf99491 Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
Alexandre Ardhuin
1ae5d676e5 implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Jonah Williams
8a9897c84c Revert "update macOS configuration settings (#45920)" (#45965)
This reverts commit 3b2042a028.
2019-12-02 21:34:41 -08:00
Jonah Williams
9708e7d16a use package-scheme imports for generated web entrypoint (#45934) 2019-12-02 21:10:08 -08:00
Jonah Williams
3b2042a028 update macOS configuration settings (#45920) 2019-12-02 21:06:38 -08:00
Dan Field
c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Jonah Williams
df0b3fed7b fix lint applied after PR was opened (#45953) 2019-12-02 17:31:11 -08:00
Greg Spencer
37f86c3195 Clean up some things I noticed while doing another change (#45658)
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Jonah Williams
b63683b6cd Update configuration for flutter features (#45914) 2019-12-02 17:06:41 -08:00
Jonah Williams
8cf20f3be7 Dont crash on malformed packages.json (#45786) 2019-12-02 17:04:37 -08:00
Kate Lovett
0ce9206ef4 Revert "Make all of the driver interface public. (#45733)" (#45924)
This reverts commit f2445002b2.
2019-12-02 17:02:59 -08:00
Kate Lovett
cd052a56cb Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cd.
2019-12-02 15:08:35 -08:00
Emmanuel Garcia
8c25328014 Handle case where lastLogcatTimestamp is null (#45937) 2019-12-02 15:02:11 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Dan Field
088fa24463 Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Tong Mu
afb8f38211 Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Michael Goderbauer
8954ee85dd Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00