Commit Graph

18842 Commits

Author SHA1 Message Date
Helin Shiah
cce6b3c5ae Send text error in JSON and print in tools (#58284)
* Send text error in JSON and print in tools

* Add test for error text

* Fix analysis issues

* Move streamListen to try/catch and use global.printStatus

* Extract print error fn and listen for events in web runner

* Add extension listen request to test

* Update packages/flutter_tools/lib/src/resident_runner.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Rename error parsing method

* Allow crash if listen for extension stream fails

* Add test for error and non-error extension events

* Fix formatting for TextTreeRenderer

* Use shorter message for second exceptions

* Specify types for map

* Add empty JSON for resident_web_runner test

* Move stream listen to vmservice and add vmservice test

* Fix stream type

* Move structured error log definition to vmservice

* Use correct test matcher isNot

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-06-05 19:07:37 -07:00
Kabo
8b201b988b Update build doc (#58754) 2020-06-05 15:43:03 -07:00
chunhtai
5eaaad41fb fix cupertino page route dismisses hero transition when swipe to the … (#58024)
* fix cupertino page route dismisses hero transition when swipe to the edge

* add more comment

* addressing comments
2020-06-05 15:40:28 -07:00
chunhtai
afbb80b260 fix navigator observer announcement order (#57605)
* fix navigator observer announcement order

* addressing review comments

* update

* fix analyzer
2020-06-05 15:18:50 -07:00
Nils Reichardt
3e273b14e2 [web & desktop] Hide all characters in a TextField, when obscureText is true on web & desktop (#56794) 2020-06-05 15:18:01 -07:00
Jonah Williams
5722adf11d [flutter_tools] remove deprecation warning on flutter format (#58817)
So that we have a release where both are available without a deprecation warning.
2020-06-05 12:40:02 -07:00
Jonah Williams
72f81f4167 remove unused completer (#58804) 2020-06-05 11:53:01 -07:00
Jonah Williams
1e4d9f8502 [flutter_tools] add --write-sksl-on-exit to flutter drive (#58743)
Allow dumping sksl files on driver exit when a file path is provided to drive's --write-sksl-on-exit
2020-06-05 11:01:23 -07:00
Jonah Williams
d0abf7f90f [flutter_tools] don't use verbose when in doctor or help command (#58798) 2020-06-05 10:12:11 -07:00
Michel Feinstein
71a5c61907 Adds physics to the TabBar (#57416) (#57644) 2020-06-05 06:38:03 -07:00
stuartmorgan
94b7ff241e Don't require a specific Windows 10 SDK (#58713)
Current versions of the Windows desktop build files don't require a specific Windows 10 SDK version, but doctor still checks for one since vswhere doesn't allow for flexible queries. This has been a common source of issues for people setting up on Windows for the first time, because the current VS installer by default only includes a newer version of the SDK than what doctor is looking for.

This removes the vswhere SDK check, and instead uses a manual check for SDKs. Since this uses undocumented (although fairly widely used, so relatively unlikely to change) registry information, the check is non-fatal, so that builds can progress even if the SDK isn't found by doctor; in practice, it's very unlikely that someone would install the C++ Windows development workload but remove the selected-by-default SDK from the install.

Now that all requirements are default, the instructions when missing VS have been simplified so that they no longer list individual components, and instead just say to include default items.

Fixes #50487
2020-06-04 18:53:00 -07:00
Kate Lovett
3ec6978c9c Fix custom physics application in TabBarView (#58715) 2020-06-04 16:43:03 -07:00
Michael Rienstra
78c2defae4 Minor correction to documentation for buttonColor (#58117) 2020-06-04 16:38:03 -07:00
Jonah Williams
f5de6aadd4 [flutter_tools] remove zone level overrides of verbose and daemon logging (#57448)
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides.

This allows removing a work around where web devices needed to look up directly from the context in non-test code.

Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
2020-06-04 16:35:36 -07:00
jBrennen
e9a4759947 #57730 - Support custom shapes for ListTiles (#57733) 2020-06-04 16:33:02 -07:00
Jonah Williams
395d27aa9b Revert "Collect list of Android plugins from .flutter-plugins-dependencies (#57907)" (#58732)
This reverts commit 253eb1cfbd.
2020-06-04 16:16:18 -07:00
Jonah Williams
3b0c84b906 Revert "use Expand-Archive and Compress-Archive in windows os utils (#58390)" (#58719)
This reverts commit bbe18f7580.
2020-06-04 14:22:10 -07:00
Igor Akkerman
253eb1cfbd Collect list of Android plugins from .flutter-plugins-dependencies (#57907) 2020-06-04 14:06:03 -07:00
Hans Muller
10ae8698b4 Added MaterialStateProperty overlayColor to InkWell (#58650) 2020-06-04 14:04:11 -07:00
Jonah Williams
bbe18f7580 use Expand-Archive and Compress-Archive in windows os utils (#58390)
Work towards removal of package:archive and ideally more stable unzipping of artifacts. These commands are available in Powershell 5+, which we already require for windows.
2020-06-04 14:00:33 -07:00
Jonah Williams
eae77804fe [flutter_tools] use -f when fetching tags (#58703)
use -f to overwrite local tags on master branch
2020-06-04 13:54:32 -07:00
Jonah Williams
abfb6cb7eb [flutter_tools] unbreak g3 usage of installHook (#58711) 2020-06-04 13:36:21 -07:00
Jonah Williams
3bc4a82605 [flutter_tools] avoid serving files outside of expected paths (#58653) 2020-06-04 11:53:04 -07:00
Tomohiro Hattori
03524a426f Add sample code of GestureDetector with no children (#57838) 2020-06-04 10:43:01 -07:00
Kate Lovett
b915808f63 Step 2 (#57751) 2020-06-04 10:38:02 -07:00
Kate Lovett
8ae64ef1fd Changing default opt-in (#57511) 2020-06-04 10:33:03 -07:00
chunhtai
8a19145f3e update build doc string to advocate avoiding doing tasks other than b… (#58213) 2020-06-04 10:18:02 -07:00
Jonah Williams
e934c2fc0a [flutter_tools] reland: copy dill after startup (#58455)
* [flutter_tools] only copy cached dill after startup

* shared code

* cleanup artifact directory

* do not copy if dillOutputPath is given
2020-06-04 10:17:43 -07:00
Jonah Williams
8b5326a9cf [flutter_tools] unbreak g3 roll (#58688) 2020-06-04 10:17:21 -07:00
Ming Lyu (CareF)
28138ec5e3 debug mode warning text alignment (#58655) 2020-06-03 21:33:01 -07:00
Jenn Magder
2eca1d303c Use fake command in analytics test (#58544) 2020-06-03 21:23:01 -07:00
Jonah Williams
b1d75fc99d [flutter_tools] add flag for sound-null-safety, unify with experiments (#58533)
Also combines experiments into extraGenSnapshot/ExtraFrontEndOptions. Allows providing --no-sound-null-safety to allow out of order migration and running.
2020-06-03 21:02:07 -07:00
Jenn Magder
95edf28150 Move create project build tests to permeable subshard (#58645) 2020-06-03 17:41:15 -07:00
Jenn Magder
c130aa9574 Add FakeAsync to delay tests (#58644) 2020-06-03 17:16:37 -07:00
Jim Graham
e48e2e6ab9 add rasterizer start times to timeline summaries (#58514) 2020-06-03 16:18:02 -07:00
JustWe
6c8d7b00ff Show unsupported devices when no supported devices are connected (#56531) 2020-06-03 16:14:38 -07:00
William Oprandi
91e7678f79 Allow null value for CheckboxListTile (#58154) 2020-06-03 16:13:01 -07:00
Pedro Massango
997a6ffc00 Pass MaterialButton.disabledElevation into RawMaterialButton (#58209)
* Pass disabledElevation from MaterialButton into RawMaterialButton
2020-06-03 15:12:32 -07:00
Robert Ancell
0b7a08c4f6 Update StandardCodec documentation with double alignment (#58456) 2020-06-03 15:08:01 -07:00
Greg Spencer
82acf02d2c Make it possible to remove nodes from traversal sort. (#58621) 2020-06-03 14:53:01 -07:00
Ian Hickson
a82a51b052 More information about our error message APIs. (#58350) 2020-06-03 14:49:39 -07:00
Jonah Williams
0734db62ca [flutter_tools] remove handling of error that is fixed (#58557)
The linked error has been fixed, removed work around. Updates the test cases to only test for exit instead of error message

#33050
2020-06-03 13:27:47 -07:00
Jonah Williams
7e942b6229 [flutter_tools] iOS VM Service logs should include stderr (#58551) 2020-06-03 12:53:02 -07:00
Jenn Magder
e72e7f9fb0 Don't elapse real time during IOSDevice.startApp tests (#58538) (#58622) 2020-06-03 12:43:02 -07:00
Dan Field
c5318f7f07 Make debugSemantics available to profile mode (#58620) 2020-06-03 12:32:35 -07:00
Jonah Williams
e216eec7b4 [flutter_tools] Allow the tool to suppress compilation errors. (#58539)
Suppress compilation errors on startup so they are not duplicated from the native build step.
2020-06-03 12:00:03 -07:00
MH Johnson
4bae771509 [Line Heights] Add textHeightBehavior to SelectableText. (#58530) 2020-06-03 11:53:02 -07:00
Jenn Magder
79e2409419 Fake out DeviceManager.getDevices in test (#58541) 2020-06-03 11:48:37 -07:00
Jenn Magder
37bc900860 Revert "Don't elapse real time during IOSDevice.startApp tests (#58538)" (#58618)
This reverts commit 27186c784f.
2020-06-03 11:26:29 -07:00
Jenn Magder
27186c784f Don't elapse real time during IOSDevice.startApp tests (#58538) 2020-06-03 09:33:02 -07:00