Commit Graph

18842 Commits

Author SHA1 Message Date
Bruno Leroux
bc53e6202e Add error message and documentation when a SnackBar is off screen (#102073) 2022-05-26 05:15:07 -07:00
Nils Reichardt
5764b5dd67 Fix typo "technicallv" in editable_text.dart (#104701) 2022-05-26 13:22:47 +02:00
Danny Tuppeny
147020366a Fix issues running integration tests through DAP debug adapter (#104618)
* Fix issues running integration tests through DAP

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
2022-05-26 09:36:30 +01:00
Pierre-Louis
2aa348b940 Use curly_braces_in_flow_control_structures for widgets (#104609)
* Use `curly_braces_in_flow_control_structures` for `widgets`

* fix comments

* fix comments
2022-05-26 09:48:09 +02:00
Pierre-Louis
332c22f391 Update links to material library docs (#104392)
* Update links to `material` library docs

* outsmart bot heuristics
2022-05-26 08:56:35 +02:00
gaaclarke
20a9f1d8d7 Added option for Platform Channel statistics and Timeline events (#104531) 2022-05-25 18:43:11 -07:00
Taha Tesser
a9c71d7e23 [Reland]: Fix DropdownButton menu clip (#104251) 2022-05-25 14:58:09 -07:00
Greg Spencer
406d86b4ba PlatformMenuBar changes to bring it into line with upcoming MenuBar implementation (#104565)
When I was doing the MenuBar implementation, I made some changes to the PlatformMenuBar to allow it to understand shortcuts a little more, and to deprecate the body parameter rename it to child to match most other widgets.

These are those changes, separated out because they are separable, and I'm trying to make the MenuBar PR smaller.
2022-05-25 14:48:28 -07:00
xubaolin
6efdf0ae7b fix a _DraggableScrollableSheetScrollPosition update bug (#103328) 2022-05-25 14:48:10 -07:00
Jonas Uekötter
9f856ac182 Improve PlatformMenu MenuItem documentation (#104321) 2022-05-25 14:43:12 -07:00
Kate Lovett
fe04647651 Include forceElevated for scrolledUnder in new SliverAppBar variants (#104536) 2022-05-25 14:23:13 -07:00
Tomasz Gucio
2e7cea6dfe Dispose ValueNotifier instances in RenderEditable (#104591) 2022-05-25 13:13:11 -07:00
Tomasz Gucio
aa1c43bbde Dispose ValueNotifier in EditableTextState (#104590) 2022-05-25 13:08:11 -07:00
Markus Aksli
b05741cbad Hide the text selection toolbar on mobile when orientation changes (#103512) 2022-05-25 13:03:16 -07:00
xubaolin
5a9196737d [Slider]The initial value of discrete slider should respect the discrete values (#103966)
Fixes #103965
2022-05-25 12:55:13 -07:00
Michael Goderbauer
3fa355c97d Remove dead code in tools tests (#104567) 2022-05-25 12:48:17 -07:00
Tomasz Gucio
7a2b187c7b Dispose ValueNotifier instances in LicensePage state classes (#104589) 2022-05-25 11:23:11 -07:00
Pierre-Louis
74cfc3db67 Use curly_braces_in_flow_control_structures for non-flutter packages (#104629)
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`

* fix comments

* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`

* fix indentation
2022-05-25 20:01:11 +02:00
Pierre-Louis
a0248ebdf2 Use curly_braces_in_flow_control_structures for services, scheduler, semantics (#104616) 2022-05-25 19:58:22 +02:00
Pierre-Louis
e71eb183d8 Use curly_braces_in_flow_control_structures for rendering (#104611)
* Use `curly_braces_in_flow_control_structures` for `rendering`

* fix comments

* fix dangling
2022-05-25 19:57:57 +02:00
Pierre-Louis
b0aa50255b Use curly_braces_in_flow_control_structures for animations, cupertino (#104612)
* Use `curly_braces_in_flow_control_structures` for `animation`

* Use `curly_braces_in_flow_control_structures` for `cupertino`

* fix comments
2022-05-25 19:56:20 +02:00
Pierre-Louis
9cc72df781 Use curly_braces_in_flow_control_structures for foundation, gestures, painting, physics (#104610)
* Use `curly_braces_in_flow_control_structures` for `foundation`

* Use `curly_braces_in_flow_control_structures` for `gestures`

* Use `curly_braces_in_flow_control_structures` for `painting`

* Use `curly_braces_in_flow_control_structures` for `physics`

* fix comments

* remove trailing space

* fix TODO style
2022-05-25 19:55:22 +02:00
Michael Goderbauer
2b14e993a7 Cleanup random dead test code (#104568) 2022-05-25 10:23:10 -07:00
Greg Spencer
da24f105bd Removing Shorcuts.of and Shortctus.maybeOf (#104215)
This removes Shorcuts.of and Shortctus.maybeOf because they're not especially useful, since the only thing you can really set on a ShortcutManager is the shortcuts, and the Shortcuts widget that you give it to manages those, so if it rebuilds, it overwrites what you set.

Also, adds a Shortcuts.manager constructor and removes the manager argument to the Shortcuts widget.

Removing these will also eliminate an InheritedWidget for each Shortcuts widget, improving memory usage.
2022-05-25 10:16:08 -07:00
Michael Goderbauer
d5fbc3750e Remove unused code from tests (#104550) 2022-05-25 09:38:09 -07:00
Greg Spencer
0a417c3b49 A bunch of cleanups and a missing ShortcutRegistar in WidgetsApp (#104560)
A bunch of random cleanup things I found while doing MenuBar development.

Changes an if test to an assert in binding.dart, since the if should always be true.
Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR.
Moves a debug message in the FocusManager to print the result after the focus change instead of before.
Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
2022-05-25 09:32:46 -07:00
Jenn Magder
f3e567c901 Create static plugin frameworks build ios-framework --static (#104576) 2022-05-25 09:03:12 -07:00
Taha Tesser
78a0d3d4e2 [reland] Migrate ListTile TextTheme TextStyle references to Material 3 (#102167) 2022-05-25 07:28:12 -07:00
Pierre-Louis
cb9a1d623c Use curly_braces_in_flow_control_structures for material (#104499)
* Use `curly_braces_in_flow_control_structures` for `material`

* include test/material

* add back removed comments
2022-05-25 13:17:06 +02:00
Taha Tesser
97452d1a10 Switch: Add an interactive example (#103045)
* `Switch`: Add an interactive examples

* Update docs

* Update doc
2022-05-25 10:40:31 +02:00
Jonah Williams
680a8192b0 [framework] ensure ink sparkle is disposed (#104569) 2022-05-24 21:23:09 -07:00
Jenn Magder
09987dc00a Migrate create command to null safety (#104484) 2022-05-24 18:48:10 -07:00
Yang Chao
b5adbee145 Fix an issue that clearing the image cache may cause resource leaks (#104527) 2022-05-24 16:58:09 -07:00
Jenn Magder
a56c5e51ae Migrate some test files to null safety (#104469) 2022-05-24 16:53:08 -07:00
Bruno Leroux
1e0a1a2661 Add an example and update GestureDetector documentation (#102360) 2022-05-24 16:38:09 -07:00
Jesús S Guerrero
336aa267f9 [flutter_tools] General info project validator (#103653) 2022-05-24 16:28:10 -07:00
Dacian Florea
680bc17cde [web] [fix] Cache resource data only if the fetching succeed (#103816) 2022-05-24 16:23:06 -07:00
Konstantin Scheglov
c27e88a5b1 Fix existing DUPLICATE_IMPORT diagnostics. (#104533) 2022-05-24 14:18:31 -07:00
chunhtai
efb9368573 Supports global selection for all devices (#95226)
* Support global selection

* addressing comments

* add new test

* Addressing review comments

* update

* addressing comments

* addressing comments

* Addressing comments

* fix build
2022-05-24 13:53:55 -07:00
chunhtai
bd7d34f09d Reland "Fix Backbutton is not displayed when there is a endDrawer (#1… (#104110)
* Reland "Fix Backbutton is not displayed when there is a endDrawer (#102093)"

This reverts commit a4a8e73bce.

* add todos
2022-05-24 13:39:46 -07:00
Loïc Sharma
c29a7a2d22 Ignore replacement characters from vswhere.exe output (#104284)
Flutter uses `vswhere.exe` to find Visual Studio installations and determine if they satisfy Flutter's requirements. However, `vswhere.exe`'s JSON output is known to contain bad UTF-8. This change ignores bad UTF-8 as long as they affect JSON properties that are either unused, or, used only for display purposes by Flutter.

Fixes: https://github.com/flutter/flutter/issues/102451
2022-05-24 13:30:37 -07:00
LongCatIsLooong
12147ad718 Remove RenderObject.rotate (#103092) 2022-05-24 11:37:35 -07:00
Xilai Zhang
de230d393c Revert "Add ability for ModalRoutes to ignore pointers during transitions and do so on Cupertino routes (#95757)" (#104520)
This reverts commit 4c0b0be2da.
2022-05-24 11:10:13 -07:00
Taha Tesser
5739bf4fab RefreshIndicator: Add notificationPredicate example (#103894) 2022-05-24 04:58:06 -07:00
Taha Tesser
a12a69a47c Fix BottomAppBar dip without FAB (#104490) 2022-05-24 03:13:08 -07:00
Chris Bracken
f9765c136f [tool] Add tests for FakeProcessManager (#104456)
Adds a bit more clarifying documentation to the implementation of the
outputFollowsExit case, and adds tests that verify the behaviour of
stderr, stdout of processes launched via FakeProcessManager.

Specifically:
* Verifies that stderr, stdout are not emitted immediately after process
  exit if outputFollowsExit is true. They must be emitted at least one
  turn through the event loop later.
* Verifies that ProcessResult.stderr, stdout have the type documented
  according to the encoding passted to Process.run/runSync:
  * List<int> if null is passed as the encoding.
  * String (in the default system encoding) if no encoding is specified.
  * String (in the specified encoding) if an encoding is specified.

This is additional testing relating to refactoring landed in:
https://github.com/flutter/flutter/pull/103947

Issue: https://github.com/flutter/flutter/issues/102451
2022-05-23 22:57:34 -07:00
Darren Austin
eadd07b0b9 Fix ColorScheme.copyWith for surfaceTint (#104435) 2022-05-23 20:24:18 -07:00
Jenn Magder
c5d046c00c continue->next in Ruby script (#104296) 2022-05-23 18:43:05 -07:00
hellohuanlin
f85209272d Add Focus support for iOS platform view (#103019) 2022-05-23 17:58:13 -07:00
gaaclarke
914556ea64 Started sharing SemanticsProperties between the Widget and the RenderObject (#104281) 2022-05-23 16:18:08 -07:00