Commit Graph

5939 Commits

Author SHA1 Message Date
Christopher Fujino
38a8845481 move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy
1b0fd265bd [ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson
04a1b78b75 Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams
edd03a1af8 [flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams
6804cef587 [flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia
4049889d9e Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams
ea3563ea4d [flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson
53dce17b35 [flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson
78b45fb1b2 [flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson
7f564b7436 [flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams
5d289721fc [flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson
605debfcff [flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Zachary Anderson
733fc20073 [flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams
fdb7bd3c0f [flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams
2133343a29 [flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams
377879825e [flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder
fdd023fa59 Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams
60d0fef17a [flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams
3191af1332 [flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams
88b39402ac [flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams
bc43b41d99 [flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
Angjie Li
665d380f81 Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Dan Field
e13e17009d Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field
db1f33fd70 Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams
c1112d3f7e [flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino
2e18cd347e Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Jonah Williams
e7d70fbf75 Revert "Fix version command for certain git workflows (#52062)" (#52128)
This reverts commit 20bf43b9eb.
2020-03-06 12:58:00 -08:00
Jenn Magder
a14ac4e3c8 Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder
f6a55125d2 Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson
6c408a0567 Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021)
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Dan Field
20bf43b9eb Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field
4d05ed5deb Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Jonah Williams
d2f889b4f0 [flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams
bafa03e5b5 [flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams
8872d1d8c4 [flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Jenn Magder
b8472f25ab Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams
ad16823e4c [flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams
c411f588c6 Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045)
This reverts commit aed961993d.
2020-03-05 13:02:22 -08:00
Jonah Williams
ee476a7bd1 Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e [flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams
aed961993d [flutter_tools] supports tree-shake-icons for web builds (#51808)
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
2020-03-05 12:35:04 -08:00
Jonah Williams
1bf6f0232e [flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams
bbf913bc4c [flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Jonah Williams
374f85c976 [flutter_tools] pin exact build_runner version (#52033) 2020-03-05 11:09:41 -08:00
Alexandre Ardhuin
c2ae654ddf enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Jenn Magder
db94472aeb Skip iOS project migration when script is already embedding frameworks (#51963) 2020-03-04 16:12:13 -08:00
Jenn Magder
dc33334675 Update iOS project migration help URL (#51973) 2020-03-04 16:12:02 -08:00
Jenn Magder
cbbb7ec5a7 Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774)" (#51960)
This reverts commit 57c6721cd5.
2020-03-04 12:40:15 -08:00
Flutter GitHub Bot
57c6721cd5 Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774) 2020-03-04 11:41:02 -08:00
Ben Konyi
3edd3eb4a2 Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00