firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,127 Commits 1 Branch 0 Tags
a4d8601b57affca8e211d2ce704432c2bb14b3f9
Commit Graph

23029 Commits

Author SHA1 Message Date
Jason Simmons
a4d8601b57 Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791) 
See https://github.com/flutter/flutter/issues/130318
 2023-07-19 07:14:06 +00:00
skia-flutter-autoroll
d1866abd24 Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801) 
https://skia.googlesource.com/skia.git/+log/9062ca6a691c..035b12a03918

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c10b5129407a to 55a98e279ec6
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0733bf3a7728 to c10b5129407a (7 revisions)
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 06:16:11 +00:00
skia-flutter-autoroll
2a77fee2f6 Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798) 
https://dart.googlesource.com/sdk.git/+log/c184cac2d22f..9f5e86b4c108

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-325.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 05:12:12 +00:00
skia-flutter-autoroll
ce0e083536 Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795) 
https://skia.googlesource.com/skia.git/+log/280fb8391187..d1d2b623799e

2023-07-19 michaelludwig@google.com [skif] Implement image delegate for graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-19 02:04:06 +00:00
Zachary Anderson
d84cf41f4f Increase engine v2 orchestrator timeouts (flutter/engine#43788) 
This PR increases orchestrator timeouts to avoid the case where subjobs that are making progress after a long queue time may be needlessly cancelled if the orchestrator runs over a too-small timeout.
 2023-07-18 23:44:11 +00:00
Zachary Anderson
562a5764b0 Remove obsolete legacy engine builds from staging (flutter/engine#43790) 
These builds have had engine v2 variants running for nearly a quarter or
more in most cases, and they are now not serving much of a purpose.
Additionally, during MTV peak hours, queue times and therefore overall
cycle times are getting too long, and we should be freeing up these
resources.
 2023-07-18 15:22:11 -07:00
Brandon DeRosier
0d61edb7a7 [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785) 
Follow-up fix for https://github.com/flutter/engine/pull/43727.

Fixes the GL playground on MacOS.
 2023-07-18 14:52:13 -07:00
skia-flutter-autoroll
5b1d0f082f Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784) 
https://skia.googlesource.com/skia.git/+log/9a0f6d82a6f5..dcc56df202cc

2023-07-18 johnstiles@google.com Remove swizzle-parsing logic from SkSL parser.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 21:11:05 +00:00
skia-flutter-autoroll
b1b3995153 Roll Skia from 4e518e65fea0 to 0adae44dd9cd (6 revisions) (flutter/engine#43779) 
https://skia.googlesource.com/skia.git/+log/4e518e65fea0..0adae44dd9cd

2023-07-18 armansito@google.com [graphite][PathAtlas]: Apply correct subpixel offset
2023-07-18 cmumford@google.com [canvaskit] Add error check when loading SKP
2023-07-18 cmumford@google.com [debugger] only serialize audit trail when enabled
2023-07-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cb22d697262b to f0752efcbdb2 (7 revisions)
2023-07-18 herb@google.com Fix data going empty for fuzz
2023-07-18 brianosman@google.com Remove obsolete MSKP corpus information

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 19:50:03 +00:00
Mouad Debbar
6d0be04af3 [web] sync => isSync , scuba => golden (flutter/engine#43699) 
This PR addresses some of the items in https://github.com/flutter/flutter/issues/100394
 2023-07-18 18:28:13 +00:00
skia-flutter-autoroll
2e1160d33e Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777) 
https://skia.googlesource.com/skia.git/+log/219ca2581ab2..4e518e65fea0

2023-07-18 brianosman@google.com CPU backend: Don't ignore paint alpha with opaque shader + color filter
2023-07-18 jvanverth@google.com [graphite] Fill out semaphore support for Vulkan swapchain.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 18:28:10 +00:00
skia-flutter-autoroll
2ada763995 Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776) 
Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions)

113f847be6..52fe3116ea

2023-07-18 syoussefi@chromium.org Vulkan: Deduplicate share group's context set tracking
2023-07-18 phanquangminh217@gmail.com Reland "Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync"
2023-07-18 cnorthrop@google.com Android: Update script with sync progress
2023-07-18 hitawala@chromium.org Angle: Copy multiplanar d3d11 texture for readPixels
2023-07-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 48a8f73f303f to 8806dade91f0 (572 revisions)
2023-07-17 bsheedy@chromium.org Start Mac Intel 13.4.1 experiment
2023-07-17 syoussefi@chromium.org Move ShareGroup to its own files
2023-07-17 geofflang@chromium.org Metal: Require MSL 2.1.
2023-07-17 geofflang@chromium.org Android: Use ALooper_pollOnce instead of ALooper_pollAll
2023-07-17 romanl@google.com Android: Simplify power metrics collection
2023-07-17 syoussefi@chromium.org Translator: Limit variable sizes vs uint overflow
2023-07-17 m.maiya@samsung.com Vulkan: Bugfix in gl_FragData array redeclaration
2023-07-17 syoussefi@chromium.org Fix deadlock on device loss
2023-07-17 ynovikov@chromium.org Retry angle_deqp_gles2_metal_tests
2023-07-17 cnorthrop@google.com Docs: Add a couple of Android pointers
2023-07-17 romanl@google.com Use VK_EXT_legacy_dithering when available instead of emulation
2023-07-17 ynovikov@chromium.org Skip WebGL2CompatibilityTest.DrawWithZeroSizedBuffer on iOS GL
2023-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions)
2023-07-14 dtapuska@chromium.org Fix cfi issue with Angle invoking worker pool
2023-07-14 romanl@google.com Ensure settings get cleaned up on exceptions
2023-07-14 romanl@google.com Revert "Add minimal setup for Go codegen in Android.bp."
2023-07-14 ynovikov@chromium.org Skip dEQP-EGL.functional.native_[color|coord]_mapping.native_window.*
2023-07-14 geofflang@chromium.org Reject program binaries when the renderer string changes
2023-07-14 geofflang@chromium.org Sync all framebuffer attachments when checking completeness.
2023-07-14 syoussefi@chromium.org Translator: Unconditionally limit variable sizes
2023-07-14 ynovikov@chromium.org Remove obsolete VUID suppressions
2023-07-14 geofflang@chromium.org Metal: Call terminate if display initialization fails.
2023-07-14 geofflang@chromium.org Metal: Use the pipeline cache for RenderUtils compute shaders
2023-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad8a66bf7d69 to aa35b58fce7d (7 revisions)
2023-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from de1153f640b8 to 68d783529187 (590 revisions)
2023-07-14 m.maiya@samsung.com Update input color in YUVSampleLinearFiltering test
2023-07-14 lexa.knyazev@gmail.com Restrict color writemasks for RGB9_E5 color buffers
2023-07-14 cclao@google.com Vulkan: Clean up depth stencil feedback mode part 2
2023-07-14 cclao@google.com Vulkan: Clean up depthStencil feedback loop implementation Part1
2023-07-14 zzyiwei@chromium.org Vulkan: disable explicitlyCastMediumpFloatTo16Bit for Venus
2023-07-13 syoussefi@chromium.org Ensure lockless entry point validations only access private data
2023-07-13 geofflang@chromium.org Metal: Cache compute pipelines for provoking vertex emulation
2023-07-13 syoussefi@chromium.org Prevent accidental misuse of ANGLE_ENABLED
2023-07-13 geofflang@chromium.org Metal: Cache compute pipelines with render pipelines.
2023-07-13 dtapuska@chromium.org Fix Angle creating its own worker pool.
2023-07-13 syoussefi@chromium.org Make insertion/retrieval of Debug messages thread-safe
2023-07-13 lexa.knyazev@gmail.com Skip component type validation of non-existent draw buffers
2023-07-13 geofflang@chromium.org Metal: Use the per-context pipeline cache for RenderUtils
2023-07-13 cnorthrop@google.com Revert "Android: Assert that CFI is disabled"
2023-07-13 syoussefi@chromium.org Make validation make straight calls to ErrorSet
2023-07-13 syoussefi@chromium.org Make error handling and debug messages thread safe
...
 2023-07-18 18:05:19 +00:00
skia-flutter-autoroll
03c2dff540 Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774) 
https://skia.googlesource.com/skia.git/+log/b7103fe086c1..219ca2581ab2

2023-07-18 herb@google.com Simplify bounds checks for collections

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 17:34:15 +00:00
Casey Hillers
94513cf483 [ci.yaml] Skip windows arm on releases (flutter/engine#43771) 
This is blocking the beta release as the builder is running unnecessarily.
 2023-07-18 17:31:44 +00:00
Greg Spencer
5fa39ff142 Check FlutterAppDelegate selector support before calling (flutter/engine#43425) 
## Description

This adds checks for the app delegate to make sure that it supports the Flutter-specific selectors before calling them, so that a non `FlutterAppDelegate` can be used for the `NSApplicationDelegate` on `NSApp`.

## Related Issues
 - https://github.com/flutter/flutter/issues/124829
 - https://github.com/flutter/flutter/issues/127476

## Tests
 - Added a test to make sure things don't crash if the app delegate isn't a `FlutterAppDelegate`.
 2023-07-18 17:31:43 +00:00
Zachary Anderson
2fc2fa8503 Reset Dart VM optimization level to 2 (flutter/engine#43770) 
Partial revert of https://github.com/flutter/engine/pull/43743

Setting the optimization level to `-Oz` reduced compressed binary size by 200KB, but regressed performance by 10-15% across the board (frame build time, gen_snapshot runtime, hot reload time, etc.)
 2023-07-18 17:21:45 +00:00
Jonah Williams
02bee3abf0 [Impeller] Avoid inserting additional save layers based on clip configuration. (flutter/engine#43759) 
Fixes https://github.com/flutter/flutter/issues/130775

On the Skia backend, antiAliasWithSaveLayer is the highest fidelity clipping option. In the Impeller backend, there isn't any difference in how we clip, since the stencil buffer is always used. Nevertheless we were still inserting the save layer, which results in an extra offscreen texture and is wasteful.

Track if impeller is enabled in the diff/preroll/paint context and avoid inserting a save layer.
 2023-07-18 17:21:42 +00:00
skia-flutter-autoroll
cd349ca222 Roll Skia from 8d3e00a1f25f to b33cc7da1e23 (1 revision) (flutter/engine#43768) 
https://skia.googlesource.com/skia.git/+log/8d3e00a1f25f..b33cc7da1e23

2023-07-18 herb@google.com Centralize bounds checking code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 14:40:07 +00:00
skia-flutter-autoroll
d64ac24130 Roll Skia from a4df72ba04bb to 8d3e00a1f25f (1 revision) (flutter/engine#43766) 
https://skia.googlesource.com/skia.git/+log/a4df72ba04bb..8d3e00a1f25f

2023-07-18 kjlubick@google.com Allow legacy mesh APIs in CPU-only build too

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 13:40:10 +00:00
skia-flutter-autoroll
24972e64e9 Roll Dart SDK from 979375f92109 to b83a63e0181a (1 revision) (flutter/engine#43762) 
https://dart.googlesource.com/sdk.git/+log/979375f92109..b83a63e0181a

2023-07-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-322.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 07:53:36 +00:00
dependabot[bot]
0af8f5e8b4 Bump actions/setup-python from 4.6.1 to 4.7.0 (flutter/engine#43760) 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v4.7.0</h2>
<p>In scope of this release, the support for reading python version from pyproject.toml was added (<a href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a>).</p>
<pre lang="yaml"><code>      - name: Setup Python
        uses: actions/setup-python@v4
        with:
          python-version-file: pyproject.toml
</code></pre>
<h3>Besides, it includes such changes as:</h3>
<ul>
<li>Bump tough-cookie and <code>@​azure/ms-rest-js</code> by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/697">actions/setup-python#697</a></li>
<li>Bump semver from 7.3.8 to 7.5.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/692">actions/setup-python#692</a></li>
<li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>@​DimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/650">actions/setup-python#650</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dariocurr"><code>@​dariocurr</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a></li>
<li><a href="https://github.com/DimitriPapadopoulos"><code>@​DimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/650">actions/setup-python#650</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.7.0">https://github.com/actions/setup-python/compare/v4...v4.7.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="61a6322f88"><code>61a6322</code></a> Fix typos found by codespell (<a href="https://redirect.github.com/actions/setup-python/issues/650">#650</a>)</li>
<li><a href="ea5b57fccc"><code>ea5b57f</code></a> Bump semver from 7.3.8 to 7.5.2 (<a href="https://redirect.github.com/actions/setup-python/issues/692">#692</a>)</li>
<li><a href="014d32a830"><code>014d32a</code></a> Bump tough-cookie and <code>@​azure/ms-rest-js</code> (<a href="https://redirect.github.com/actions/setup-python/issues/697">#697</a>)</li>
<li><a href="c16c4b8d18"><code>c16c4b8</code></a> Fix pipenv jobs (<a href="https://redirect.github.com/actions/setup-python/issues/699">#699</a>)</li>
<li><a href="0d5da6a89a"><code>0d5da6a</code></a> Read python version from pyproject.toml (fix <a href="https://redirect.github.com/actions/setup-python/issues/542">#542</a>) (<a href="https://redirect.github.com/actions/setup-python/issues/669">#669</a>)</li>
<li><a href="3f824b7ca6"><code>3f824b7</code></a> remove python 2.7 from the tests (<a href="https://redirect.github.com/actions/setup-python/issues/687">#687</a>)</li>
<li>See full diff in <a href="bd6b4b6205...61a6322f88">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4.6.1&new-version=4.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-07-18 06:45:04 +00:00
skia-flutter-autoroll
b5e0c3120d Roll Skia from 48a44e2cda18 to 31be5646930b (3 revisions) (flutter/engine#43758) 
https://skia.googlesource.com/skia.git/+log/48a44e2cda18..31be5646930b

2023-07-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a426452b5463 to cb22d697262b (11 revisions)
2023-07-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0733bf3a7728 to fce3c81c4ca7
2023-07-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 59a5e9ba0f61 to 0733bf3a7728 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 06:14:20 +00:00
skia-flutter-autoroll
78156d0357 Roll Fuchsia Linux SDK from WZt3P7Fm3_GUvAaDv... to ixKM7wyMrqmPDaQ11... (flutter/engine#43756) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 04:57:15 +00:00
Jia Hao
64e17b1a44 Minor fixes for C++20 compatibility (flutter/engine#43674) 
Fixes the following errors when building with a C++20 toolchain.

I don't really know C++ that well so any pointers would be appreciated. 

For the change to the lambda, we can't follow the recommendation to capture `*this` explicitly because that wouldn't compile under C++17. This PR changes the semantics slightly to capture `surface_` by reference, which might be still okay?

For b/289776142

```
error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture]
   93 |       if (surface_) {
      |           ^
note: add an explicit capture of 'this' to capture '*this' by reference
   91 |     raster_thread_merger_->SetMergeUnmergeCallback([=]() {
      |                                                     ^
      |                                                      , this
```

```
error: bitwise operation between different enumeration types ('CGImageAlphaInfo' and '(unnamed enum at third_party/apple_sdks/xcode_14_2/iphonesimulator/System/Library/Frameworks/CoreGraphics.framework/Headers/CGImage.h:53:9)') is deprecated [-Werror,-Wdeprecated-anon-enum-enum-conversion]
  159 |       static_cast<CGBitmapInfo>(kCGImageAlphaPremultipliedLast |
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
  160 |                                 kCGBitmapByteOrder32Big),  // CGBitmapInfo bitmapInfo
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~
```
 2023-07-18 04:54:01 +00:00
Jia Hao
409cd83cb4 Revert "Log dlopen errors in opt builds (#41477)" (flutter/engine#43677) 
This reverts commit 2b0b0a0e78.

This didn't seem to help with debugging b/276657840. Fixes https://github.com/flutter/flutter/issues/125523.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-18 04:52:48 +00:00
skia-flutter-autoroll
05e56b0617 Roll Skia from f2a4222bb72e to 071d5897eb8a (1 revision) (flutter/engine#43754) 
https://skia.googlesource.com/skia.git/+log/f2a4222bb72e..071d5897eb8a

2023-07-18 nigeltao@google.com SkWuffsCodec: add "Roll third_party/wuffs" workaround

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 04:16:37 +00:00
skia-flutter-autoroll
8cad85f4f0 Roll Dart SDK from 32bc5d654e92 to 979375f92109 (1 revision) (flutter/engine#43753) 
https://dart.googlesource.com/sdk.git/+log/32bc5d654e92..979375f92109

2023-07-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-321.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 04:02:01 +00:00
Zachary Anderson
a48c39ab7e Add a GN flag to set the Dart VM's optimization level (flutter/engine#43743) 
And set the level to `-Oz` for iOS and Android.
 2023-07-17 18:57:08 -07:00
skia-flutter-autoroll
788fe03933 Roll Dart SDK from 78c9ac730629 to 32bc5d654e92 (1 revision) (flutter/engine#43751) 
https://dart.googlesource.com/sdk.git/+log/78c9ac730629..32bc5d654e92

2023-07-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-320.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-18 00:16:23 +00:00
Brian Osman
b8a91e96a8 Fix drawVertices documentation (flutter/engine#43747) 
Update the blend mode section of the documentation to specify the correct blend modes.

Fixes https://github.com/flutter/flutter/issues/130747
 2023-07-17 22:48:14 +00:00
Loïc Sharma
127e10cfcf [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710) 
The ownership of the accessibility bridge was moved from `FlutterWindowsEngine` to `FlutterWindowsView`. This change moves leftover accessibility bridge helpers/logic from the engine to the view.

Addresses: https://github.com/flutter/flutter/issues/124995
Follow-up to: https://github.com/flutter/engine/pull/41308

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-17 21:06:15 +00:00
Jason Simmons
5c61353b89 Move Dart licenses into a separate golden file (flutter/engine#43289) 
This will avoid conflicts between Dart rolls and rolls of other third
party components such as ANGLE.
 2023-07-17 14:02:00 -07:00
skia-flutter-autoroll
f1bbe70983 Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746) 
https://skia.googlesource.com/skia.git/+log/f29d58569c67..f2a4222bb72e

2023-07-17 jamesgk@google.com [graphite] Reject creation of too-large TextureProxies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-17 20:11:14 +00:00
skia-flutter-autoroll
09a78f39f2 Roll Skia from f0e1963324eb to f29d58569c67 (4 revisions) (flutter/engine#43744) 
https://skia.googlesource.com/skia.git/+log/f0e1963324eb..f29d58569c67

2023-07-17 herb@google.com Check bounds on TDArray
2023-07-17 cmumford@google.com [canvaskit] Fix integer size warning
2023-07-17 kjlubick@google.com Decouple SkSpecialImage from Ganesh and Graphite
2023-07-17 michaelludwig@google.com [skif] Check that periodic tiling can be represented by floats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-17 19:23:05 +00:00
skia-flutter-autoroll
0fd76e2b03 Roll Skia from b25cd035db06 to f0e1963324eb (2 revisions) (flutter/engine#43741) 
https://skia.googlesource.com/skia.git/+log/b25cd035db06..f0e1963324eb

2023-07-17 johnstiles@google.com Allow non-uniform derivatives in WGSL code.
2023-07-17 kjlubick@google.com Add Vello Jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-17 18:38:55 +00:00
Brandon DeRosier
09bb8d24d2 [Impeller] Correct coverage hint usage in PipelineBlend (flutter/engine#43708) 
Resolves https://github.com/flutter/flutter/issues/130411.

The remaining difference in appearance is due to https://github.com/flutter/flutter/issues/127770 -- Impeller's blurs skew too large.

Before:

![Screen Shot 2023-07-14 at 3 36 02 PM](https://github.com/flutter/engine/assets/919017/54ad62ed-f091-4489-a346-a0e7580ed2f0)

After:

![Screen Shot 2023-07-14 at 3 22 25 PM](https://github.com/flutter/engine/assets/919017/252ac8bb-4a09-4c96-a405-5ddbb3ba6851)
 2023-07-17 17:41:38 +00:00
Caroline Liu
adc9cec1df [fuchsia] flutter-embedder-test and touch-input-test use Flatland Test UI Stack (flutter/engine#43562) 
This change also:
- removes reliance from both tests on `fuchsia.ui.scenic.Scenic`
protocols
- migrates `touch-input-test` to get display info from
`fuchsia.ui.display.singleton.Info` instead of
`fuchsia.ui.gfx.DisplayInfo`
- adds support for `fuchsia.ui.display.singleton.Info` in
`portable_ui_test` to support the above
- migrates `flutter-embedder-test` to capture screenshots using
`fuchsia.ui.composition.Screenshot` instead of
`fuchsia.ui.scenic.Screenshot`
  - updates screenshot tooling accordingly
- removes the embedding view hit test disabled case from `touch-input
test`, since disabling the hit region is not currently supported in
Flutter's integration with Flatland afaict ([this
logic](4f384979af/shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc (L411-L434))
appears to set hit regions to the full view size by default, and
Flatland appears to drop the value
[here](4f384979af/shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc (L578)))
- removes hit test configurability on `touch-input-test` and
`flutter-embedder-test` embedding views

Bug: fxbug.dev/125514
 2023-07-17 13:16:13 -04:00
skia-flutter-autoroll
fb5a7d6ce3 Roll Skia from 4ec9f2497be1 to dc93f341ec38 (10 revisions) (flutter/engine#43739) 
https://skia.googlesource.com/skia.git/+log/4ec9f2497be1..dc93f341ec38

2023-07-17 herb@google.com check bounds and lengths in SkSpan
2023-07-17 kjlubick@google.com Remove SkCanvas::flush() call from skottielib
2023-07-17 michaelludwig@google.com [skif] Remove legacy Tile implementation
2023-07-17 kjlubick@google.com Revert "Revert "Decouple SkMesh from Ganesh backend""
2023-07-17 johnstiles@google.com Replace SK_WARN_UNUSED_RESULT with C++17 [[nodiscard]].
2023-07-17 kjlubick@google.com Reland "Remove #ifdefs related to SkMesh and SkSL-dependent code."
2023-07-17 johnstiles@google.com Replace SK_UNUSED with C++17 [[maybe_unused]].
2023-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from eb355bb3edcf to 2060ca2e3d59 (15 revisions)
2023-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6ffd0d20684d to 507f67ccff45 (14 revisions)
2023-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 59a5e9ba0f61 to fe667086d4ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-17 17:09:16 +00:00
skia-flutter-autoroll
762aa68bce Roll Skia from 288c98d7ef0b to 4ec9f2497be1 (1 revision) (flutter/engine#43738) 
https://skia.googlesource.com/skia.git/+log/288c98d7ef0b..4ec9f2497be1

2023-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 845e8105edb3 to 59a5e9ba0f61 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-17 16:17:00 +00:00
Chinmay Garde
8655e83638 [Impeller] Fix pipeline stats traced to the timeline. (flutter/engine#43729) 
The trace counter was missing the series name and ID.
 2023-07-16 01:32:21 +00:00
Jonah Williams
a7fd72b8ed [Impeller] fix some OpenGL Linux desktop issues. (flutter/engine#43727) 
Fixes https://github.com/flutter/flutter/issues/130514

The context wasn't current so we couldn't get the GL version.

The extension lookup was throwing an invalid enum error, the desktop opengl docs say to use a different method.
 2023-07-15 23:23:08 +00:00
skia-flutter-autoroll
f6f12ea785 Roll Skia from 0768501cd267 to ee4369879cc0 (1 revision) (flutter/engine#43728) 
https://skia.googlesource.com/skia.git/+log/0768501cd267..ee4369879cc0

2023-07-15 brianosman@google.com Revert "Add forgotten more drawMesh implementations"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 19:55:09 +00:00
skia-flutter-autoroll
822a16d06a Roll Skia from 6fb535aede4e to 0768501cd267 (3 revisions) (flutter/engine#43726) 
https://skia.googlesource.com/skia.git/+log/6fb535aede4e..0768501cd267

2023-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 831910dbe1f3 to fd07bdfdaf46 (1 revision)
2023-07-15 brianosman@google.com Revert "Remove #ifdefs related to SkMesh and SkSL-dependent code."
2023-07-15 brianosman@google.com Revert "Decouple SkMesh from Ganesh backend"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 18:54:18 +00:00
skia-flutter-autoroll
d6490c08eb Roll Fuchsia Linux SDK from DEENqWMCYI1SMYsYH... to rmzZN2ZAgpbjAFi5_... (flutter/engine#43722) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 15:22:22 +00:00
Zachary Anderson
6237207218 Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43721) 
Reverts flutter/engine#43698

A framework tree test started failing on the engine roll with this PR: https://github.com/flutter/flutter/pull/130643

The test failure is in https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20hybrid_android_views_integration_test/8517/overview

```
[2023-07-14 19:33:21.980926] [STDOUT] stdout: [   +6 ms] I/PlatformViewsController( 9988): Using hybrid composition for platform view: 5
[2023-07-14 19:33:22.767236] [STDOUT] stdout: [ +786 ms] 00:19 +4 -1: Flutter surface with hybrid composition Uses FlutterImageView when Android view is on the screen [E]
[2023-07-14 19:33:22.767765] [STDOUT] stdout: [        ]   Expected: '|-FlutterView\n'
[2023-07-14 19:33:22.767815] [STDOUT] stdout: [        ]               '  |-FlutterSurfaceView\n'
[2023-07-14 19:33:22.767924] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768084] [STDOUT] stdout: [        ]               '  |-ViewGroup\n'
[2023-07-14 19:33:22.768162] [STDOUT] stdout: [        ]               '    |-ViewGroup\n'
[2023-07-14 19:33:22.768800] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768835] [STDOUT] stdout: [        ]               ''
[2023-07-14 19:33:22.768853] [STDOUT] stdout: [        ]     Actual: '|-FlutterView\n'
[2023-07-14 19:33:22.768882] [STDOUT] stdout: [        ]               '  |-FlutterSurfaceView\n'
[2023-07-14 19:33:22.768900] [STDOUT] stdout: [        ]               '  |-FlutterImageView\n'
[2023-07-14 19:33:22.768917] [STDOUT] stdout: [        ]               '  |-ViewGroup\n'
[2023-07-14 19:33:22.768956] [STDOUT] stdout: [        ]               '    |-ViewGroup\n'
[2023-07-14 19:33:22.769119] [STDOUT] stdout: [        ]               ''
[2023-07-14 19:33:22.769156] [STDOUT] stdout: [        ]      Which: is different. Both strings start the same, but the actual value is missing the following trailing characters:   |-Flutte ...
[2023-07-14 19:33:22.779280] [STDOUT] stdout: [  +10 ms]   package:matcher/src/expect/expect.dart 149:31     fail
[2023-07-14 19:33:22.779326] [STDOUT] stdout: [        ]   package:matcher/src/expect/expect.dart 144:3      _expect
[2023-07-14 19:33:22.780315] [STDOUT] stdout: [        ]   package:matcher/src/expect/expect.dart 56:3       expect
[2023-07-14 19:33:22.780345] [STDOUT] stdout: [        ]   test_driver/main_test.dart 124:7                  main.<fn>.<fn>
[2023-07-14 19:33:22.780356] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780365] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 215:9  Declarer.test.<fn>.<fn>
[2023-07-14 19:33:22.780376] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780385] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 213:7  Declarer.test.<fn>
[2023-07-14 19:33:22.780395] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[2023-07-14 19:33:22.780405] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 258:9   Invoker._waitForOutstandingCallbacks.<fn>
[2023-07-14 19:33:22.780415] [STDOUT] stdout: [        ] 00:19 +4 -1: Flutter surface with hybrid composition (tearDownAll)
[2023-07-14 19:33:22.907295] [STDOUT] stdout: [ +126 ms] 00:19 +4 -1: (tearDownAll)
[2023-07-14 19:33:22.947855] [STDOUT] stdout: [  +41 ms] 00:19 +4 -1: Some tests failed.
```

This change in that roll looks like it may be related.
 2023-07-15 14:14:10 +00:00
Rulong Chen（陈汝龙）
b761cc404b Optimizing performance by avoiding multiple GC operations caused by multiple surface destruction notifications (flutter/engine#43587) 
Fixes: https://github.com/flutter/flutter/issues/130379

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-15 08:44:04 +00:00
skia-flutter-autoroll
e34ae42c1e Roll Skia from 271b2b6d5aaa to 975eb1250431 (2 revisions) (flutter/engine#43712) 
https://skia.googlesource.com/skia.git/+log/271b2b6d5aaa..975eb1250431

2023-07-15 johnstiles@google.com Fix error on tree about unused backbuffer variable.
2023-07-14 nigeltao@google.com SkWuffsCodec: allow Wuffs versions >= v0.3.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-15 01:43:17 +00:00
Michael Goderbauer
40c304099d Move ViewConfiguration ownership to FlutterView (flutter/engine#43701) 
This makes the FlutterView object a little bit less brittle by not depending on the PlatformDispatcher so much.
 2023-07-15 01:21:09 +00:00
Yegor
7413bfb203 [web] always add secondary role managers (flutter/engine#43663) 
Always add secondary role managers irrespective of the initial state of the semantic node, and have role manager decide whether it applies to the node or not.

Fixes https://github.com/flutter/flutter/issues/130546
 2023-07-14 23:59:04 +00:00
Dan Field
6c1b2e158b [Impeller] Fix text scaling issues again, this time with perspective when a save layer is involved (flutter/engine#43695) 
Alternative to https://github.com/flutter/engine/pull/43662

Records the basis vector of the current CTM into text contents and reuses that rather than trying to get it again at render time. That method breaks if perspective is involved in the CTM and a subpass gets translated, which can modify the scale (and rotation) of the matrix.

We're definitely not doing things quite right with perspective here, but the real fix to that is to either record the fully transformed glyph into the atlas or to use SDF/path based rendering.

Fixes https://github.com/flutter/flutter/issues/130476

I still have some concerns about how `EntityPass::Render` is a mix of mutations and constness but we can try to address that independently. 

I expect this to re-improve the regression noted in https://github.com/flutter/flutter/issues/130594
 2023-07-14 22:41:02 +00:00