Commit Graph

3751 Commits

Author SHA1 Message Date
Chinmay Garde
93a6d340fa Add explicit casts to pointer data members on Android. (flutter/engine#5558)
This accounts for changes made in https://github.com/flutter/engine/pull/5556
2018-06-18 12:08:11 -07:00
Jason Simmons
2c651a9de5 Create images from uncompressed pixel data (flutter/engine#5550)
Fixes https://github.com/flutter/flutter/issues/9184
2018-06-18 11:37:47 -07:00
Andrew Wilson
f03c5ed766 Make window metrics doubles to reduce rounding issues. (flutter/engine#5556) 2018-06-18 10:36:58 -07:00
Andrew Wilson
504172abbe Revert "Make window metrics doubles to reduce rounding issues."
This reverts commit 564095bca0.
2018-06-18 09:47:37 -07:00
Andrew Wilson
564095bca0 Make window metrics doubles to reduce rounding issues. 2018-06-18 09:43:30 -07:00
Ian Hickson
19d7432403 Remove spurious log messages (flutter/engine#5547)
These are making some of the tests that are sensitive to output flakey.
2018-06-15 14:15:35 -07:00
egdaniel
d019976b47 Nosksp backend context (flutter/engine#5544)
* Use new vulkan factory of GrContext which doens't take an sk_sp.

* remove unneeded member.
2018-06-15 14:53:50 -04:00
Maurice Parrish
be469ff641 Added method for receiving Dynamic Links (flutter/engine#5534) 2018-06-15 10:37:47 -07:00
Chinmay Garde
87576b3405 On snapshot, perform a device to host transfer for images resident on the GPU. (flutter/engine#5538) 2018-06-14 18:04:13 -07:00
Jason Simmons
f31724a16c libtxt: fix the adjustment of code unit runs for line justification (flutter/engine#5536)
Fixes https://github.com/flutter/flutter/issues/18483
2018-06-14 16:14:37 -07:00
Jason Simmons
97cf68d6c8 Lazily load fonts that are embedded within the application (flutter/engine#5533)
Previously the engine would load all embedded fonts listed in the app's
font manifest during startup.  This change creates a Skia font manager that
is backed by the engine's AssetManager and can load embedded font assets
on demand.
2018-06-14 16:13:56 -07:00
Jason Simmons
e6c5053114 libtxt: hold a weak_ptr to the txt::FontCollection in the fallback provider given to Minikin (flutter/engine#5531)
The txt::FontCollection contains a cache of minikin::FontCollection objects,
which in turn hold a fallback provider that refers back to the txt::FontCollection.
Using a weak_ptr in the fallback provider breaks the circular reference.
2018-06-14 15:50:03 -07:00
Jason Simmons
929f5df0f5 libtxt: update the unit tests and benchmarks (flutter/engine#5523)
* pass a locale to GetMinikinFontCollectionForFamily
* provide the ICU data file path
* loosen checks based on the Minikin LineBreaker's line widths
  (LineBreaker widths do not exactly match the advances calculated during layout)
2018-06-13 15:33:59 -07:00
Jason Simmons
3877686f88 Maintain a FontCollection for each engine instance instead of a process-wide singleton (flutter/engine#5521) 2018-06-13 14:28:21 -07:00
Ben Konyi
a5eb947cba Pinned versions of package:test and package:path for testing/dart tests (flutter/engine#5522) 2018-06-13 12:59:45 -07:00
Ben Konyi
a3b839a0bf IsolateNameServer reland (flutter/engine#5519)
* Reland "Added IsolateNameServer functionality (#5410)"

This reverts commit 1598c7ad7b.

* Fixed issue with isolate_name_server_test which caused test to timeout

* Disabled thread_annotations on Android as they aren't supported in the
NDK headers for std::mutex. Readded thread annotations to
IsolateNameServer.
2018-06-13 11:57:10 -07:00
Ben Konyi
1598c7ad7b Revert "Added IsolateNameServer functionality (#5410)" (flutter/engine#5516)
This reverts commit 851868ef29.
2018-06-12 17:03:13 -07:00
Ben Konyi
851868ef29 Added IsolateNameServer functionality (flutter/engine#5410)
* Added IsolateNameServer functionality, which allows for the association
of string names with isolate SendPort ids that can be used to establish
inter-isolate communications.
2018-06-12 15:50:48 -07:00
Dan Field
32b1182b0b Expose approximateBytesUsed for Picture (flutter/engine#5378) 2018-06-12 15:34:23 -04:00
Florian Loitsch
a9d585ce2f Roll the Dart VM. (flutter/engine#5510)
* Roll the Dart VM.

c95617b19c Add a release note about the VM going sync-async
05f11aa74c [kernel] Account for defaultType in some of the Kernel visitors
c39c2c8ac1 Handle type variables in optional function typed parameter in jsinterop methods
a4af44b470 [VM] Do not invoke any functions during AOT compilation
5be73cd166 Make debug printing of function types more robust.
6054cb3e1f CompilerContext always expects a Future now
6213303e65 Fix some runtime check failures in tests
d17ec7c131 Move inference data from JClosedWorld to GlobalTypeInferenceResults.
6fcc68bee3 Adjust test status.
fe21518df8 Improve literal list recovery
134e00fd73 Treat 64 bit ints as unsigned until conversion to JS.
b375d69800 [observatory] When the VM is forwarding events to the Android or Fuchsia system tracers, link to the document describing how to use them.
edb1642709 [vm] Repair interpreter build.
a9fef15ff3 Add FileResult and AnalysisDriver.getFileSync().
787a43ec78 [vm] Fix some missing private name mangling in the kernel reader.
1cf348b29f Mark enum_private_test/02 as pass, crash
cc1a817faa Use ZX_THREAD_STATE_BASIC on state output of ZX_INFO_THREAD.
4e0e72a65f Fix map_insert_remove_oom_test.
8421e69fbb [js_runtime] Make _checkLength more likely to be inlined
b66dd3d456 Stop using generic comment syntax in observatory.
b667be4861 Fix source maps strong mode runtime failure in dart2js.
7b972a653b [vm/linearscan] Account for definitions with no SSA name when processing PairLocation outputs.
09fc582bfd Fix EvalExpression test.
f2883d1b4f Fix test error message expectation on Windows.
8bfbce33f1 Mark cc/Profiler_CodeTicks as failing on Windows, dartk x64 config
a8c2263d3f Issue 33336. AnalysisDriver.discoverAvailableFiles() should notify the scheduler that there is work to do.
b7493b663e [vm/inliner] Inline small int convertors.
6b71414296 [Test status] Update status of several triaged lib_2/mirrors tests
1f03109200 Proposed replacement for SourceFactory
60631b0944 Remove unnecessary casts from observatory.
bfa8be887a Extending dartLangSpec.tex with super-bounded types and variance.
daee781179 Revise beginTypeVariable event in event sequence
e0ca1514a2 Mark test as failing.

* Update hash.
2018-06-12 18:14:24 +02:00
Chris Bracken
0ab5914e26 Revert "Eliminate support for Dart 1 (#5504)" (flutter/engine#5505)
Broke runtime_unittests, which are still running directly from source.

This reverts commit 6a89437fec.
2018-06-11 18:12:10 -07:00
Chris Bracken
6a89437fec Eliminate support for Dart 1 (flutter/engine#5504)
Eliminates support for running directly from sources or script snapshots. In
debug mode, we run from a kernel snapshot; in profile and release modes, we
link in AOT-compiled code.

Renames --dart-non-checked-mode to --disable-dart-asserts since checked mode
does not make sense in Dart 2.
2018-06-11 17:00:43 -07:00
Dan Field
5d78c7447b make analyzer happy (flutter/engine#5499) 2018-06-10 12:47:14 -04:00
Dan Field
e90ea73260 Allow custom foreground paint to be used for drawing text (flutter/engine#5395)
* Allow specifying the foreground paint

* fix typo

* doc update

* call paint.reset
2018-06-10 00:21:18 -04:00
Stanislav Baranov
633a89dbb3 Support for saving Dart compilation trace on device. (flutter/engine#5443)
Support for saving Dart compilation trace on device.
2018-06-08 15:26:29 -07:00
Chris Bracken
f2a864c5e4 Enforce clang-format on all files in commit (flutter/engine#5495)
* Enforce clang-format on all files in commit

This re-enforces clang-format across all files changed in the commit.

In c10c417, we enabled checking only for the lines changed in the diff
in order to reduce the change of merge conflicts with the shell refactor
landed in 82c5c8f.

* Reformat sources to match latest clang-format

As part of re-enabling clang-format across the codebase, reformat all
code to match the latest toolchain.
2018-06-08 15:10:54 -07:00
Greg Spencer
2681ed21ac Fixing image encoding format conversion. (flutter/engine#5489)
On a Linux host, we were having to convert the type of the bitmap to N32, but we weren't also fixing the channel order to RGBA, so consequently we were getting BGRA when the API was asking for RGBA. This forces the color format to be RGBA when that is what is asked for.

We weren't needing to do conversion on macOS, so macOS was always getting RGBA.
2018-06-07 18:06:47 -07:00
Stanislav Baranov
6d140f4e43 Fix compile error introduce in #5473. (flutter/engine#5488)
Fix compile error introduced in #5473.
2018-06-07 15:36:35 -07:00
Stanislav Baranov
5afc3daf35 Support running bundles from zip file. (flutter/engine#5473)
Support running bundles from zip file.
2018-06-07 15:09:23 -07:00
Jason Simmons
7087b9810f libtxt: only apply ellipsizing to the last text run in the line (flutter/engine#5486)
Paragraph layout breaks the text into lines, and ellipsizing (if applicable)
will truncate the last run of a line at the point where word wrap would have
occurred.

Fixes https://github.com/flutter/flutter/issues/18198
2018-06-07 14:24:03 -07:00
Zachary Anderson
18f4c34c51 Revert: Remove uses of ReleaseOwnership from vulkan backend (flutter/engine#5484) 2018-06-07 10:42:48 -07:00
Greg Spencer
614d9a1d10 Fix animation diagram identifiers (flutter/engine#5481)
I forgot that the identifiers need to be unique per page for the animation tags.
This makes them unique.

Doc change only, no code.
2018-06-06 16:15:13 -07:00
Greg Spencer
4d1bb07254 Add diagram links for StrokeJoin and StrokeCap (flutter/engine#5456)
This updates the documentation for StrokeJoin and StrokeCap to contain animated diagrams that describe their function. The actual diagrams reside in the assets-for-api-docs repo.
2018-06-06 14:10:52 -07:00
Jason Simmons
979746e748 libtxt: add all styles of a fallback font family to the cache (flutter/engine#5474)
libtxt will query Skia for a fallback typeface when it encounters a character
that is not found in the primary font.  The font collection should make all
the variants of the fallback typeface's font family available to Minikin for
use in future font lookups.

Fixes https://github.com/flutter/flutter/issues/17985
2018-06-06 12:22:50 -07:00
Sigurd Meldgaard
916d9eb5fc App life cycle delegate (flutter/engine#5302)
* Move the handling of delegating AppDelegate callback out of FlutterAppDelegate.

Also moves the plugin registry to FlutterViewController. So each view-controller will handle its
own plugins.

This is intended to simplify including one or more Flutter views in an existing iOS app and giving
more precise control of plugin registration.

Fixes: https://github.com/flutter/flutter/issues/16539

* formatting

* Update license golden file

* Fixed type error

* FREEZE.unindexed

* Fix Header types

* Revert "FREEZE.unindexed"

This reverts commit bebb70056c9bcb90b4321bdc2873896623ed6faa.
2018-06-06 10:49:40 +02:00
Zachary Anderson
e95110f16f Adds dynamic, interpreter configs to tools/gn (flutter/engine#5446)
Adds --dynamic and --interpreter flags to
tools/gn. These flags result in engines with
properties as follows:

--dynamic:
- JIT targeting native code on Android and
  DBC on iOS

--interpreter
- Target DBC even if running on Android.

For example:

gn --android --dynamic --interpreter --runtime-mode release

Will generate an engine:
- Without Dart asserts
- Without Observatory
- With JIT compililation to DBC

into out/android_dynamic_release_dbc
2018-06-05 14:52:52 -07:00
Stanislav Baranov
5c89db5409 Remove unused argument. (flutter/engine#5471) 2018-06-05 13:11:18 -07:00
Alexander Aprelev
da47083cc5 Roll dart to a5e41681e55d1e74684bfff530218db556d77ee8 (flutter/engine#5467)
* Roll dart to a5e41681e55d1e74684bfff530218db556d77ee8.

* Update license
2018-06-05 08:35:44 -07:00
Mikkel Nygaard Ravn
dcbfb0277c Update FlutterPluginRegistrxxx docs for iOS (flutter/engine#5415) 2018-06-05 08:19:07 +02:00
Chinmay Garde
f2875584e3 Fix Dart project configuration for headless Dart runners. (flutter/engine#5461) 2018-06-04 15:01:58 -07:00
Jason Simmons
455786e30a libtxt: fix bug in calculating line end positions excluding whitespace (flutter/engine#5459)
Fixes https://github.com/flutter/flutter/issues/18014
2018-06-04 13:28:38 -07:00
egdaniel
c853d53156 Remove uses of ReleaseOwnership from vulkan backend (flutter/engine#5458)
* Remove uses of ReleaseOwnership from vulkan backend.

Flutter no longer needs to release ownership of objects to skia so this change removes the api calls.

* Remove Release call from vulkan_device.cc

* Update vulkan_application.h

* Update vulkan_application.cc

* Update vulkan_handle.h
2018-06-04 15:46:24 -04:00
egdaniel
800005b4c9 Update GrVkBackendContext to no longer own the VkInstance and VkDevice (flutter/engine#5457)
This changes the ownership of the VkInstance and VkDevice back to the flutter's objects. I am trying to move skia into a world where GrVkBackendContext is purely a description of the vulkan context skia should use and is just passed in during GrContext creation. It shouldn't need to be ref counted or actually do work in destructor (those changes to come later). This is just a first step towards getting there.
2018-06-04 14:46:12 -04:00
Jason Simmons
05f8cdb39b libtxt: support per-locale fallback font collections (flutter/engine#5434)
A given character may render differently in various locales, and fonts on the
host system may be tagged with locale metadata in order to support this.
If the text renderer needs to find a fallback font for a character, it should
pass the preferred locale to Skia's font manager which can use it to find the
best matching font.

The font collection also needs to maintain different caches of fallback fonts
for each locale.

See https://github.com/flutter/flutter/pull/17879
2018-06-04 10:55:43 -07:00
Chinmay Garde
23fd79d790 Parse --verbose-logging flag from intent and pass to the engine as args. (flutter/engine#5447) 2018-06-01 17:34:45 -07:00
Jason Simmons
b3c936ed84 Log an error and cancel DartVM init if the VM/isolate snapshots are invalid (flutter/engine#5449)
See https://github.com/flutter/flutter/issues/18101
2018-06-01 17:34:25 -07:00
Ian Hickson
127b1e271a Update CONTRIBUTING.md (flutter/engine#5444) 2018-06-01 13:24:53 -07:00
Stanislav Baranov
9054d0f274 Restore archive support removed in #5305. Codepush bundles use zip. (flutter/engine#5441) 2018-06-01 12:46:27 -07:00
Alexander Markov
b7cc2b98b0 Remove --limit-ints-to-64-bits Dart VM option (flutter/engine#5442) 2018-06-01 11:05:38 -07:00
Mehmet Fidanboylu
4d4a42b63c Fix lint errors to prepare for building Android files in Google (flutter/engine#5440) 2018-06-01 10:16:50 -07:00