Commit Graph

23 Commits

Author SHA1 Message Date
LongCatIsLooong
f2c6f03ca3 Catch Stopwatch with static analysis (#140019)
I did not include the `'// flutter_ignore_for_file: stopwatch (see analyze.dart)'` directive since it's currently not used, and adding that shouldn't be too difficult.
2023-12-14 00:31:49 +00:00
Kate Lovett
133711ba9a Analyze against using Stopwatches in the framework (#138507) 2023-11-29 08:49:35 -06:00
Tomasz Gucio
99c7e9f088 Add spaces after flow control statements (#126320) 2023-05-15 11:07:30 +02:00
Ian Hickson
806c1f8186 Deprecate these old APIs (#116793)
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Michael Goderbauer
b308555ed1 Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Zachary Anderson
a84e369bd2 Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226 Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Darren Austin
d9be807192 Updated the analyze.dart deprecation check to only look for beta branch versions. (#105290) 2022-06-06 21:16:49 -07:00
Zachary Anderson
366648ae90 Revert "Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535)" (#93323)
This reverts commit bfe9c59831.
2021-11-09 08:44:56 -08:00
Greg Spencer
bfe9c59831 Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535) 2021-11-08 21:28:02 -08:00
Kate Lovett
616f9bcffa Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Tong Mu
7abee113e8 [Analyze] Make deprecation note analyzer clearer on quote misuse (#77653)
* Impl

* Escape$

* eofnl

* Make message more clear
2021-03-09 13:21:45 -08:00
Michael Goderbauer
d3209379ba enable provide_deprecation_message (#77106) 2021-03-02 16:34:05 -08:00
Michael Goderbauer
fc99e7c0d7 Enable missing_whitespace_between_adjacent_strings (#77027) 2021-03-01 18:30:17 -08:00
Christopher Fujino
5cfb16b193 Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino
0d7ff7a9e7 Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson
8665e13801 Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Ian Hickson
449f4a6673 License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Michael Goderbauer
f8cafd9dbc Remove URLs in deprecation annotation (#45215) 2019-11-20 12:45:04 -08:00
Ian Hickson
62e4ab87b3 Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00