firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,695 Commits 1 Branch 0 Tags
88295dffb8e46db41f2f7d2e35f4bd858917cabf
Commit Graph

24777 Commits

Author SHA1 Message Date
skia-flutter-autoroll
88295dffb8 Roll Skia from 9c369abd687d to 17b6555a1551 (5 revisions) (flutter/engine#47975) 
https://skia.googlesource.com/skia.git/+log/9c369abd687d..17b6555a1551

2023-11-13 egdaniel@google.com Update comment in AUTHORS file for CLA
2023-11-13 kjlubick@google.com Set SK_DEFAULT_TYPEFACE_IS_EMPTY and SK_DISABLE_LEGACY_DEFAULT_TYPEFACE
2023-11-13 jvanverth@google.com Revert "Add use of sk_ieee_float_divide to init_stop_pos."
2023-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cb7d58ad6c31 to 855191177ccd (11 revisions)
2023-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 7836e1b2d5e8 to dc295723a2e4 (31 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-13 17:27:46 +00:00
Daco Harkes
750abcd7d8 Revert "[deps] Stop moving NDK folder inside Android SDK (#47454)" (flutter/engine#47905) 
Reverts

* https://github.com/flutter/engine/pull/47454

and adds documentation

The NDK folder shuffling in the DEPS is to simplify the build files and enable building with different NDK versions between Dart and Flutter while sharing the build files.

Closes: https://github.com/flutter/flutter/issues/136666

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-13 16:45:34 +00:00
skia-flutter-autoroll
9a967b396d Roll Skia from 7b730016006e to 9c369abd687d (3 revisions) (flutter/engine#47969) 
https://skia.googlesource.com/skia.git/+log/7b730016006e..9c369abd687d

2023-11-13 robertphillips@google.com Make VkTestHelper a virtual base class and add GaneshVkTestHelper
2023-11-13 kjlubick@google.com Reland "Add SkFontMgr option to DataURI resources and clean up predecoding"
2023-11-13 egdaniel@google.com [Graphite] Add Dawn Mac perf bots.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-13 16:10:22 +00:00
skia-flutter-autoroll
c4c8e9dc66 Roll Skia from 3a7a6d23ab4f to 7b730016006e (1 revision) (flutter/engine#47967) 
https://skia.googlesource.com/skia.git/+log/3a7a6d23ab4f..7b730016006e

2023-11-13 robertphillips@google.com Use VulkanBackendContext setting to initialize VulkanCaps' protectedness

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-13 15:07:05 +00:00
skia-flutter-autoroll
fdded3dce6 Roll Fuchsia Linux SDK from K3jvECt7y1_-zBVw3... to UaodAPcg8HCGdDb-C... (flutter/engine#47962) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-13 11:01:14 +00:00
Zachary Anderson
c921b9e08e Reverts Dart SDK to 3.3.0-120.0.dev (flutter/engine#47959) 
For https://github.com/flutter/flutter/issues/138326
 2023-11-12 11:30:10 -08:00
skia-flutter-autoroll
7454ddda58 Roll Fuchsia Linux SDK from 8sk2n2-NXJ-ceyc7T... to ikCrJNCuuApNeuH-6... (flutter/engine#47950) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-11 09:10:05 +00:00
skia-flutter-autoroll
630cfb3ab5 Roll Dart SDK from a03a7b62eb4e to 6415489ae51b (1 revision) (flutter/engine#47949) 
https://dart.googlesource.com/sdk.git/+log/a03a7b62eb4e..6415489ae51b

2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-122.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-11 08:35:06 +00:00
skia-flutter-autoroll
5aafd06b8b Roll Skia from 290962a9d913 to 1e9711980c61 (1 revision) (flutter/engine#47940) 
https://skia.googlesource.com/skia.git/+log/290962a9d913..1e9711980c61

2023-11-11 kjlubick@google.com Reland "Reland "Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-11 06:11:54 +00:00
skia-flutter-autoroll
cea1ed6774 Roll Skia from 7eaff63b1425 to 290962a9d913 (5 revisions) (flutter/engine#47937) 
https://skia.googlesource.com/skia.git/+log/7eaff63b1425..290962a9d913

2023-11-10 jvanverth@google.com Add use of sk_ieee_float_divide to init_stop_pos.
2023-11-10 fmalita@google.com Revert "Add SkFontMgr option to DataURI resources and clean up predecoding"
2023-11-10 johnstiles@google.com Revert "Disable PixelLocalStorage test to allow Dawn to roll."
2023-11-10 johnstiles@google.com Enable extensions that Skia relies upon in validate_wgsl.
2023-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1b3bc53dbf39 to cb7d58ad6c31 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-11 01:02:05 +00:00
Brandon DeRosier
fa96666e03 [Flutter GPU] Add DeviceBuffer. (flutter/engine#47699) 
Part of http://flutter.dev/go/impeller-dart

Resolves https://github.com/flutter/flutter/issues/130924.
Resolves https://github.com/flutter/flutter/issues/130925.

Create and upload data to host visible device buffers. Commands should allow for binding either HostBuffers (which eventually resolve to DeviceBuffers) or DeviceBuffers. There's a `Buffer` mixin to allow for expressing this in `BufferView`, but this may end up changing once I actually add Commands and need to solve the puzzle.
 2023-11-11 00:56:51 +00:00
Victoria Ashworth
f223a37e77 Only run tests on macOS 12 (flutter/engine#47933) 
There's an [issue](https://github.com/flutter/flutter/issues/138238) with mac_toolchain that makes Xcode installs flakey and an [issue](https://github.com/flutter/flutter/issues/138246) that makes Xcode installs more frequent on macOS 13, which is causing presubmit tests to fall frequently. In the meantime, we'll only have tests run on macOS 12.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-11 00:23:12 +00:00
auto-submit[bot]
e5da8d9a87 Reverts "Bump minSdk to 19 for Android tests" (flutter/engine#47935) 
Reverts flutter/engine#47686
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following https://github.com/flutter/buildroot/pull/750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-10 23:06:18 +00:00
skia-flutter-autoroll
5a9a98c311 Roll Dart SDK from 91c4a92a64ea to 370145bbbd4f (1 revision) (flutter/engine#47930) 
https://dart.googlesource.com/sdk.git/+log/91c4a92a64ea..370145bbbd4f

2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-120.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 22:30:05 +00:00
skia-flutter-autoroll
a048df42d0 Roll Skia from 2c43bf002b7f to 96ce4d6f433d (3 revisions) (flutter/engine#47931) 
https://skia.googlesource.com/skia.git/+log/2c43bf002b7f..96ce4d6f433d

2023-11-10 johnstiles@google.com Simplify graphite_vert logic slightly.
2023-11-10 jannh@google.com RasterPathAtlas: fix key builder index typo
2023-11-10 johnstiles@google.com Simplify graphite_frag logic slightly.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 22:23:05 +00:00
Jim Graham
77fcf57543 [Impeller] implement Canvas::DrawLine to tesselate lines directly (flutter/engine#47846) 
Impeller implements the DrawLine primitive as DrawPath on a path containing a single line. Benchmarks show that this can cost 30% overhead on apps that use a lot of DrawLine primitives. This PR creates a more direct Entity that can tesselate the geometry of a line directly.

The reduced overhead should help with https://github.com/flutter/flutter/issues/138004

The current code will back off to Path rendering for round caps. When the circle geometry work is finished (https://github.com/flutter/engine/pull/47845) we can come back and implement round caps using the code refactored in that PR.
 2023-11-10 22:13:43 +00:00
skia-flutter-autoroll
73636fb1ef Roll Skia from d06840545bff to 2c43bf002b7f (1 revision) (flutter/engine#47928) 
https://skia.googlesource.com/skia.git/+log/d06840545bff..2c43bf002b7f

2023-11-10 jvanverth@google.com Add null checks to GrTriangulator rewind_if_necessary.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 21:39:23 +00:00
utzcoz
1e558fcece Bump minSdk to 19 for Android tests (flutter/engine#47686) 
The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following https://github.com/flutter/buildroot/pull/750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-10 21:35:57 +00:00
Dan Field
f4700623fb [Impeller] Reduce allocations for polyline generation (flutter/engine#47837) 
Before this patch, polyline generation did lots of small allocations over and over again.

Now, `Path::CreatePolyline` takes a `std::vector<Point>` that the caller can reserve such that it won't likely need to be resized. The tessellator has been updated to hold a thread_local point buffer that gets reused and avoids lots of intra-frame allocation. This improves the profiles seen in https://github.com/flutter/flutter/issues/138004, specifically around the [`FillPointsForPolyline` time](https://user-images.githubusercontent.com/8975114/281116688-2d519d24-7838-405c-9e99-df5ceacf0917.png)

This very significantly improves the benchmarking data in geometry_benchmarks.

The first commit in this patch _slightly_ improves the benchmarks by reducing some allocations, but not enough of them.
 2023-11-10 21:34:13 +00:00
skia-flutter-autoroll
2f99383a5f Roll Skia from 126c8faf6c36 to c4af3caee55c (4 revisions) (flutter/engine#47920) 
https://skia.googlesource.com/skia.git/+log/126c8faf6c36..c4af3caee55c

2023-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d3e897d99222 to 7836e1b2d5e8 (8 revisions)
2023-11-10 herb@google.com Improve Segment intersection
2023-11-10 kjlubick@google.com Revert "Reland "Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr""
2023-11-10 bungeman@google.com Saturate glyph bounds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 19:57:15 +00:00
skia-flutter-autoroll
c7039e4fb4 Roll Skia from 384f047aa0b6 to 126c8faf6c36 (4 revisions) (flutter/engine#47916) 
https://skia.googlesource.com/skia.git/+log/384f047aa0b6..126c8faf6c36

2023-11-10 jvanverth@google.com Add isEmpty() check to transformed imageBounds.
2023-11-10 kjlubick@google.com Reland "Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr"
2023-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 6e457de6a528 to fb11678cf25f (1 revision)
2023-11-10 robertphillips@google.com Remove use of VkTestHelper in VkYcbcrSampler tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 18:53:10 +00:00
skia-flutter-autoroll
dcdcedb4e1 Roll Dart SDK from 33307e78db2b to 91c4a92a64ea (6 revisions) (flutter/engine#47915) 
https://dart.googlesource.com/sdk.git/+log/33307e78db2b..91c4a92a64ea

2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-119.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-118.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-117.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-116.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-115.0.dev
2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-114.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 18:31:32 +00:00
skia-flutter-autoroll
1e8e905af9 Roll Skia from 5df579e87784 to 384f047aa0b6 (4 revisions) (flutter/engine#47912) 
https://skia.googlesource.com/skia.git/+log/5df579e87784..384f047aa0b6

2023-11-10 robertphillips@google.com [graphite] Add Pixel6/Pixel7 Graphite_Vulkan jobs
2023-11-10 kjlubick@google.com Add SkFontMgr option to DataURI resources and clean up predecoding
2023-11-10 kjlubick@google.com Add workaround for CQ bug for Dawn rolls
2023-11-10 robertphillips@google.com Add VkTestHelper::createSurface and submitAndWaitForCompletion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 17:44:06 +00:00
Camille Simon
809cc6c652 [Android] Bump robolectric version to support unit testing on Android 34 (flutter/engine#47768) 
Bumps robolectric version from 4.10.3 --> 4.11 to support unit testing on Android 34!

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-10 16:54:16 +00:00
skia-flutter-autoroll
d84d86c162 Roll Skia from ae6df7264c6e to 5df579e87784 (1 revision) (flutter/engine#47910) 
https://skia.googlesource.com/skia.git/+log/ae6df7264c6e..5df579e87784

2023-11-10 brianosman@google.com Reland "Redesign raster pipeline tail handling"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 16:52:53 +00:00
Mouad Debbar
7ca2f495af [web] Move styling from FlutterViewEmbedder to StyleManager (flutter/engine#47489) 
- Move default style values from `FlutterViewEmbedder` to `StyleManager`.
- Move DOM tag names from `FlutterViewEmbedder` to `DomManager`.
- Deduplicate style sheet creation code and put it in `StyleManager`.

Part of Part of https://github.com/flutter/flutter/issues/134443
 2023-11-10 16:08:23 +00:00
skia-flutter-autoroll
5e3e3c03a9 Roll Skia from e23e328584a1 to ae6df7264c6e (1 revision) (flutter/engine#47907) 
https://skia.googlesource.com/skia.git/+log/e23e328584a1..ae6df7264c6e

2023-11-10 ccameron@chromium.org SkTiffImageFileDirectory: Avoid divide by zero

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 16:04:33 +00:00
auto-submit[bot]
6e8d3995d7 Reverts "Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions)" (flutter/engine#47909) 
Reverts flutter/engine#47899
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://dart.googlesource.com/sdk.git/+log/33307e78db2b..5075ac874117

2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-116.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-115.0.dev
2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-114.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 15:58:26 +00:00
Victoria Ashworth
c2e95e79be Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#47883) 
`UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays` seems to fail pretty flakily on macOS 13.6.1. Temporarily disabling until we can find a solution (https://github.com/flutter/flutter/issues/138193).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-10 13:00:01 +00:00
skia-flutter-autoroll
3e3e28359c Roll Dart SDK from 33307e78db2b to 5075ac874117 (3 revisions) (flutter/engine#47899) 
https://dart.googlesource.com/sdk.git/+log/33307e78db2b..5075ac874117

2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-116.0.dev
2023-11-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-115.0.dev
2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-114.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 08:27:07 +00:00
skia-flutter-autoroll
7d119be398 Roll Fuchsia Linux SDK from 0pD5ceqf-e9y9NTNn... to 8sk2n2-NXJ-ceyc7T... (flutter/engine#47898) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 08:23:16 +00:00
Srujan Gaddam
31d3ab1d52 Remove implements of JS types on @staticInterop classes (flutter/engine#47869) 
JS types are going to become extension types and as such, @staticInterop
types cannot implement these types. When we migrate these classes to
extension types, we can add back the subtyping.

Enables https://github.com/dart-lang/sdk/issues/52687.
 2023-11-09 19:56:14 -08:00
skia-flutter-autoroll
43d95f8e0b Roll Skia from 971e197ca81a to 5075f1572bfe (2 revisions) (flutter/engine#47885) 
https://skia.googlesource.com/skia.git/+log/971e197ca81a..5075f1572bfe

2023-11-09 bungeman@google.com [pdf] Generate outline from structure tree
2023-11-09 sunnyps@chromium.org graphite: Set mappedAtCreation for MapWrite Dawn buffers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-10 00:52:10 +00:00
skia-flutter-autoroll
e9381c245f Roll Skia from 583c85e03fb0 to 971e197ca81a (1 revision) (flutter/engine#47879) 
https://skia.googlesource.com/skia.git/+log/583c85e03fb0..971e197ca81a

2023-11-09 brianosman@google.com Revert "Redesign raster pipeline tail handling"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 23:56:18 +00:00
gaaclarke
002ab77448 Expanded the performance lints (flutter/engine#47868) 
fixes https://github.com/flutter/flutter/issues/137372

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 23:54:01 +00:00
skia-flutter-autoroll
272f2f334c Roll Skia from 6ff0fdf79bfa to 583c85e03fb0 (6 revisions) (flutter/engine#47877) 
https://skia.googlesource.com/skia.git/+log/6ff0fdf79bfa..583c85e03fb0

2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 48e35a606e12 to 7c0dd491306e
2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 5274816f3d53 to 6e457de6a528 (2 revisions)
2023-11-09 hitawala@chromium.org Graphite: Clean up BackendTexture fDawnTextureView and related methods
2023-11-09 kjlubick@google.com Add comment about possible ODR violation
2023-11-09 brianosman@google.com Redesign raster pipeline tail handling
2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fd7e3d444d59 to 7de2ef0af919 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 21:19:06 +00:00
Jonah Williams
43e50ac6b9 [Impeller] Remove unused/untested Path APIs. (flutter/engine#47841) 
This will simplify the Path internals cleanup that I'd like to land as a part of https://github.com/flutter/flutter/issues/138004
 2023-11-09 21:15:59 +00:00
Alexander Thomas
734e8cb452 Remove references to the runtime/third_party directory in the Dart SDK (flutter/engine#47853) 
Content of this directory has been moved to third_party in the Dart SDK checkout:
https://dart-review.googlesource.com/c/sdk/+/332963
 2023-11-09 21:11:57 +00:00
skia-flutter-autoroll
43ae11d449 Roll Skia from ff418c512205 to 6ff0fdf79bfa (2 revisions) (flutter/engine#47874) 
https://skia.googlesource.com/skia.git/+log/ff418c512205..6ff0fdf79bfa

2023-11-09 johnstiles@google.com Disable PixelLocalStorage test to allow Dawn to roll.
2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 5037b3433fc8 to 5274816f3d53 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 20:10:03 +00:00
Michael Goderbauer
ba990078f8 Reland "Remove physical geometry" (flutter/engine#47872) 
Relands #47825 with a doc fix (see second commit).
 2023-11-09 19:39:20 +00:00
Mouad Debbar
6d1d4eb984 [web] Refactor a11y announcements out of FlutterViewEmbedder (flutter/engine#47487) 
- Remove a11y announcements from `FlutterViewEmbedder`.
- Simplify a11y announcements tests so they don't need `FlutterViewEmbedder` nor `DomManager`.
- Left a few a11y-multi-view TODOs (cc @yjbanov).

Part of https://github.com/flutter/flutter/issues/134443
 2023-11-09 19:28:05 +00:00
skia-flutter-autoroll
6037ed08e0 Roll Skia from a58076ed871a to ff418c512205 (5 revisions) (flutter/engine#47871) 
https://skia.googlesource.com/skia.git/+log/a58076ed871a..ff418c512205

2023-11-09 egdaniel@google.com [Graphite] Add option to add ReleaseCallback when wrapping in SkSurface.
2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6a90ad65ed95 to 2ea1ed569c90
2023-11-09 nicolettep@google.com Handle Android-only VkExternalFormatANDROID declaration in correct scope
2023-11-09 brianosman@google.com Remove various unused load/store functions from RP
2023-11-09 jlavrova@google.com ICU4X via bazel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 19:14:04 +00:00
skia-flutter-autoroll
5d5b729d4a Roll Skia from 775da2d297de to a58076ed871a (3 revisions) (flutter/engine#47866) 
https://skia.googlesource.com/skia.git/+log/775da2d297de..a58076ed871a

2023-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 46e9e4cbfdfc to 3ec333906a35 (4 revisions)
2023-11-09 michaelludwig@google.com [graphite] Use kFibonacci GrowthPolicy in more SkTBlockLists
2023-11-09 jvanverth@google.com Fix MacOS features check.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 18:12:14 +00:00
Gray Mackall
1dc6423dac [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47839) 
The difference between this PR and the original is the change to the `AndroidManifest.xml`. For context, right before the original PR landed, [a change to upgrade the target sdk](https://github.com/flutter/engine/pull/47683) in the manifest from 31 to 33 landed. It also removed the lint complaining about using an old target sdk version from the baseline lint file. So this change upgrading the sdk, but not the target sdk in the manifest, triggered the lint again.

For the rest of the PR, [see the description of the original PR](https://github.com/flutter/engine/pull/47609).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 18:02:18 +00:00
Victoria Ashworth
5b6fce7cb9 Use specific version of mac_toolchain (flutter/engine#47835) 
Newer versions of mac_toolchain increase Xcode install times by ~2 minutes (https://github.com/flutter/flutter/issues/138109). As a temporary solution, we're using an older version of mac_toolchain.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-09 17:38:49 +00:00
skia-flutter-autoroll
20430cf3e4 Roll Skia from df263765ebc8 to 775da2d297de (2 revisions) (flutter/engine#47861) 
https://skia.googlesource.com/skia.git/+log/df263765ebc8..775da2d297de

2023-11-09 brianosman@google.com Remove unused store_u16_be raster pipeline stage
2023-11-09 johnstiles@google.com Use STArray for MeshGP arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 16:52:18 +00:00
auto-submit[bot]
aa4fb605c3 Reverts "Remove physical geometry" (flutter/engine#47862) 
Reverts flutter/engine#47825
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.

Related framework PR: https://github.com/flutter/flutter/pull/138103 (Checks will fail until that PR is submitted).
 2023-11-09 16:06:19 +00:00
skia-flutter-autoroll
c378306ada Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860) 
https://skia.googlesource.com/skia.git/+log/7d0768083298..df263765ebc8

2023-11-09 johnstiles@google.com Remove skcms_internal.h from modules/skcms.
2023-11-09 robertphillips@google.com Add VkTestHelper factory

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 15:45:27 +00:00
skia-flutter-autoroll
47ed379656 Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857) 
https://dart.googlesource.com/sdk.git/+log/6f36eb00cacf..6bd98dc2dffd

2023-11-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-112.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 13:56:10 +00:00
skia-flutter-autoroll
f89e9b9fd4 Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-09 03:40:39 +00:00