The hermetic Xcode tooling in that repo is not yet easily usable for
Xcode 9. There are two main issues:
1. The tooling currently assumes that macOS host builds should use
Xcode 8, whereas iOS builds should use Xcode 9. Flutter builds should
use Xcode 9 in all cases.
2. The tooling currently includes a bail-out condition for iOS builds
that exits non-zero immediately (Chrome hasn't yet migrated its iOS
build to this tooling).
In the meantime, I've manually updated the bot infra with Xcode 9 and
we'll continue to use the current find_xcode.py tooling until Chrome's
new Mac/iOS tooling is ready.
* Roll dart to pick up fix for diagnostic server
* Fix runUnaryGuarded, runBinaryGuarded calls
* Revert changes to runUnaryGuarded, runBinaryGuarded as they seem to be local-only, perhaps dependent on version of analyzer
* Update third_party license hash. No changes to licenses
* Revert "Pass option to reuse an existing runtime controller (#4253)"
This reverts commit c281542231.
* Revert "Document the Porter-Duff operators. (#4250)"
This reverts commit 73a218a980.
* Revert "Move channel and codec related files to common (#4225)"
This reverts commit 8a687cb332.
minikin::LineBreaker does not convert newline characters into line breaks
in its output. Previously libtxt's version of LineBreaker container a patch
that added a large width offset for a newline in order to force wrapping to
the next line. This works if the offset exceeds the paragraph's width
constraint. But if the paragraph is laid out with infinite width, then the
text after the newline will continue on the current output line.
This change separates the paragraph's text into newline delimited blocks and
feeds each block separately to the minikin LineBreaker.
Also, libtxt was breaking the input styled text runs at newline boundaries.
This is no longer necessary.
The output_name property of a template is typically relative to the
root_build_dir rather than the target_gen_dir. This patch makes flutter_app
consistent with this pattern.
* Fix for issue 12526
Ensure that child isolates do not clear the dart_ui_state_ field present in the dart controller.
The commit 093a8a4dfd implemented code to reset the dart_ui_state_ back to null when an isolate was being shutdown to ensure there was no use after free issues when the main isolate exeutes Isolate.current.kill() it however it was also clearning the field when a child isolate was shutdown causing SEGVs later.
* Address code format issues.
* Add dependency on chromium/src/build for Mac/iOS build
Preparation for migrating to mac_toolchain.py for installing/configuring
Xcode versions on the Mac build bots.
* Exclude third_party/chromium_build from licence script
It's used only at build time to fetch and install the correct Xcode
version.
maxIntrinsicWidth is the sum of the width of all lines in the input
(if the width were any smaller, the renderer might have to wrap a line)
minIntrinsicWidth is the maximum width of a word (if the paragraph were
any narrower, the renderer would have to truncate a word)
