firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,044 Commits 1 Branch 0 Tags
75ed8da88418c07e3cf8c7094de09e0bb3a3da24
Commit Graph

25035 Commits

Author SHA1 Message Date
skia-flutter-autoroll
696b837f74 Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) (flutter/engine#48120) 
https://dart.googlesource.com/sdk.git/+log/5cccc24d127f..b512191e9612

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-142.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 13:38:33 +00:00
skia-flutter-autoroll
86e7d7731d Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... (flutter/engine#48115) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 08:49:15 +00:00
skia-flutter-autoroll
eca85da3ce Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100) 
https://dart.googlesource.com/sdk.git/+log/65819963fb17..cc6acfd7d57c

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-140.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-139.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-138.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-137.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-136.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 02:16:32 +00:00
Matan Lurey
0371968293 Make fml/status_or.h compatible with .clang_tidy. (flutter/engine#48002) 
Work towards https://github.com/flutter/flutter/issues/134969.
 2023-11-15 18:08:56 -08:00
Dan Field
d38b0967a0 [Impeller] Gate Vulkan selection on API 29 (flutter/engine#48089) 
Platform Views on Android require API 29 when using Vulkan.

~~I'm not sure if I did the CI changes right, want to run it here and see. The added test needs to run on a device or emulator with API 29 or above and API 28 or below to be valid.~~

Makes the following changes to CI:

- Runs the emulator tests on presubmit, but only if `shell/platform/android/**` or `lib/ui/**` or `.ci.yaml` changes.
- Changes the emulator tests to be a regular engine_v2 test that spawns an x86 build. Unfortunately, the older API level emulators are only available for x86, not x86_64, and you cannot run the binary we create unless it matches the ABI.
- Runs the new test on both API 28 and API 34.

Fixes https://github.com/flutter/flutter/issues/132984

/cc @johnmccutchan fyi
 2023-11-16 02:04:41 +00:00
Chris Bracken
17d7e20c16 [macOS] Clean up allocations in menu plugin test (flutter/engine#48093) 
Runs all FlutterMenuPlugin tests in an AutoReleasepoolTest, which                   
ensures all allocations are cleaned up.                                             
                                                                                    
Also extracts out some hackery into the FlutterMenuPluginTest fixture to            
ensure that NSApplication instantiates everything necessary to do menu              
bar manipulation.                                                                   
                                                                                    
Also replaces the use of OCMock in FlutterMenuPluginTest.mm with a fake             
FakePluginRegistrar class. This avoids unnecessary use of OCMock in the             
tests, which has been responsible for flakiness in some tests, in                   
particular where the mock is used across threads. This test was not                 
problematic, but the fake makes the tests more readable.                            
                                                                                    
Also fixes linter warnings about using NSLocalizedString for user-facing            
strings.

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840
 2023-11-15 16:40:39 -08:00
Matan Lurey
da57416cbe Re-land "Make fml/... compatible with .clang_tidy (flutter/engine#48030) 
Reverts flutter/engine#48004
 2023-11-16 00:09:24 +00:00
Chris Yang
c07e3193e7 [ios] introduce weak_nsobject (flutter/engine#47947) 
Introduce weak_nsobject from chromium. 

There are some usages of weak_ptr wrapping Objective-C ids, weak_ptr is not really designed for ids and such usages are blocking the arc migration. 

This PR mostly copies the weak_nsobject from chromium, at the same hash that we copied the ARC/MRC compatible scoped_nsobject: fd625125b8

To match how we used weak_ptr for those ids, I made some changes to the weak_nsobject:
- WeakNSObjects needs to be generated by a WeakNSObjectFactory. The WeakNSObjectFactory is owned by the objc class and acts as the generator of the WeakNSObjects. All the WeakNSObjects' derefing thread should be the same of the WeakNSObjectFactory's creation thread.
- chromuim's WeakNSObjects can be detached from the thread and re-attached to a new thread. To match our weak_ptr behavior, I changed WeakNSObjects to be only accessed from a single thread, the same as weak_ptr

This PR also moves the FlutterEngine to use WeakNSObject and updated related classes.

part of https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 23:43:24 +00:00
skia-flutter-autoroll
81e50af073 Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) (flutter/engine#48094) 
https://skia.googlesource.com/skia.git/+log/e954d1a1972c..5d6bdbf69dea

2023-11-15 hitawala@chromium.org Graphite: Relax wgpu::TextureAspect validation
2023-11-15 bungeman@google.com Make SkFontMetrics::operator== const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 23:33:08 +00:00
Jonah Williams
9af166c5ce [Impeller] add async command submission for blit pass. (flutter/engine#48040) 
This is a requirement for the "Remove Drawable Acquisition Latency" Change, but is otherwise a harmless improvement.

---

Submitting a command buffer causes the backend specific encoding logic to run. Metal is unique in that it is fairly easy to move this work into a background thread, allowing the engine to move onto creating the next command buffer. This improves throughput of the engine, at the cost of needing two slightly different APIs. Currently the GLES and Vulkan versions of this method still submit synchronously - for now that is out of scope as doing background work with those APIs has proved more challenging.

See also:
   * https://github.com/flutter/engine/pull/42028
   * https://github.com/flutter/flutter/issues/131698
   
Separately, as a requirement for the design in "Remove Drawable Acquisition Latency", we need to be able to defer drawable acquisition to this background thread. While this almost already works for render passes, it does not work for blit passes today. if the engine renders a backdrop filter, then the final command buffer submitted will be a blit pass that copies an offscreen onto the drawable. Therefore we need to add an async version of the blit submission, so that we have a hook to move the drawable acquisition onto a background thread for metal.

This hadn't been done until now because most blit cmd buffers have 1 or 2 cmds on them so the benefit of moving to a background thread is minimal.

Part of https://github.com/flutter/flutter/issues/138490
 2023-11-15 23:22:22 +00:00
Matan Lurey
9ce1ec8867 Make lib/ui/compositing/... compatible with .clang_tidy. (flutter/engine#48001) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-15 23:09:05 +00:00
godofredoc
97b5d699e6 Remove the linux fuchsia v1 build. (flutter/engine#48085) 
The fuchsia v2 build is working correctly and we are ready to remove the v1 version.

Bug: https://github.com/flutter/flutter/issues/132600

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 23:02:37 +00:00
Mouad Debbar
9b5f97c730 [web] Apply global styles before inserting the DOM element (flutter/engine#48027) 
The current way we are doing global styles (using `CSSStyleSheet`) forces us to insert the DOM element into the document before we attach any styles to the element. That restriction goes away if we append the styles as `TextNode`s into the `<style>` element.

Now with the movement towards `DomManager`, I would like to be able to create the entire DOM tree of the Flutter View (including all styles) before we insert it into the document.

Part of https://github.com/flutter/flutter/issues/134443
 2023-11-15 23:02:35 +00:00
skia-flutter-autoroll
701b799055 Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) (flutter/engine#48092) 
https://skia.googlesource.com/skia.git/+log/b23074a79bda..e954d1a1972c

2023-11-15 michaelludwig@google.com Set fill style and remove path effects on saveLayer restore paint
2023-11-15 johnstiles@google.com Fix minor errors in gn_to_bp.
2023-11-15 bungeman@google.com Check for empty glyphs in last resort fallback
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 1f5289c9db82 to ba1e7f5c1e82
2023-11-15 johnstiles@google.com Fix typo in YUV cubic filter.
2023-11-15 johnstiles@google.com Add Haswell and Skylake support to skcms gn/bazel build files.
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4aadd727887d to 13dd63c18adf (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 22:49:20 +00:00
auto-submit[bot]
ff90f25a41 Reverts "Make lib/ui/{text|window}/... compatible with .clang_tidy." (flutter/engine#48083) 
Reverts flutter/engine#48000
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
I just ... deleted `text_box.h` as it appears unused and unreferenced?

---

Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-15 19:55:17 +00:00
hellohuanlin
058ffbe73f [ios]fix ios 16 auto correction highlight showing on top left corner (flutter/engine#47279) 
This PR hides the system highlights in iOS 16 (except when scribble is enabled). 

Note that auto correction highlight is still drawn by flutter, so it still works. 

I don't think we need to CP this, since it's iOS 16 only, and iOS 17 is already out. 

## Why not use system highlight? 

Unlike iOS 17, the iOS 16 system highlight only respect the width provided by `firstRectForRange`, but not the height. I have audited all sizing related APIs in UITextInput (doc [here](https://developer.apple.com/documentation/uikit/uitextinput#1653155)), specifically, `firstRect(for:)`, `caretRect(for:)` and `selectionRects(for:)`, and they all return the correct height. 

## About scribble
The initial implementation of `firstRectForRange` (that returns the first selection rect) was introduced for the scribble feature on iPad (code [here](1d3165a31c (diff-4c7b102c0690b8ec5e2212b079f5d69fe3f816c84e47ce94bc7bc89312f39e40R1487-R1505))). 

It turns out that a non-zero rect is required for scribble's advanced feature to work (e.g. inserting a space with a vertical bar). So we can't apply this fix for scribble. 

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/136802

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 19:37:22 +00:00
skia-flutter-autoroll
10c992d881 Roll Skia from c42226314a4f to b23074a79bda (3 revisions) (flutter/engine#48081) 
https://skia.googlesource.com/skia.git/+log/c42226314a4f..b23074a79bda

2023-11-15 johnstiles@google.com Remove switch from bitmap_text_coverage_fn.
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d3983fb3caec to 14160bee80f4
2023-11-15 robertphillips@google.com Avoid memoryless attachments w/ protected rendering

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 19:25:58 +00:00
Matan Lurey
2c058e08ff Make lib/ui/{text|window}/... compatible with .clang_tidy. (flutter/engine#48000) 
I just ... deleted `text_box.h` as it appears unused and unreferenced?

---

Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-15 11:21:55 -08:00
Jonah Williams
9978ca06a8 [Impeller] some clang tidies in impeller (flutter/engine#48077) 
Usage of Scalar/Vector/Half types is desgned around implicit conversions today: we don't specifically convert to the correct generated header types, since that will depend on the target platform. Instead we rely on implicit conversions to handle this - any mistake there would still lead to a compilation error.
 2023-11-15 18:26:53 +00:00
skia-flutter-autoroll
65050f8ffc Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) (flutter/engine#48075) 
https://skia.googlesource.com/skia.git/+log/1f23a0b74619..c42226314a4f

2023-11-15 robertphillips@google.com [graphite] Add ManagedGraphiteTexture::ReleaseProc
2023-11-15 robertphillips@google.com [graphite] Attach internal protected elements together

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 17:35:08 +00:00
Greg Spencer
28d807f326 Update keycode output (flutter/engine#47988) 
## Description

This updates the keycode definitions to match what the keycode generator produces, to keep them in sync.
 2023-11-15 17:29:34 +00:00
Jason Simmons
a9c9177d35 In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051) 
This test is run on Firebase Test Lab, and crashes have been reported on CI if this task executes when the activity is in a destroyed state.

See https://github.com/flutter/flutter/issues/138451
 2023-11-15 17:10:49 +00:00
skia-flutter-autoroll
3ada26f096 Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) (flutter/engine#48071) 
https://skia.googlesource.com/skia.git/+log/1abce6b0a763..3b7a62e2ac3f

2023-11-15 kjlubick@google.com Revert^3 "Reland: [bazel] Housekeeper-PerCommit-CheckGeneratedFiles: Add "go generate", Gazelle and Buildifier steps."
2023-11-15 kjlubick@google.com Export DirectWrite typeface via SK_SPI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 16:03:55 +00:00
Zachary Anderson
2ce96843c0 Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070) 
Reverts Dart for analysis_server crash in customer_testing:
https://github.com/flutter/flutter/issues/138485
 2023-11-15 07:42:22 -08:00
Mouad Debbar
4bb1a74025 [web] Move EmbeddingStrategy and DimensionsProvider out of FlutterViewEmbedder (flutter/engine#48025) 
Part of https://github.com/flutter/flutter/issues/134443
Part of https://github.com/flutter/flutter/issues/117098
 2023-11-15 15:37:06 +00:00
skia-flutter-autoroll
49b4c626b9 Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065) 
https://dart.googlesource.com/sdk.git/+log/849fd6ccc339..002e66832465

2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-137.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 13:41:34 +00:00
skia-flutter-autoroll
999227e8cf Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060) 
https://dart.googlesource.com/sdk.git/+log/65819963fb17..849fd6ccc339

2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-136.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 09:43:40 +00:00
Chris Bracken
ce85176a4e [macOS] Clean up allocations in key responder tests (flutter/engine#48048) 
Runs all FlutterChannelKeyResponderTest tests in an AutoReleasepoolTest, which ensures all allocations are cleaned up.

Also replaces the use of OCMock in FlutterChannelKeyResponderTest with a fake FlutterBasicMessageChannel subclass. This avoids unnecessary use of OCMock in the tests, which has been responsible for flakiness in some tests, in particular where the mock is used across threads. This test was not problematic, but the fake makes the tests more readable.

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 02:19:12 +00:00
David Iglesias
ffcda33b48 [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939) 
This change:

* Adds a boolean to `multiViewEnabled`.
* Removes unused `canvasKitMaximumSurfaces` value.

Part of: https://github.com/flutter/flutter/issues/137377

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 02:01:17 +00:00
Jonah Williams
ac51782b20 [Impeller] Simplify convex tessellation (flutter/engine#47957) 
Removes usage of index buffer and adds zig-zagging triangle strip. Could also be adapted emplace directly into host 
buffer.

Benchmark is https://flutter-engine-perf.skia.org/e/?queries=test%3DBM_Convex_rrect_convex

Umbrella issue: https://github.com/flutter/flutter/issues/138004
 2023-11-15 01:43:33 +00:00
Jackson Gardner
5ea8187703 Use flutter.js in the actual test harness. (flutter/engine#47670) 
Run the JS unit tests with flutter.js.

I am going to leave the dart2wasm tests doing the old `window.flutterConfiguration` setup for now, until I actually get dart2wasm/dart2js switching logic built into flutter.js itself.
 2023-11-15 00:50:27 +00:00
skia-flutter-autoroll
42501a6f44 Roll Skia from 0f6a4e6a3b51 to 0d9175bb5cfa (1 revision) (flutter/engine#48045) 
https://skia.googlesource.com/skia.git/+log/0f6a4e6a3b51..0d9175bb5cfa

2023-11-14 kjlubick@google.com Remove dependency from TestFontCollection to default SkFontMgr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-15 00:24:05 +00:00
godofredoc
bca0164dbe Migrate fuchsia to engine v2 builds. (flutter/engine#48042) 
Bug: https://github.com/flutter/flutter/issues/135189
Bug: https://github.com/flutter/flutter/issues/132600
Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-15 00:06:54 +00:00
skia-flutter-autoroll
ab301ace16 Roll Dart SDK from 6219f11bf0fb to 6f1322227bdf (6 revisions) (flutter/engine#48039) 
https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..6f1322227bdf

2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-133.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-132.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-131.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-130.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-129.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 22:54:29 +00:00
skia-flutter-autoroll
6627c40f29 Roll Skia from 6feae2c274ce to 650913eacd01 (1 revision) (flutter/engine#48034) 
https://skia.googlesource.com/skia.git/+log/6feae2c274ce..650913eacd01

2023-11-14 johnstiles@google.com Add shader text and errors to the failure message.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 20:38:22 +00:00
Chris Bracken
50979ef389 [macOS] Eliminate unused OCMock includes (flutter/engine#48031) 
As part of the broader quest to reduce our dependence on OCMock in macOS
embedder tests, this removes #includes of OCMock into files where OCMock
is not actually used.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-14 12:12:53 -08:00
hellohuanlin
28fc24fd05 [ios17][text_input]fix ios 17.0 keyboard freeze when switching languages (without relying on text affinity) (flutter/engine#47566) 
After close examination of the UIKit's default string tokenizer, when querying the line enclosing the end of doc position **in forward direction**, we should return nil (regardless whether the position is forward or backward affinity). 

This aligns with the [API doc](https://developer.apple.com/documentation/uikit/uitextinputtokenizer/1614464-rangeenclosingposition?language=objc): 

> If the text position is at a text-unit boundary, it is considered enclosed only if the next position in the given direction is entirely enclosed.

Will cherry pick this soon. Otherwise it will be less and less important as users upgrade to iOS 17.1. 

### Why my previous workaround also works? 

It turns out my previous workaround PR https://github.com/flutter/engine/pull/46591 works only because our misuse of text affinity in our text input. Specifically, when adding text affinity support, we only added it to `FlutterTextPosition`, but not `FlutterTextRange`. So when getting the beginning/end position from the range, we assign arbitrary affinities. 

*List which issues are fixed by this PR. You must list at least one issue.*

https://github.com/flutter/engine/pull/46591

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-14 19:58:06 +00:00
John McCutchan
4a2f6eacfa Revert "Add an AndroidManifest.xml flag to disable ImageReader backend Platform Views (#46430)" (flutter/engine#48024) 
This reverts commit af107ceba5. It is no
longer needed as we have resolved the flickering issue in the
ImageReader backend.
 2023-11-14 10:26:39 -08:00
skia-flutter-autoroll
3ca59e39a5 Roll Skia from a811132be321 to ce88be2adf67 (1 revision) (flutter/engine#48022) 
https://skia.googlesource.com/skia.git/+log/a811132be321..ce88be2adf67

2023-11-14 johnstiles@google.com Remove skcms_Set|RestoreTarget.h.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 17:29:43 +00:00
Mouad Debbar
44cbbf526f [web] Explicit initialization of the implicit view (flutter/engine#47921) 
- An explicit API for initializing the implicit view (aka `window`).
- The explicit API is being called during the engine initialization for now, but we could simply remove that or make it conditional.
- Remove direct usages of `window` in tests:
    - Most of the usages were being delegated to `PlatformDispatcher` anyway (e.g. `sendPlatformMessage`).
    - This makes it **_clearer_** which tests depend on the implicit view (there are still hidden/indirect dependencies though).

Part of https://github.com/flutter/flutter/issues/134443
 2023-11-14 16:14:50 +00:00
skia-flutter-autoroll
3dfa827fe1 Roll Skia from f22c71596039 to b7d581997f2b (1 revision) (flutter/engine#48018) 
https://skia.googlesource.com/skia.git/+log/f22c71596039..b7d581997f2b

2023-11-14 kjlubick@google.com Partially revert fuzz SkFontMgr changes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 14:47:35 +00:00
skia-flutter-autoroll
02d89e50b3 Roll Fuchsia Linux SDK from UaodAPcg8HCGdDb-C... to AuDKY8ob6GrGwDlmk... (flutter/engine#48016) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 12:09:16 +00:00
auto-submit[bot]
7da37d5aef Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" (flutter/engine#48011) 
Reverts flutter/engine#48006
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..b3d3b381fd7b

2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 07:19:26 +00:00
Zachary Anderson
ef11fee4ed Move Skia to //flutter/third_party/skia (flutter/engine#47913) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

To land this PR, we'll need to:
1. Stop the Skia -> Engine autoroller
1. Update the license goldens in this PR.
1. Update
https://skia.googlesource.com/skia-autoroll-internal-config/+/refs/heads/main/skia-infra-public/skia-flutter.cfg#55
1. Land this PR.
1. Re-start the Skia -> Engine autoroller
 2023-11-13 20:04:35 -08:00
skia-flutter-autoroll
f7af706204 Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) (flutter/engine#48006) 
https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..b3d3b381fd7b

2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 04:00:27 +00:00
skia-flutter-autoroll
b7027c4fb2 Manual roll Dart SDK from 370145bbbd4f to 6219f11bf0fb (7 revisions) (flutter/engine#47998) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/370145bbbd4f..6219f11bf0fb

2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-127.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-126.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-125.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-124.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-123.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-122.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-121.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-14 00:50:06 +00:00
Matan Lurey
3ca8e17435 Make display_list/... compatible with .clang_tidy. (flutter/engine#47993) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-14 00:48:10 +00:00
auto-submit[bot]
a934a9bcd8 Reverts "Make fml/... compatible with .clang_tidy." (flutter/engine#48004) 
Reverts flutter/engine#47992
Initiated by: bdero
This change reverts the following previous change:
Original Description:
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-14 00:17:26 +00:00
Matan Lurey
e47c5864ef Make fml/... compatible with .clang_tidy. (flutter/engine#47992) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-13 22:52:51 +00:00
skia-flutter-autoroll
fecfc1ee01 Roll Skia from 9ac5cad143ec to c5aef650e2b2 (3 revisions) (flutter/engine#47991) 
https://skia.googlesource.com/skia.git/+log/9ac5cad143ec..c5aef650e2b2

2023-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from dc295723a2e4 to c5739298a461 (5 revisions)
2023-11-13 johnstiles@google.com Avoid recursion into the fields of a StructType.
2023-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 944c0002af1c to eff6fd68c449

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-13 22:45:17 +00:00