Commit Graph

3552 Commits

Author SHA1 Message Date
Yegor
5d94c8dece ios: remove geometric order; it will be supplied by framework (flutter/engine#4937) 2018-04-23 13:17:25 -07:00
Chinmay Garde
e25af6f85e Apply unaddressed comments in pull/5062 (flutter/engine#5065) 2018-04-23 12:16:15 -07:00
skia-flutter-autoroll
8c64df9150 Roll src/third_party/skia/ 3d0e8507f..5209d7fce (14 commits) (flutter/engine#5061)
https://skia.googlesource.com/skia.git/+log/3d0e8507face..5209d7fce35f

$ git log 3d0e8507f..5209d7fce --date=short --no-merges --format='%ad %ae %s'
2018-04-20 bsalomon Fix starting location in GrRTC::drawOval when converting to GrShape
2018-04-20 bsalomon Analytic dashing of circles with single on/off intervals and butt caps.
2018-04-20 brianosman Fix argument names and documentation for SkMatrix44::set3x3()
2018-04-18 enne Reland "Add stub gpu workaround generators"
2018-04-20 robertphillips Add ability to dump opList info at flush-time
2018-04-20 benjaminwagner Fix Housekeeper-PerCommit-InfraTests
2018-04-20 scroggo Reduce threads used for DNG decodes on Android
2018-04-19 benjaminwagner Add SwiftShader Build jobs.
2018-04-19 benjaminwagner Add cmake_linux asset.
2018-04-20 egdaniel Add discard check when deciding if we should execute op list or not.
2018-04-20 robertphillips Remove another writePixels instance
2018-04-18 csmartdalton ccpr: Don't solve for cubic roots that are out of range
2018-04-19 benjaminwagner Add SwiftShader to DEPS.
2018-04-19 csmartdalton ccpr: Fix flatness and triangle-ness detection for conics

Created with:
  roll-dep src/third_party/skia
2018-04-23 10:26:06 -04:00
Chinmay Garde
d31e721e6c Import intrusively ref counted shared pointers into FML. (flutter/engine#5062) 2018-04-21 20:50:03 -07:00
Todd Volkert
cf5661d4ae Support different encodings in Image.toByteData() (flutter/engine#5060)
Fixes https://github.com/flutter/flutter/issues/16635
2018-04-20 19:47:27 -07:00
Jason Simmons
4a5f9d7c9f Fix syntax error in AccessibilityBridge (flutter/engine#5059) 2018-04-20 13:54:27 -07:00
Jason Simmons
1fab880e72 Prevent multiple calls to FlutterMain.startInitialization (flutter/engine#5058)
See https://github.com/flutter/flutter/issues/16748
and https://github.com/flutter/flutter/issues/16456
2018-04-20 11:38:10 -07:00
Michael Goderbauer
3034fd831c Add SemanticsFlag.isHidden (flutter/engine#5052) 2018-04-20 10:37:02 -07:00
skia-flutter-autoroll
602a3a3727 Roll src/third_party/skia/ c4e384e5a..3d0e8507f (18 commits) (flutter/engine#5056)
https://skia.googlesource.com/skia.git/+log/c4e384e5ad85..3d0e8507face

$ git log c4e384e5a..3d0e8507f --date=short --no-merges --format='%ad %ae %s'
2018-04-20 robertphillips Prevent matrix stack from being corrupted if a rotated image filter is clipped out
2018-04-20 caryclark guard against NaN in path is rect
2018-04-19 fmalita Fix use-of-uninitialized-value in SkPictureShader::onMakeContext
2018-04-19 benjaminwagner Disable retries for Build, CT, and Calmbench tasks.
2018-04-20 angle-skia-autoroll Roll third_party/externals/angle2/ b0f917fa6..3ec304dba (1 commit)
2018-04-20 angle-skia-autoroll Roll third_party/externals/angle2/ e24032a2c..b0f917fa6 (3 commits)
2018-04-19 csmartdalton ccpr: Don't preempt the convex path renderer
2018-04-19 benjaminwagner Add more angle_gl_* configs for NVIDIA.
2018-04-19 jvanverth Remove ambient clamp hack for analytic shadows.
2018-04-19 brianosman Remove duplicate predefined configs
2018-04-18 csmartdalton ccpr: Clean up GrCCGeometry
2018-04-19 herb Adding pinning to the strike cache
2018-04-19 bsalomon Fix double counting of coverage in analytic round capped stroked circles.
2018-04-11 bungeman Document minimum OS requirements.
2018-04-19 angle-skia-autoroll Roll third_party/externals/angle2/ eeec3b14c..e24032a2c (2 commits)
2018-04-18 robertphillips rm SkRRectsGaussianEdgeMaskFilter
2018-04-19 borenet [skcms] Add version.sha1
2018-04-19 mtklein crash rather than overflow in SkTDArray

Created with:
  roll-dep src/third_party/skia
2018-04-20 13:16:21 -04:00
Chinmay Garde
1461d08b68 Prepare and run child isolates on a VM managed (i.e. no UI) task runner. (flutter/engine#5054) 2018-04-19 19:17:11 -07:00
Jason Simmons
a9d706ed38 Throw an error or return null if FlutterView.getBitmap fails (flutter/engine#5051)
getBitmap had been doing FXL_CHECK assertions to check memory allocation
failures and other errors.  getBitmap will now return null to the caller
instead.
(The VM may throw OutOfMemoryError or other exceptions if JNI APIs fail)

Fixes https://github.com/flutter/flutter/issues/16750
2018-04-19 16:12:22 -07:00
Jason Simmons
e2c22f864f Use the raster cache when rendering screenshots as bitmaps (flutter/engine#5050)
This matches the behavior from before the shell refactoring.

Fixes https://github.com/flutter/flutter/issues/16754
2018-04-19 13:32:00 -07:00
Chinmay Garde
4aa708019e Look for an assets path specification in the Info.plist. (flutter/engine#5049) 2018-04-19 12:01:46 -07:00
Jonah Williams
656482af41 AccessibilityBridge support for edge triggered semantics (iOS + Android) (flutter/engine#4901)
AccessibilityBridge support for edge triggered semantics (iOS + Android)
2018-04-19 11:14:47 -07:00
Chinmay Garde
08ba5c14e6 Fix more Linux unittest targets. (flutter/engine#5045) 2018-04-18 18:15:50 -07:00
Jason Simmons
5013086e9e libtxt: add boxes representing empty lines in GetRectsForRange (flutter/engine#5043)
If the start/end range passed to GetRectsForRange includes lines of text
that did not render any glyphs, then GetRectsForRange should add a placeholder
for that line.  In particular, the framework expects this so that it can
position the cursor on an empty line when editing text.

Fixes https://github.com/flutter/flutter/issues/16418
2018-04-18 18:04:52 -07:00
Brian Osman
ebb33d946a Enable downscale of very large images when uploading on IO thread (flutter/engine#5011) 2018-04-18 18:00:00 -07:00
Chinmay Garde
326b317633 Allow runtime unit-test to perform dynamic symbol resolution for Dart snapshots. (flutter/engine#5044) 2018-04-18 17:55:39 -07:00
Chinmay Garde
693b7f248e Don’t build the host shell on target builds. (flutter/engine#5042) 2018-04-18 16:28:24 -07:00
Jason Simmons
6856d1b63d Remove the weak pointer factory from the service isolate's DartIsolate object (flutter/engine#5041)
The WeakPtrFactory must be deleted on the thread where it was created.
However, the service isolate is created and destroyed on threads from
the Dart thread pool, and the creating thread may not be the same as
the destroying thread.
2018-04-18 13:02:19 -07:00
Chinmay Garde
8b6922845b Update the embedder GN target to use a source set instead of a complete static library. (flutter/engine#5040)
Creating a dylib from a “complete” static library does not propagate symbol visisbility definitions. I also got rid of the static library and used a source set instead because we don’t need to do the extra work for other targets.
2018-04-18 12:50:22 -07:00
Chinmay Garde
aa8636c3fc Implement Scene::toImage for creating a raster image representation of a scene. (flutter/engine#5021) 2018-04-18 12:42:16 -07:00
Jason Simmons
2e50155f95 Configure kernel paths in the embedder if the asset directory contains the kernel assets (flutter/engine#5039)
"flutter build bundle" in Dart 2 mode now builds an assets directory
containing the application and platform kernels along with the app's other
assets.

With this patch, embedders can run these bundles by setting
FlutterProjectArgs.assets_path to the bundle directory.  In this scenario,
FlutterProjectArgs.main_path and packages_path will be ignored.
2018-04-18 12:12:39 -07:00
Chinmay Garde
3028fb7777 Simplify weak pointer factories and allow vending weak pointers on multiple threads. (flutter/engine#5029) 2018-04-18 11:07:16 -07:00
Siva
80a6a46fb4 Roll Dart to version fe606f890b0a311da802c78b0af414a3c2087a79 (flutter/engine#5033)
fe606f890b Revert [vm/compiler] Canonicalize more intermediate constants in IL.
54531ad4e7 Bring in the latest pub_semver
61b15fede8 [build] Remove unnecessary inputs from uses of application_snapshot.
9968728df1 Remove package:cli_util deps from package:analyzer.
0ca8b6e5be Improve recovery when "assert" is used in an expression
6de5da1f58 fix #32649, add an option to disable asserts in DDC/K
afbaf0c4a6 Add 'Extract Widget' to getAvailableRefactorings().
d4a1896cfb Demote IMPORT_DUPLICATED_LIBRARY_NAMED to a warning
f85480b4dd Add tests for CFE implementation of expression compilation.
a865531f57 Remove two unused classes from the public API
3b7199fe63 [standalone] Only allow one outstanding load when running with --deterministic.
35fecb4a10 Issue 32896. Add isXYZ accessors to ParameterElementForLink_VariableSetter.
8df94f34fd Improve fasta parser await-for statement recovery
dd897d35a2 Move the task API out of the public API
c32e0e4bf3 [vm] Clear trailing bytes of objects that end up in snapshot images.
3a5fcf5a87 Upgrade the dep on package:isolate.
973a1a0219 Remove uses of upper-case constants in remaining SDK code.
b3595d59b3 [VM] Revert small change in FlowGraphCompiler::EmitTestAndCallCheckCid
0cbd4b520a Address review comments from change 51120
5dd283e783 fix #32270, DDC tests can now work with preview-dart-2
ce2b0db370 Improve fasta parser "assert" recovery
f8f5365a94 [vm/compiler] Fix sorting of instructions stats.
30655dcea0 [vm/aot] Treat Endian.host as a compile time constant.
eeaea82b75 Update status on test that often times out
805c08d8bf Fix a run-time type issue when running in Dart 2 mode
b1bc4ed2b5 Handle as in nested const constructors
823dfda5a5 Delete serialization, except for equivalence and helpers used in other tests.
7383cd46e0 Fix for issue 32872
86ba29265a Clean up the use of deprecated API in the analyzer_plugin package
fbb60b786f Add generic bounds test to function_type_variable_test
fd5f998796 [vm] Delta-encode offsets into ROData.
6fe7a86e7f Replace SourceFactory.resolveUri() with resolveRelativeUri() in resynthesizer.
2fb94418cd Mark mirrors test crashing.
c2b338f1b7 Remove fuzzy arrow support from analyzer
9976cddcd7 Shared cache of FileState contents.
b52931ff30 Revert "[vm/kernel] Fix non-canoncialized type arguments in partial instantiation."
c214c43758 Make LineInfo a public class
bd12c869ae [vm/kernel] Fix non-canoncialized type arguments in partial instantiation.
51a2f96a71 Always call writeAnnotationList to write annotations.
974a8ee21d Fix crash in named function expression
988de9c925 Thread forest object through calls
51f9d243e7 [VM] Mark type as finalized before calling the Canonicalize() method
a8578eaf69 Clean up some imports in Fasta type inference
e9616da13e Cleanup TypeInfo
3b414a277c Reland "[VM] Introduction of type testing stubs - Part 1-4"
c5f69dff2d Include `call` on Closure in inference
826928e2ab Use _trust to test inference of --omit-implicit-checks
6802746ad7 Fixed a couple of typos in subtyping.md
782cfe04d1 fix #32756, DDC dynamic calls to generics will work with emit-metadata
8613938e33 fix DDK to track mock setters correctly.
92f1d0fab4 [gn] Allow single or double quotes in .config
e2ee654cd1 Make a method in MempryResourceProvider private
b0fafbd1f4 Clean up js_runtime parse/tryParse methods
5e1cb4d41b Make SourceRange part of analyzers public API
1ab4cee181 Add a benchmark for running flutter analyze --flutter-repo against flutter head.
ff24a5ee6b fasta: make strong-mode inference aware of the type of LoadLibrary and CheckLibraryIsLoaded
6d7df88fa3 Delay computing file name sets until they are requested.
b7cc1e7ce7 Fix stack overflow in RTI computation
6db4ea4ca5 [vm] Use unsigned varints when possible in the clustered snapshot.
2018-04-18 11:07:56 +02:00
Chinmay Garde
7b5e21ff33 Clear the canvas when attempting to render to the surface. (flutter/engine#5036) 2018-04-17 19:04:52 -07:00
Chinmay Garde
e01a739b45 Make the rasterizer own the compositor context. (flutter/engine#5034)
This allows the texture registry to be accessed before render surface acquisition.
2018-04-17 18:45:58 -07:00
xster
77b1a14fde Correct ninja command instruction (flutter/engine#5032)
giving -C twice silently only builds one directory
2018-04-17 18:32:50 -07:00
Chinmay Garde
e45e1c17b2 Don't send platform messages to isolates that are not running. (flutter/engine#5031)
Isolates may be launched and awaiting snapshot association. We don't
want to send such isolates any messages before their "main" method is
called. In such cases, the engine may intercept and store certain
launch specific information.
2018-04-17 17:10:17 -07:00
Chinmay Garde
94586c2dac Set the start timestamp in the contructor of the first shell. (flutter/engine#5030) 2018-04-17 16:02:06 -07:00
Chinmay Garde
ae8bdd8dfc In the service protocol, if no view is specified to flush tasks on, pick the first one. (flutter/engine#5028) 2018-04-17 12:07:00 -07:00
Michael Goderbauer
c59300b2e3 Enable 'Speak Screen' and 'Switch Control' for iOS (flutter/engine#5016) 2018-04-17 09:16:24 -07:00
Mikkel Nygaard Ravn
c4aaa21eb3 Fix Android platform channels (flutter/engine#5025) 2018-04-17 16:02:10 +02:00
Chinmay Garde
eee5b18b17 On windows, refer to Dart snapshot directly executable. (flutter/engine#5024) 2018-04-16 22:02:19 -07:00
Todd Volkert
dd9b7675de Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (flutter/engine#5023)
This reverts commit 2983a1b613.
2018-04-16 21:50:11 -07:00
Chinmay Garde
61d20bfe48 Only make ERROR and FATAL log levels visible by default. (flutter/engine#5022)
Adds the --verbose-logging flag to enable logging at all other severities.
2018-04-16 21:34:11 -07:00
Alexander Aprelev
834a85578d Fix shell launcher test (dart2 compliant and stop polling) (flutter/engine#5009)
* Make test Dart2 compliant

* Use service and debug events instead of polling to wait for isolate to start, run and resume.

* Refactor into _onServiceEvent. Wait for 'paused' event instead of 'isolate runnable'.
2018-04-16 19:31:43 -07:00
Régis Crelier
2983a1b613 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (flutter/engine#5020) 2018-04-16 17:25:39 -07:00
Chinmay Garde
5b93e1f204 On iOS, try to use ES3, then fall back to ES2. (flutter/engine#5006) 2018-04-16 16:41:45 -07:00
Todd Volkert
7a94e0c73f Fix broken Linux build (flutter/engine#5019)
After we write the pixels in the correct format,
the color type of the SkPixmap is still set to
its previous value, so the existing assertion was
failing.
2018-04-16 16:20:48 -07:00
Todd Volkert
8d430519b0 Fix broken Chromebot build (flutter/engine#5018) 2018-04-16 15:10:40 -07:00
Ian Hickson
e61f21b5be Breadcrumbs to the wiki (flutter/engine#5017)
* Breadcrumbs to the wiki

* Update README.md
2018-04-16 13:26:42 -07:00
Todd Volkert
f10bdfbf77 Return raw (unencoded) bytes in Image.toByteData() (flutter/engine#5008)
Building image encoding into the engine bloated the
binary size. This change will return raw bytes, and
callers who use this functionality can take on the
dependency on image encoding in their apps (via a
Dart package or a platform plugin).

Fixes https://github.com/flutter/flutter/issues/16537
2018-04-16 12:39:46 -07:00
egdaniel
ad967fceb2 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (flutter/engine#5012)
The old code called getBackendRenderTargetHandle() with a Read access to trigger the surface to flush, however the returned GrVkImageInfo was never used. This how process is equivalent to just calling flush on the surface so do that instead.
2018-04-16 10:21:53 -04:00
Ravi Mistry
d0165f0163 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (flutter/engine#5007)
https://skia.googlesource.com/skia.git/+log/3462eb0346de..e669bdfad6d5

$ git log 3462eb034..e669bdfad --date=short --no-merges --format='%ad %ae %s'
2018-04-14 angle-skia-autoroll Roll third_party/externals/angle2/ 983c429fa..152152618 (7 commits)
2018-04-13 ethannicholas fix sksl standalone build error
2018-04-13 borenet Blacklist check_small_sigma_offset on Chromecast
2018-04-13 reed remove unused virtual onNotifyPixelsChanged
2018-04-13 reed rewrite iterator to make msvc happy
2018-04-13 brianosman Support downscaling to max texture size when making cross-context images
2018-04-13 borenet Add a MSVS bot to the CQ
2018-04-13 liyuqian Clone the xpos array in drawPosText
2018-04-13 ethannicholas added sk_LastFragColor
2018-04-13 reed Revert "add test for degenerate canvas dimension"
2018-04-13 reed add test for degenerate canvas dimension
2018-04-13 robertphillips Don't try to readback from the GPU for small blur sigmas
2017-12-20 herb Make a GM for checking blur bounds.
2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ cc1293775..983c429fa (1 commit)
2018-04-13 fmalita [skottie] Harden json string parsing
2018-04-13 caryclark path is rect bug number nine
2018-04-13 hcm Update Skia milestone to 68
2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit)
2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2
2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits)
2018-04-12 reed can't abort looper loop, as saveCount won't be balanced
2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size
2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot
2018-04-12 caryclark son of path is rect bug
2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler
2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface.
2018-04-12 reed check for non-finite values output by clipper
2018-04-12 brianosman Fail fast when trying to make a texture that's too large
2018-04-12 djsollen Include shadow ops in the debugger.
2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath"
2018-04-12 reed add conservative bounds to raster tiling
2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices
2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot
2018-04-12 caryclark another rect is path fix
2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS
2018-04-11 csmartdalton Implement Sk2f Load2
2018-04-11 csmartdalton ccpr: Blacklist ANGLE again
2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode
2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows
2018-04-11 csmartdalton Implement Sk4f min/max
2018-04-11 liyuqian Remove obsolete comment
2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS.
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits)
2018-04-11 caryclark fix bm gm
2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together
2018-04-11 fmalita Reland "Fix handling of MaskFilter matrices"
2018-04-11 angle-skia-autoroll Roll third_party/externals/angle2/ 785b20b7a..2dadd1d08 (11 commits)
2018-04-11 benjaminwagner Upgrade Windows Skolo bots.
2018-04-11 reed remove unused/dumb methods from SkRect
2018-04-11 reed Clean-up paints for drawImage (etc.) to enforce that we always ignore stroking and patheffects.
2018-04-11 caryclark more path is rect bugs
2018-04-11 mtklein skcms→9334796 reject non-XYZ/Lab PCS profiles
2018-04-11 liyuqian Revert "Add private fIsBadForDAA bit to SkPath"

Created with:
  roll-dep src/third_party/skia
2018-04-15 12:54:29 -04:00
Jonah Williams
605fa93f5e Re-land "do not pause rendering when android view loses focus" (flutter/engine#5004)
* do not pause rendering when android view loses focus
2018-04-13 17:08:00 -07:00
Chinmay Garde
77b5965ab9 If the rasterizer has a valid surface context, use that to create a snapshotting render target. (flutter/engine#4979) 2018-04-13 16:58:27 -07:00
Chinmay Garde
bfed2f04a0 Specify the packages file path when running engine dart tests. (flutter/engine#5005) 2018-04-13 16:17:38 -07:00
Chris Bracken
5ee33d78cf Minor update to README (flutter/engine#5003)
* Adds a docs directory with an architecture diagram from @chinmaygarde.
* Excludes the flutter/docs directory from license script.
2018-04-13 15:46:54 -07:00
Anatoly Pulyaevskiy
cce93d025e Promote line height in text style created from paragraph style (flutter/engine#4995) 2018-04-13 15:26:52 -07:00