Commit Graph

20034 Commits

Author SHA1 Message Date
Flutter GitHub Bot
4591f057fb roll packages (#117357) 2022-12-20 22:04:23 +00:00
Michael Goderbauer
0220afdd3e enable use_enums (#117376) 2022-12-20 20:06:24 +00:00
Camille Simon
e0742ebb24 [Android] Add spell check suggestions toolbar (#114460)
* Add spell check suggestions toolbar

* Fix test and move menu

* Cleanup

* Cleanup and fix bug

* More cleanup

* Make height dynamic and use localized delete

* Begin adding tests

* Create var checking for results

* Add tests

* Fix analyze (sorta)

* Add back hideToolbar call for testing

* Add back hidetoolbar in ts and delete one in et

* Remove unecessary calls to hidToolbar

* Fix analyze and docs

* Test fix

* Fix container issue

* Clean up

* Fix analyze

* Move delegate

* Fix typos

* Start addressing review

* Continue addressing review

* Add assert

* Some refactoring

* Add test for button behavior

* Undo test change

* Make spell check results public

* Rearrange test

* Add comment

* Address review

* Finish addressing review

* remove unused imports

* Address nits

* Address review

* Fix formatting

* Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints

* Fix analyze:
2022-12-20 19:56:12 +00:00
Michael Goderbauer
fa3777bd3e Enable sized_box_shrink_expand lint (#117371)
* Enable  lint

* note about discarded_futures

* note about use_decorated_box

* update note on require_trailing_commas
2022-12-20 19:07:15 +00:00
Ondrej Simek
8289ea624e Move a comment where it belongs (#117385) 2022-12-20 17:07:31 +00:00
Zachary Anderson
c64dcbefa6 Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)
This reverts commit 61fb6ea2d5.
2022-12-20 09:04:05 -08:00
Siva
61fb6ea2d5 Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372) 2022-12-20 08:31:22 -08:00
harperl-lgtm
38e3930f39 Exposed tooltip longPress action when available (#117338)
* Exposed tooltip longPress action when available (Trigger mode is long press)
2022-12-20 10:03:31 -05:00
harperl-lgtm
7f7a8778d8 Implemented Scrim Focus for BottomSheet (#116743)
* Implemented Scrim Focus for BottomSheet so that assistive technology users can focus and tap on the scrim to close the BottomSheet, which they could not do before the change . The Scrim Focus's size changes to avoid overlapping the BottomSheet.
2022-12-20 10:02:22 -05:00
Flutter GitHub Bot
b30947bef9 roll packages (#117226) 2022-12-20 01:26:51 +00:00
Michael Goderbauer
1adc27503f Bump min SDK to 2.19.0-0 (#117345)
* Bump min SDK to 2.19.0-0

* fix
2022-12-20 00:46:14 +00:00
Jackson Gardner
9f2c5d8e21 Support flutter build web --wasm (#117075)
* Work in progress.

* Some fixes to the command line.

* Bootstrapping works.

* Change kickoff order to maximize concurrency.

* Fix analyzer errors and formatting issues.

* Fix doc comment.

* Added unit tests for some of the web targets.

* Format issue.

* Add an integration test that builds an app to wasm.

* Add a todo for depfiles.

* Formatting.

* Apparently the license header needs to say 2014.

* `file://` URIs confuse dart2wasm on Windows. Just use absolute paths.

* Update unit tests to match new path passing.

* Have a distinct build directory for wasm, and fixes for some upstream changes.
2022-12-19 20:09:02 +00:00
Taha Tesser
5fcb48d598 Fix NavigationRail highlight (#117320) 2022-12-19 10:45:30 -08:00
Taha Tesser
cb988c7b6e Add indicatorColor & indicatorShape to NavigationRail, NavigationDrawer and move these properties from destination to NavigationBar (#117049) 2022-12-19 10:39:27 -08:00
Danny Tuppeny
9f9010f5e8 [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (#116892)
Fixes https://github.com/Dart-Code/Dart-Code/issues/4293.
2022-12-19 11:33:26 -05:00
alanwutang11
c0dddacb81 Fix is canvas kit bool (#116944)
* isCanvasKit implement and test

* isCanvasKit implement and test

* ++

* forgot license

* make isCanvasKit a getter

* addressed comments

* forgot to change names of integration test files

* typo

* simplified tests

* comments
2022-12-17 23:33:32 -08:00
Lucas.Xu
b20a9e0a37 imporve gesture recognizer semantics test cases (#117257) 2022-12-17 21:00:46 +01:00
Michael Goderbauer
bf5fdb9f96 Reland "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117244)
* Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)"

This reverts commit 9102f2fe0b.

* remove window placeholder
2022-12-17 06:14:19 +00:00
Jackson Gardner
ebeb491895 Use the name of errors, not the diagnostic messages. (#117229)
* Use the name of errors, not the diagnostic messages.

* Trailing comma.
2022-12-16 22:19:55 +00:00
htoor3
98e9032ca3 [web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (#117217)
* Remove DoNothing actions for shift + left/right keyboard shorcuts on web and add tests

* Fix spacing

* Add select all left/right cases + tests
2022-12-16 22:12:41 +00:00
Greg Spencer
ecf9b2d20a Update localization of shortcut labels in menus (#116681)
* Fix Menu shortcut labels

* Remove invalid localizations

* Add more localization for Shift

* Add generated localizations

* Fix Test
2022-12-16 19:57:17 +00:00
LongCatIsLooong
3d0607b543 Defer systemFontsDidChange to the transientCallbacks phase (#117123)
* Always defer systemFontsDidChange to transientCallbacks phase

* unnecessary import
2022-12-16 19:27:03 +00:00
Casey Hillers
9102f2fe0b Revert "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117214)
This reverts commit a34e419484.
2022-12-16 17:48:23 +00:00
chunhtai
23a2fa31d2 Reland "Adds API in semanticsconfiguration to decide how to merge chi… (#116895)
* Reland "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)"

This reverts commit 7549925c8c.

* makes markNeedsSemanticsUpdate more robust

* address comment
2022-12-16 17:20:20 +00:00
Eilidh Southren
da7b8327e4 Bottom App Bar M3 background color fix (#117082)
* Bottom App Bar M3 background color fix

* update test

* test update

* remove whitespace
2022-12-16 09:03:40 +00:00
Lucas.Xu
80e1008cbc fix: #110342 unable to update rich text widget gesture recognizer (#116849) 2022-12-16 09:32:09 +01:00
LongCatIsLooong
76bb8ead5a Reland "Fix text field label animation duration and curve" (#114646)"
This reverts commit 9f6090c9ad.
2022-12-15 19:38:53 -08:00
Christopher Fujino
c7cb5f3f5b [flutter_tools] pin package intl and roll pub packages (#117168)
* pin package intl and roll pub packages

* add test

* fix analysis
2022-12-16 00:34:51 +00:00
Michael Goderbauer
a34e419484 Inject current FlutterView into tree and make available via View.of(context) (#116924)
* enable View.of

* tests

* ++

* greg review

* rewording

* hide view from public
2022-12-16 00:13:56 +00:00
fzyzcjy
86b62a3c21 Tiny fix about outdated message (#114391) 2022-12-15 16:06:44 -08:00
hellohuanlin
0916375f44 [tools]Build IPA validation UI Polish (#116744)
* [tools]some ui polish for build ipa validation

* do not print out a few success validations

* rename installed type to success for more general usage

* forgot nit after reverting custom validation types and re-use doctor types
2022-12-15 14:43:32 -08:00
hangyu
c98978ae36 Update Navigator updatePages() (#116945)
* Update navigator.dart

* Update navigator.dart

* Add test

* Update navigator.dart

* lint

* Update packages/flutter/test/widgets/navigator_test.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

* Update packages/flutter/test/widgets/navigator_test.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2022-12-15 14:30:21 -08:00
Christopher Fujino
1eaf5c0f08 [flutter_tools] tree shake icons from web builds (#115886)
* wip

* remove temp text file

* fix tests

* add test

* default to off

* restore gitignore

* update

* apply annotation to cupertino icons as well

* update reference to library in icon_tree_shaker.dart

* update tests

* fix tests

* remove hack to skip non-const check on web

* add hint about how much reduction and test
2022-12-15 22:13:17 +00:00
Jenn Magder
ada4460502 Audit covariant usage in tool (#116930) 2022-12-15 11:59:34 -08:00
stuartmorgan
f1d157bc29 Add an integration test to plugin template example (#117062)
* Add an integration test to plugin template example

Dart unit tests don't exercise host-side plugin code at all, so the
example tests in the plugin template currently have very little
meaningful coverage. This adds an integration test to the example app
when creating a plugin, so that there's an example of how to actually
test that a complete round-trip plugin call works.

This is done as a separate template that's currently only used by the
plugin template because I don't know what a good example for a
non-plugin case would be that isn't largely just a duplicate of the
widget tests. However, the integration test pre-includes conditionals
around the parts that are plugin-specific so that it can more easily be
expanded to other use cases later (e.g., in
https://github.com/flutter/flutter/issues/68818).

Part of https://github.com/flutter/flutter/issues/82458

* Add integration test to expected dependencies of a plugin app

* Test fixes

* Make an explicit test case
2022-12-15 19:49:14 +00:00
Martin Kustermann
fc3571eff4 Improve documentation of compute() function (#116878)
This improves the documentation of the `compute()` function as follows:

  * Instead of making `compute` a top-level constant, we make it a
    function. This allows the generated API docs to show a function
    signature with parameters and their names, making it *much* clearer
    to users what function is being documented.

  * We mention that on web-backends this is running `compute()` on the
    normal eventloop whereas on on native platforms it runs in a
    separate isolate.

  * We mention that callback, message and result have to be sendable
    across isolates. We also mention that they may be copied.

  * We link to both `Isolate.run` & `SendPort.send` for more information.

  * We use `M` for the type of `message` instead the rather confusing
    `Q`.
2022-12-15 19:25:07 +01:00
Justin McCandless
dcd2170d14 Fix typos in scale gesture recognizer docs (#117116)
Just two small typo fixes.
2022-12-15 09:13:36 -08:00
Jonah Williams
169b49fba7 Revert "[framework] make transform with filterQuality a rpb (#116792)" (#117095)
This reverts commit e331dcda17.
2022-12-15 17:11:42 +00:00
Michael Goderbauer
409a39daea remove debugPrint from timePicker test (#117111) 2022-12-15 17:07:52 +00:00
Michael Goderbauer
dbc9306380 Failure to construct ErrorWidget for build errors does not destroy tree (#117090) 2022-12-14 21:53:20 +00:00
Tomasz Gucio
7b19b4d387 Fix CupertinoTextSelectionToolbar showing unnecessary pagination (#104587) 2022-12-14 22:38:04 +01:00
Darren Austin
d8b7eb6e29 Updated token templates to sync with master code. (#117097) 2022-12-14 21:32:12 +00:00
Phil Quitslund
f9acb1e88c -- unnecessary parens (#117081) 2022-12-14 21:18:37 +00:00
Taha Tesser
57fb36ee0a [reland] Add Material 3 support for ListTile - Part 1 (#116963)
* [reland] Add Material 3 support for `ListTile` - Part 1

* Update doc
2022-12-14 21:13:59 +00:00
Alexander Markov
c63d797f94 Upgrade dependencies (#117007) 2022-12-14 13:13:05 -08:00
Taha Tesser
f07db4018a NavigationBar improvements (#116992) 2022-12-13 17:25:49 -08:00
Greg Spencer
fae458b925 Convert TimePicker to Material 3 (#116396)
* Make some minor changes in preparation for updating the Time Picker to M3

* Revert OutlineInputBorder.borderRadius type change

* Revert more OutlineInputBorder.borderRadius changes.

* Convert TimePicker to Material 3

* Add example test

* Revert OutlineInputBorder.borderRadius type change

* Fix test

* Review Changes

* Merge changes

* Some sizing and elevation fixes

* Fix localization tests
2022-12-14 00:09:52 +00:00
Daniel Iglesia
0c7d84aa78 Add AppBar.forceMaterialTransparency (#101248) (#116867)
* Add AppBar.forceMaterialTransparency (#101248)

Allows gestures to reach widgets beneath the AppBar (when Scaffold.extendBodyBehindAppBar is true).
2022-12-14 09:45:50 +11:00
Michael Thomsen
f5249bcb0a Remove use of NullThrownError (#116122) 2022-12-13 08:42:54 +01:00
LongCatIsLooong
04ee5926a2 Remove RenderEditable textPainter height hack (#113301)
* remove RenderEditable textPainter height hack

* Still applies the hack on web

* unskip web
2022-12-13 03:42:23 +00:00