Commit Graph

2349 Commits

Author SHA1 Message Date
Ian Hickson
f9374fe071 Update the URL to the recommend bug report (#23708)
We have templates now.
2018-11-07 17:12:35 -08:00
Michael Beckler
9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264)
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Jonah Williams
2fc2581be4 unpin mockito (#24021) 2018-11-06 17:24:39 -08:00
Jonah Williams
ab2d0323a7 cleanup accessibility test skips in gallery (#23977) 2018-11-06 13:29:23 -08:00
Jonah Williams
48c00dc7d7 fix build for real (#24016) 2018-11-06 12:32:35 -08:00
Jonah Williams
e862580518 move file back (#24014) 2018-11-06 11:09:57 -08:00
Jonah Williams
a43e3a4a2f Retry remove package:test from flutter (#24007) 2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39 Revert "Remove package:test dependency from flutter_test (#23755)" (#24004)
This reverts commit 71e9bd6f25.
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25 Remove package:test dependency from flutter_test (#23755) 2018-11-06 08:39:27 -08:00
Devon Carew
cb3dee79c5 add an analysis_options excludes for the build/ dir (#23653)
* add an analysis_options excludes for the build/ dir

* fix bots
2018-11-06 07:59:33 -08:00
Alexandre Ardhuin
344ebe02ff avoid returning null for Future (#23784) 2018-11-05 16:38:23 +01:00
Hans Muller
dd30efa190 Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c7.
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7 Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jonah Williams
0b35937b13 Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172.
2018-11-01 19:30:11 -07:00
Hans Muller
949cfcf172 Flutter gallery: updated Shrine demo (#23539) 2018-11-01 12:48:24 -07:00
Dan Field
fd6b2e198c Re-reland Xcode backend refactor (#23762)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files

* add FLUTTER_FRAMEWORK_DIR back, set swift version for profile, tell Podfile about profile
2018-10-31 16:37:53 -07:00
Dan Field
7217999a9a Revert "Reland Xcode backend refactor" (#23737)
* Revert "Update templates (#23698)"

This reverts commit 5b0de6d679.

* Revert "Verify that date/number translations exist for all supported languages (#23692)"

This reverts commit 3449edf256.

* Revert "Reland Xcode backend refactor (#23574)"

This reverts commit 7270f2845d.
2018-10-30 09:36:31 -07:00
Dan Field
7270f2845d Reland Xcode backend refactor (#23574)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files
2018-10-30 07:23:19 -07:00
Devon Carew
e30f9a9447 add explicit const keywords (#23652) 2018-10-29 22:39:40 -07:00
xster
17d068d724 Allow heroes to fly across navigators and restrict Cupertino nav bars to per navigator by default (#23322) 2018-10-26 12:12:13 -07:00
Kevin Moore
8039620bb4 Remove duplicate code comment in flutter_gallery (#23422) 2018-10-23 19:01:58 -07:00
xster
1f72406b74 Platform agnostic gallery smoke test (#23423) 2018-10-23 13:03:35 -07:00
xster
b63ced55b4 Add a CupertinoTextField (#23194) 2018-10-22 19:20:17 -07:00
Stanislav Baranov
323d1574c6 newly created apps / plugins should use latest gradle dependencies (#22790) (#23314) 2018-10-19 19:07:06 -07:00
Chris Bracken
8007e1bc2f Update coverage, linter to latest releases (#23304)
Coverage 0.12.3 includes a fix for dart-lang/coverage#194, which was
causing errors on the flutter build bots.

Linter was updated automatically as a side effect of running
`flutter update-packages --force-upgrade`.
2018-10-19 14:18:47 -07:00
Yegor
82d6589590 Revert "newly created apps / plugins should use latest gradle dependencies (#22790)" (#23263)
This reverts commit 751c083f7d.

Our buildbots need to be upgraded to a newer version of the Android SDK.
2018-10-18 14:17:47 -07:00
Sebastian Roth
751c083f7d newly created apps / plugins should use latest gradle dependencies (#22790) 2018-10-18 12:56:18 -07:00
Jason Simmons
086cfcb133 Add a delay to the Gallery navigation memory test to give Dart an opportunity to GC (#23250)
See https://github.com/flutter/flutter/issues/23171
2018-10-18 12:30:16 -07:00
Yegor
3fbd140e77 Use new mixin syntax for super-mixins (#22870)
This re-lands 3c56e6c on top of a new Dart SDK that contains new mixin syntax fixes.
2018-10-17 13:10:05 -07:00
Alexandre Ardhuin
8b0de38ef8 fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Alexandre Ardhuin
0fb84e96c7 Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
matthew-carroll
04a26778c5 Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c.
2018-10-12 16:31:34 -07:00
matthew-carroll
80f80ab08c Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e45.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae7.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
Jonah Williams
313059cdb6 Add labeled tappable target guideline and gallery tests (#22824) 2018-10-11 15:05:10 -07:00
Jason Simmons
dba54316f4 Android API version check for the call to Activity.reportFullyDrawn (#22918) 2018-10-11 08:57:33 -07:00
Sebastian Roth
9c01c2b836 Use new run arguments API in flutter_view / Android example. 2018-10-10 12:45:41 -07:00
Hans Muller
a590940e45 ButtonTheme.of().colorScheme defers to Theme (#22880)
ButtonThemeData no longer requires a colorScheme. If colorScheme is null, ButtonTheme.of() will initialize it from the current Theme.
2018-10-10 11:40:30 -07:00
Hans Muller
8bfb4b3ee5 Bring TextTheme into alignment with the current Material spec (#22330) 2018-10-09 17:00:15 -07:00
Jonah Williams
fb7a5937ba Basic scroll semantics support (#21764) 2018-10-09 14:16:28 -07:00
Hans Muller
655bf6a290 Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)
* Update uses of ButtonTheme.bar

* updated gallery themes

* Remove unnecessary const

Fixes #22789
2018-10-08 15:53:35 -07:00
xster
788bb2d4c2 Add first frame reporting to gallery's Play Store Console logging (#22579) 2018-10-08 11:51:37 -07:00
xster
9c080269a8 Add some missing voiceover labels in gallery (#22753) 2018-10-08 11:51:16 -07:00
Andrew Davies
9ceb9ab305 [flutter_driver] Adds fuchsia compat for connect() (#22633)
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device.  This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
2018-10-08 11:09:07 -07:00
Hans Muller
bbb080b3a3 Material Switch optionally adapts per platform: Switch.adaptive() (#22688) 2018-10-08 10:39:59 -07:00
Michael Thomsen
2c063b7ca5 Clean up the examples readme (#22419)
A few changes:

* Remove the search tip (it relies on searching for the new keyword which we no longer use)
* Remove mentioning of examples that are either stale or only used for internal purposes (such as test)
* Cross-link to the samples repo
2018-10-08 08:45:24 +02:00
Jonah Williams
cdf1cec902 add ability to match child semantics data (#22001) 2018-10-05 17:44:26 -07:00
Yegor
3184b7cb66 Revert "Use mixin syntax for Flutter's super-mixins (#22435)" (#22748)
This reverts commit 3c56e6c77d.

It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor
3c56e6c77d Use mixin syntax for Flutter's super-mixins (#22435)
* first pass

* revert WidgetsBindingObserver

* disable prefer_mixin

* docs and more mixins

* newer engine; binding fixes

* upgrade dependencies

* fix test binding

* remove whitespace

* remove the obsolete `enableSuperMixins: true`

* upgrade dartdoc to 0.22.0

* temporarily use git version of dartdoc

* fix pub global activate syntax

* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Jonah Williams
cfc73590b7 Adds more time to contrast tests (#22681) 2018-10-04 15:56:52 -07:00
Alexandre Ardhuin
2ea1d81cdc sort_constructors_first (#22575) 2018-10-04 07:28:07 +02:00