Commit Graph

1347 Commits

Author SHA1 Message Date
Greg Spencer
590cc27b31 Revert "Implement focus traversal for desktop platforms, shoehorn edition. (#30040)" (#31461)
This reverts commit 4218c0bc38.
2019-04-22 18:02:35 -07:00
Greg Spencer
4218c0bc38 Implement focus traversal for desktop platforms, shoehorn edition. (#30040)
Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.

This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.

It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:

FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.

Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.

Addresses #11344, #1608, #13264, and #1678
Fixes #30084
Fixes #26704
2019-04-22 09:51:40 -07:00
Ben Konyi
484f6e754a Fixed flutter_attach_test not respecting authentication codes (#31321) 2019-04-19 13:55:34 -07:00
Ben Konyi
1459b1e91f Fixed failing tests caused by introduction of authentication codes (#31315) 2019-04-19 11:45:53 -07:00
Ben Konyi
3764cb8515 Added support for authentication codes for the VM service. (#30857)
* Added support for authentication codes for the VM service.

Previously, a valid web socket connection would use the following URI:

`ws://127.0.0.1/ws`

Now, by default, the VM service requires a connection to be made with a
URI similar to the following:

`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`

where `Ug_U0QVsqFs` is an authentication code generated and shared by
the
service.

This behavior can be disabled with the `--disable-service-auth-codes`
flag.
2019-04-18 21:01:50 -07:00
Sam Rawlins
24158686df Bump dartdoc to 0.28.3+2 (#31148)
This version of dartdoc properly escapes fenced code block "info strings."
2019-04-16 15:02:18 -07:00
Greg Spencer
857fe320e0 Update keycodes, fix a comment. (#30938)
Updates the keycodes by regenerating them using the script, and fixed a comment in the template to conform to style.
2019-04-16 08:02:11 -07:00
liyuqian
b0937a1e89 Fix the warning test by checking stderr (#30997)
Previously, I used the Android emulator for testing and everything
seemed to work fine with stdout (if I remember correctly). But our
devicelab uses real Android devices and the warnings are routed to
stderr. Hence change stdout to stderr in the test.
2019-04-15 10:19:36 -07:00
Dan Field
99bd2795b0 Add rrect contains microbenchmark (#30985) 2019-04-15 09:01:40 -07:00
Jonah Williams
b4edfb1511 Revert "Manual engine roll with disabled service authentication codes (#30919)" (#30930)
This reverts commit 19d6e7b613.
2019-04-11 12:18:39 -07:00
Ben Konyi
19d6e7b613 Manual engine roll with disabled service authentication codes (#30919) 2019-04-11 12:08:13 -07:00
xster
054e8870eb Fix iTunes Transporter quirk (#30883) 2019-04-10 18:33:43 -07:00
Greg Spencer
7b39269fe8 Bump Android build tools to 28.0.3 in Dockerfile (#30832)
Bumps the Android build tools to 28.0.3 instead of 28.0.0 in the Dockerfile, since that is what flutter doctor wants.
2019-04-10 16:57:35 -07:00
xster
5a6c140d0d Cupertino localization step 7: modularize material specific things out of gen_localizations.dart (#29822) 2019-04-10 01:24:58 -07:00
liyuqian
eb30745faf Print warning if flutter drive is run in debug (#30747)
## Description

Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.

## Related Issues

https://github.com/flutter/flutter/issues/30625

## Tests

I added the following tests:
* drive_perf_debug_warning devicelab test
2019-04-09 18:55:42 -07:00
liyuqian
5f060ba1c2 Mark cubic_bezier_perf__timeline_summary nonflaky (#30767) 2019-04-09 10:01:19 -07:00
xster
d0f89c1190 Fix gallery deploy on iOS (#22810) 2019-04-05 18:55:33 -07:00
Michael Goderbauer
f7048b696d Bump dartdocs to 0.28.3+1 (#30570) 2019-04-05 14:01:27 -07:00
Tim Sneath
529189791c Replace flutter.io with flutter.dev (#30562) 2019-04-05 11:39:30 -07:00
xster
cdc6919350 Let docker image install fastlane too for Linux (#30530) 2019-04-04 18:11:14 -07:00
Michael Goderbauer
194babfb42 Bump dartdocs to 0.28.3 (#30451) 2019-04-03 11:56:41 -07:00
xster
72a4083467 Cupertino localization step 4: let generated date localization combine material and cupertino locales (#29650) 2019-04-02 18:31:56 -07:00
Alexandre Ardhuin
4bb6840091 no need .toList() before .join() (#30304) 2019-04-02 07:20:23 +02:00
LongCatIsLooong
712195b559 update sample code analyzer regexp & test case (#30201)
updates the regex the analyzer uses, so it should be able to recognize expressions such as
const Foo a = Foo(); as "other code" rather than a constructor call.
2019-04-01 17:27:29 -07:00
Jonah Williams
953a947130 add coverage benchmark (#30222) 2019-03-29 17:00:19 -07:00
xster
f2d671c15c Cupertino localization step 3: in-place move some material tools around to make room for cupertino (#29644) 2019-03-29 15:57:09 -07:00
Dan Field
d6ddf82fe4 roll engine to 82765aa77db9621dfbc50801ee2709aa0a00e04d (#30198) 2019-03-29 12:41:58 -07:00
Jonah Williams
1bfa2f2311 Intercept errors thrown by synchronous Completers in image resolution. (#30139) 2019-03-29 10:05:18 -07:00
Francisco Magdaleno
b70d260b3c Adds the keyboard mapping for Linux (#29993) 2019-03-28 10:04:23 -07:00
Jonah Williams
3c93b65a9b Update to latest matcher (#30019) 2019-03-27 17:21:10 -07:00
Jonah Williams
0a2175f133 Pass FLUTTER_TOOL_ARGS to snapshot command. (#29938) 2019-03-27 15:24:08 -07:00
Dan Field
820b0e029e Avoid overwriting task result for non-leak checkers (#29989) 2019-03-26 11:40:05 -07:00
Jonah Williams
44b22c7b04 Fix cache location, artifacts, and re-enable dart2js test (#29783) 2019-03-25 18:47:37 -07:00
Dan Field
ecfdd7e1ea Detect and cleanup leaky processes (#29196)
* Detect and cleanup leaky processes
* Add flaky tests for detecting leaked processes
2019-03-22 14:32:36 -07:00
Jonah Williams
469a859c72 Enable code generation features in tool (#29399) 2019-03-21 13:12:10 -07:00
Michael Goderbauer
f0c2be3c1e Fix links on homepage of API docs (#29641) 2019-03-20 14:42:46 -07:00
Dan Field
ee3e621f02 Remove timeout from add2app test for iOS (#28746) 2019-03-18 21:40:21 -07:00
Jonah Williams
55a2ee588d make build runner configurable (#29568) 2019-03-18 15:50:11 -07:00
Francisco Magdaleno
c163ed9618 Adds macOS raw keyboard mapping (#29231) 2019-03-18 11:12:04 -07:00
Jonah Williams
72605d2406 Switch flutter_tools from script to app-jit snapshot. (#27749) 2019-03-15 19:33:24 -07:00
Jonah Williams
cd803ac7f2 Improve hot reload performance (#28152) 2019-03-15 15:02:45 -07:00
xster
fa149eea9b Cupertino localization step 1: add an English arb file (#29200) 2019-03-15 12:10:35 -07:00
Dan Field
4906c7ea56 Update README.md (#29369) 2019-03-15 08:58:13 -07:00
Brian Wilkerson
439fbbe69e Update SDK constraints to reflect the fact that set literals are being used (#29389) 2019-03-15 07:53:27 -07:00
Jonah Williams
7bed378e22 Only run codegen at start of flutter_test (#29171) 2019-03-14 17:12:40 -07:00
Dan Field
97a8120969 guard new formatter behind env var (#29340)
* guard new formatter behind env var
2019-03-14 08:26:59 -07:00
Dan Field
dcc965a38e Revert "Speculative fix for #29262 (#29273)" (#29319)
This reverts commit 53d45258dc.
2019-03-13 12:58:10 -07:00
Dan Field
53d45258dc Speculative fix for #29262 (#29273)
* Avoid writing to stderr before process has finished streaming
2019-03-13 12:27:05 -07:00
Shi-Hao Hong
1ddd15ff49 Update README.md 2019-03-12 18:15:23 -07:00
Dan Field
b9f013c044 Make sure test reporter prints out stderr, and disables Bigquery for non-contributors (#29073)
* print stderr to stderr, no bq if not contributor

* let test continue of bigquery fails
2019-03-10 11:26:17 -07:00