Commit Graph

20193 Commits

Author SHA1 Message Date
Christopher Fujino
a04ab7129b Revert "Add API for discovering assets (#118410)" (#119273)
This reverts commit 2b8f2d0504.
2023-01-26 20:01:12 +00:00
Andrew Kolos
2b8f2d0504 Add API for discovering assets (#118410)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* revert image resolution changes

* Update image_resolution_test.dart

* Update decode_and_parse_asset_manifest.dart

* make targetDevicePixelRatio optional

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* fix immutable not being imported

* return List in AssetManifest methods, fix annotation import

* simplify onError callback

* make AssetManifest methods abstract instead of throwing UnimplementedError

* simplify AssetVariant.key docstring

* tweak _AssetManifestBin docstring

* make AssetManifest and AssetVariant doc strings more specific

* use List.of instead of List.from for type-safety

* adjust import

* change _AssetManifestBin comment from doc comment to normal comment

* revert to callback function for onError in loadStructuredBinaryData

* add more to the docstring of AssetManifest.listAssets and AssetVariant.key

* add tests for CachingAssetBundle caching behavior

* add simple test to ensure loadStructuredBinaryData correctly calls load

* Update asset_manifest.dart

* update docstring for AssetManifest.getAssetVariants

* rename getAssetVariants, have it include main asset

* rename isMainAsset field of AssetMetadata to main

* (slightly) shorten name of describeAssetAndVariants

* rename describeAssetVariants back to getAssetVariants

* add tests for TestAssetBundle

* nits

* fix typo in docstring

* remove no longer necessary non-null asserts

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-01-26 19:05:00 +00:00
Hasnen Tai
7d3b762dfc Fix: Added margin parameter for MaterialBanner class (#119005)
* Fix: Added Margin Parameter for Material Banner

* Fix: Comment for default value added and test improved

* Fix: Comment updated

* Fix: Comment added
2023-01-26 18:47:23 +00:00
godofredoc
c9affdba9d Move windows-x64-flutter.zip to windows-x64-debug location. (#119177)
The dependency is currently uploaded to two different locations. This
change is required to remove the duplicate uploads and their
corresponding tech debt.
2023-01-26 05:25:02 +00:00
Todd Volkert
b319938ecd Add more flexible image API (#118966)
This updates the framework to provide higher level wrappers around ui.instantiateImageCodecWithSize(). Functionally, this doesn't change anything (other than deprecating the older loadBuffer() method in favor of loadImage()), but it sets the stage for a simpler change that will allow us to provide a more flexible way to load sized images.

#118543
2023-01-25 21:21:28 -08:00
Michael Goderbauer
766e4d28a4 Remove single-view assumption from material library (#117486)
* Remove single-view assumption from material library

* one widget
2023-01-25 23:43:00 +00:00
Tae Hyung Kim
02a9c151f6 Fix lexer issue where select/plural/other/underscores cannot be in identifier names. (#119190) 2023-01-25 15:31:38 -08:00
Michael Goderbauer
a45727d813 Add MediaQuery to View (#118004)
* Add MediaQuery to View

* unify API

* fix test

* add test

* comment

* better doc

* Apply suggestions from code review

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2023-01-25 22:22:00 +00:00
Ahmed Ashour
1fd71de0c5 Remove superfluous words from comments (#119055)
* Remove superfluous words from comments.

* Revert `win32_window.h`

Which seems to come from `gallery`
2023-01-25 20:23:24 +00:00
Michael Goderbauer
0dd63d3310 Export View (#117475) 2023-01-25 18:58:23 +00:00
Simon Friis Vindum
b907acdde3 Add the cupertino system colors mint, cyan, and brown (#118971) 2023-01-25 10:04:21 -08:00
Ben Konyi
6cd4fa45e2 Add --serve-observatory flag to run, attach, and test (#118402)
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
2023-01-25 12:46:08 -05:00
Victoria Ashworth
81052a7d36 Add usage event to track when a iOS network device is used (#118915)
* Add usage event to track when a iOS network device is used

* update usage event to track percentage of iOS network vs usb devices, update and fix tests

* refactor tracking to happen in usageValues with a custom dimension
2023-01-25 10:57:12 -06:00
Taha Tesser
29ab437e28 Add Material 3 CheckboxListTile example and update existing examples (#118792)
* Add Material 3 `CheckboxListTile` example and update existing examples

* fix `list_tile.dart` doc issues

* Remove unnecessary comma
2023-01-25 13:21:18 +00:00
Justin McCandless
318f8758ba Pass through magnifierConfiguration (#118270) 2023-01-25 07:04:19 +00:00
Todd Volkert
351466aea6 Add Decoding Flutter videos to API docs (#116454)
* Add Decoding Flutter videos to API docs

* Review comments

* Update widget of the week videos too
2023-01-25 05:46:24 +00:00
Todd Volkert
83c3a61e3f Only emit image painting events in debug & profile modes. (#118872)
* Only emit image painting events in debug & profile modes.

These events were being emitted in release mode, which was showing up in the
profiler for my app as taking up a noticeable amount of build time (still
well within the frame budget, but this code was near the top of the list).

* Review comment
2023-01-25 03:19:47 +00:00
Greg Spencer
2f0dd56731 Refactor highlight handling in FocusManager (#119075)
* Add stack functionality to the FocusManager

* Separate out the highlight manager from the focus manager

* Revert more unrelated changes

* Review Changes
2023-01-24 23:37:57 +00:00
Michael Goderbauer
50ed8a34b0 Enable unnecessary_null_comparison check (#118849)
* Enable unnecessary_null_comparison outside of packages

* fix snippet

* enable for all
2023-01-24 21:24:11 +00:00
Gary Qian
5dabe102a2 Fix path name to discover debug apk on add2app builds (#117999) 2023-01-24 13:19:09 -08:00
stuartmorgan
e3c51a2f2a Add Windows unit tests to plugin template (#118638)
* Add Windows unit tests to plugin template

Adds an example native unit test to the plugin template for Windows,
matching the format we use for our 1P plugin example app unit tests.
Once these have been added for all platforms+languages, they will be
documented on a new plugin development page to explain their use.

Since we don't appear to be running our current plugin e2e tests for
Windows, this adds a new configuration to run them. I haven't
`led`-tested this, so it may not work, but this will give a starting
point for getting them running.

Part of https://github.com/flutter/flutter/issues/82458

* Minor fix

* Add test owner

* Fix typo

* Fix test feature flag
2023-01-24 18:23:57 +00:00
Polina Cherkasova
4d250302aa Add leak_tracker as dev_dependency. (#118952) 2023-01-24 12:42:45 -05:00
Nicholas Shahan
3735231841 Cleanup old Dart SDK layout compatibility (#118819)
The changes to the Dart SDK have rolled so the backward compatibility
is no longer needed.
2023-01-24 09:22:13 -08:00
Ahmed Ashour
c35efdaa68 Remove superfluous words. (#119008)
* Remove superfluous words.

* Update packages/flutter/lib/src/widgets/slotted_render_object_widget.dart

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-01-24 01:57:00 +00:00
Christopher Fujino
64b4c69bcc roll pub deps and remove archive, crypto, typed_data from allow-list (#119018)
* roll pub deps and remove archive, crypto, typed_data from allow-list

* un-comment code
2023-01-24 01:55:06 +00:00
Michael Goderbauer
0de8bef744 Remove unnecessary null checks in flutter/cupertino (#119020) 2023-01-24 01:36:50 +00:00
Michael Goderbauer
720bea0265 Remove unnecessary null checks in flutter/widgets (#119028)
* dart fix --apply

* manual fixes
2023-01-24 01:36:48 +00:00
Michael Goderbauer
59767e5fc2 Remove unnecessary null checks in flutter/material (#119022)
* dart fix --apply

* manual fixes
2023-01-24 01:33:53 +00:00
Greg Spencer
df4420835d Remove ThemeData.buttonColor references (#118658)
* Remove ThemeData.buttonColor references

* Fix test

* Remove more buttonColors

* Macro the definition of color scheme

* remove doc reference
2023-01-24 01:31:58 +00:00
Michael Goderbauer
38630b6bd1 Remove unnecessary null checks in flutter_tool (#118857)
* dart fix --apply

* manual fixes

* fix after merge conflicts

* review
2023-01-23 21:43:08 +00:00
Michael Goderbauer
19dfde6989 Remove unnecessary null checks in flutter/{foundation,services,physics} (#118910)
* Remove unnecessary null checks in flutter/foundation

* Remove unnecessary null checks in flutter/services

* Remove unnecessary null checks in flutter/physics
2023-01-23 19:29:48 +00:00
Michael Goderbauer
a63e19ba0f Remove unnecessary null checks in flutter_localizations (#118863) 2023-01-23 19:26:07 +00:00
Michael Goderbauer
6cd4945540 Remove unnecessary null checks in flutter_web_plugins (#118862) 2023-01-23 19:26:05 +00:00
Michael Goderbauer
224e6aa18c Remove unnecessary null checks in flutter/gestures (#118926) 2023-01-23 19:20:19 +00:00
Xilai Zhang
71a42563db Revert "[Re-land] Button padding m3 (#118640)" (#118962)
This reverts commit 973cff40b4.
2023-01-23 09:27:10 -08:00
Mouad Debbar
3bf79607dd [web] Fix paths fetched by flutter.js (#118684) 2023-01-23 15:02:58 +00:00
Samina Rahman Purba
80658873bc Add transform flip (#116705)
* Added Transform.flip

* Add tests for Transform.flip

* fix: failing tests

* fix the failing test

* fix test according to review

* Make z component constant, update doc

* Disabled changing alignment

* Apply suggested definition

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

Co-authored-by: nayeemtby <nayeemtby@gmail.com>
Co-authored-by: Nayeem Hasan <71181265+nayeemtby@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2023-01-21 19:20:28 +00:00
Michael Goderbauer
7272c809ea Remove unnecessary null checks in flutter/{animation,semantics,scheduler} (#118922)
* Remove unnecessary null checks in flutter/animation

* Remove unnecessary null checks in flutter/semantics

* Remove unnecessary null checks in flutter/scheduler
2023-01-21 02:20:24 +00:00
Michael Goderbauer
5d74b5cbf1 Remove unnecessary null checks in flutter/painting (#118925) 2023-01-21 02:16:10 +00:00
Michael Goderbauer
9837eb6fc5 Remove unnecessary null checks in flutter/rendering (#118923) 2023-01-21 01:34:50 +00:00
Michael Goderbauer
bb73121cb4 Remove unnecessary null checks in flutter/test (#118905) 2023-01-20 22:09:06 +00:00
Michael Goderbauer
288a7733e5 Remove unnecessary null checks in flutter_driver (#118864) 2023-01-20 22:02:49 +00:00
Michael Goderbauer
83720015a4 Remove unnecessary null checks in flutter_test (#118865) 2023-01-20 22:01:13 +00:00
Mitchell Goodwin
3c769effad Cupertino navbar ellipsis fix (#118841)
* Passdown context

* make transitions ignore preffered text size

* Add test

* Add comment

* Return const constructor
2023-01-20 21:31:06 +00:00
Victoria Ashworth
a07e8a6ac4 [reland] Support wireless debugging (#118895)
* Reland "Support iOS wireless debugging (#118104)"

This reverts commit cbf2e16892.

* Remove device loading status
2023-01-20 19:02:37 +00:00
Michael Goderbauer
f291eb3495 Remove unnecessary null checks in integration_test (#118861) 2023-01-20 18:30:08 +00:00
Alexander Markov
492d57262f Cleanup obsolete --compact-async compiler option (#118894) 2023-01-20 09:48:26 -08:00
Eilidh Southren
095b1abdad Checkbox borderSide lerp bug fix (#118728)
* theme override fix

* add lerp condition and tests

* remove unwanted changes

* resolve app_bar token version

* update test names
2023-01-20 14:25:50 +00:00
Taha Tesser
74645b43aa Fix NavigationBar indicator ripple doesn't account for label height (#117473) 2023-01-20 08:48:06 +00:00
Jenn Magder
030288d33b Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858)
This reverts commit 73096fd96e.
2023-01-20 03:46:45 +00:00