Commit Graph

1132 Commits

Author SHA1 Message Date
Hans Muller
dd30efa190 Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c7.
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7 Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jonah Williams
d52f315c35 Add new benchmark to track cost of dependencies to a User (#23856) 2018-11-02 13:38:54 -07:00
Dan Field
f1f4bda8da Mark some tests as not flaky (#23840)
These tests have been run for a few days now with no flakiness.
2018-11-01 20:08:45 -07:00
Jonah Williams
0b35937b13 Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172.
2018-11-01 19:30:11 -07:00
Hans Muller
949cfcf172 Flutter gallery: updated Shrine demo (#23539) 2018-11-01 12:48:24 -07:00
Michael Klimushyn
01c7081565 Add info about new test cases (#23805) 2018-10-31 21:12:51 -07:00
Dan Field
fd6b2e198c Re-reland Xcode backend refactor (#23762)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files

* add FLUTTER_FRAMEWORK_DIR back, set swift version for profile, tell Podfile about profile
2018-10-31 16:37:53 -07:00
Greg Spencer
1b9cba4b42 Make sure we refer to 'stable', and not 'release' branch. (#23745) 2018-10-30 16:57:54 -07:00
Greg Spencer
f9c6f30576 Allow users to create samples using flutter create. (#23584)
This adds flutter create --sample which allows users to execute a command which will create a working sample app from samples embedded in the API docs.

The command looks something like this:

flutter create --sample=chip.DeletableChipAttributes.onDeleted mysample
2018-10-30 16:01:14 -07:00
Dan Field
7217999a9a Revert "Reland Xcode backend refactor" (#23737)
* Revert "Update templates (#23698)"

This reverts commit 5b0de6d679.

* Revert "Verify that date/number translations exist for all supported languages (#23692)"

This reverts commit 3449edf256.

* Revert "Reland Xcode backend refactor (#23574)"

This reverts commit 7270f2845d.
2018-10-30 09:36:31 -07:00
Dan Field
7270f2845d Reland Xcode backend refactor (#23574)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files
2018-10-30 07:23:19 -07:00
Devon Carew
e30f9a9447 add explicit const keywords (#23652) 2018-10-29 22:39:40 -07:00
Ian Hickson
4a094de290 [H] Cleanup (#23632)
* Avoid abbreviations

* Sample code for AppBar.leading

* Add a test for OverflowBox/FractionallySizedBox

* Minor wording improvements in the text.

The words "note that" here don't really contribute to the flow.
2018-10-29 19:44:00 -07:00
Devon Carew
0dada102fe remove unnecessary overrides (#23650) 2018-10-29 18:51:29 -07:00
Yegor
223826247f deflake the dartdocs test (#23582) 2018-10-26 13:12:14 -07:00
Stanislav Baranov
c7b10a2d80 Propagate pointer size from Android MotionEvent. (#23536) 2018-10-26 11:48:00 -07:00
Yegor
4452bd0a6b Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)"… (#23482)
* Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)" (#23430)"

This reverts commit 3bbb3082b8.

This relands the LocalHistoryRoute change. The analyzer bug has been fixed.

* mark dartdocs as flaky
2018-10-25 09:56:23 -07:00
Michael Klimushyn
ce434022b5 Fix "E2E test setting and using isolate names (#23388)" (#23438)
Updates gradle.

This reverts commit d07c09c9a1a8bd9a0860c579154974437da14024.
2018-10-24 11:44:45 -07:00
Michael Goderbauer
55fe15bfdd mark integration_ui_ios as flaky (#23437) 2018-10-23 16:45:17 -07:00
Jacob Richman
b21fb8c27d Run flutter tests with --track-widget-creation as part of the build. (#23415) 2018-10-23 14:10:53 -07:00
Greg Spencer
65d3ddd5d1 Dartdoc snippet extension to inject full featured code snippets in to API docs. (#23281)
This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.

This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
2018-10-23 13:50:24 -07:00
Michael Klimushyn
e70f19523b Revert "E2E test setting and using isolate names (#23388)" (#23416)
This reverts commit 93573de216.

Fails in the devicelab:

```
run:stderr: A problem occurred evaluating project ':app'.
run:stderr: > Could not resolve all files for configuration 'classpath'.2018-10-23T10:46:46.335864:
run:stderr:    > Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.3.1).2018-10-23T10:46:46.335960:
run:stderr:      Searched in the following locations:2018-10-23T10:46:46.336048:
```
2018-10-23 11:28:12 -07:00
Michael Klimushyn
93573de216 E2E test setting and using isolate names (#23388)
Adds an integration devicelab test that runs an Android app with two
custom named isolates. Tests that the isolate names are present and that
it's possible to attach to just one of the isolates.

Fixes flutter/flutter#22009
2018-10-23 09:30:00 -07:00
Michael Klimushyn
43c99404c5 Test flutter create --offline (#23278)
Verifies that flutter tools isn't rebuilt. Doesn't truly check that the
created output is runnable.
2018-10-22 16:39:28 -07:00
Michael Goderbauer
9b5c780604 Force GC before GC-sensitive benchmark runs (#23289) 2018-10-21 15:58:19 +02:00
Stanislav Baranov
323d1574c6 newly created apps / plugins should use latest gradle dependencies (#22790) (#23314) 2018-10-19 19:07:06 -07:00
Greg Spencer
9372f86149 Update the Dockerfile to use the master firebase-tools, tweak scripts (#23279) 2018-10-19 12:22:03 -07:00
Greg Spencer
fbb01eabae Update dartdoc to use 0.24.1 (#23275) 2018-10-19 10:40:30 -07:00
Greg Spencer
2000583ed3 Revert "don't disable TODO issues in IDEs (#23274)" (#23297)
Devon asked me to revert commit c4d1b31b74.

Merging on red to fix the build.
2018-10-19 10:03:35 -07:00
Devon Carew
c4d1b31b74 don't disable TODO issues in IDEs (#23274)
* don't disable TODO issues in IDEs

* minor change to start cirrus
2018-10-19 08:01:05 -07:00
Siva
cf18d01e86 Disable unsafePackageSerialization as it causes issues when coverage is turned on (#23280)
* Disable unsafePackageSerialization as it causes issues when coverage is
used (see https://github.com/dart-lang/sdk/issues/34841)

* Restore Coverage.
2018-10-19 06:19:24 -07:00
Danny Tuppeny
b357b55904 Use (processors-1) for test runs (test defaults to processors/2) (#22803)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-19 08:07:54 +01:00
Yegor
82d6589590 Revert "newly created apps / plugins should use latest gradle dependencies (#22790)" (#23263)
This reverts commit 751c083f7d.

Our buildbots need to be upgraded to a newer version of the Android SDK.
2018-10-18 14:17:47 -07:00
Sebastian Roth
751c083f7d newly created apps / plugins should use latest gradle dependencies (#22790) 2018-10-18 12:56:18 -07:00
Yegor
9524b611c0 skip coverage due to https://github.com/dart-lang/sdk/issues/34841 (#23224) 2018-10-17 17:56:07 -07:00
Jacob Richman
e4c2c978a6 Dispatch a Flutter.Navigation event each time navigation occurs. (#23126)
Dispatch a Flutter.Navigation event each time navigation occurs.
2018-10-17 07:40:08 -07:00
Alexandre Ardhuin
8b0de38ef8 fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Alexandre Ardhuin
936dea28da enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Janice Collins
24717a3280 Update dartdoc to v0.24.0. (#23175) 2018-10-16 14:40:03 -07:00
Jacob Richman
c6a222fa28 Revert "Run flutter tests with --track-widget-creation as part of the build. (#22596)" (#23129)
This reverts commit bf92d7f286.
2018-10-15 17:13:44 -07:00
Jacob Richman
bf92d7f286 Run flutter tests with --track-widget-creation as part of the build. (#22596) 2018-10-15 13:46:25 -07:00
matthew-carroll
04a26778c5 Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c.
2018-10-12 16:31:34 -07:00
matthew-carroll
80f80ab08c Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e45.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae7.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
Greg Spencer
ba1323929a Re-enable docs generation. (#22979) 2018-10-11 15:56:22 -07:00
Janice Collins
3b68ae8422 Remove extraneous flags from dartdoc invocation (#22972) 2018-10-11 13:27:43 -07:00
Greg Spencer
081d2a7a86 Re-land text wrapping/color PR (#22831)
This attempts to re-land #22656.

There are two changes from the original:

I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.

I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.

As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.

*     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)

    This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).

    Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.

    Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.

    Since wrapping is now turned on, also removed many redundant '\n's in the code.
2018-10-10 18:17:56 -07:00
Greg Spencer
0ff9e8a928 Rename 'application' back to 'module', and make 'app' the default again for templates. (#22888)
We decided that redefining the default for templates was premature. We're going to go back to having "module" in experimental land again, and we'll try again when we have the feature set fully baked.

This keeps the writing of the .metadata files, and writing the template type to them, because that was a good improvement, and there are still a bunch of added tests that improve our coverage.
2018-10-10 11:01:40 -07:00
Hans Muller
8bfb4b3ee5 Bring TextTheme into alignment with the current Material spec (#22330) 2018-10-09 17:00:15 -07:00
Janice Collins
59f1f1b6e2 Update dartdoc to 0.23.1. (#22875) 2018-10-09 13:49:00 -07:00