Michael Goderbauer
082336e7c2
Fix code smells reported by chrome's clang plugin ( flutter/engine#6833 )
2018-11-12 19:59:29 -08:00
skia-flutter-autoroll
2f1fcadb23
Roll src/third_party/skia 82cd7e80a98d..f04fb3cacbad (2 commits) ( flutter/engine#6836 )
...
https://skia.googlesource.com/skia.git/+log/82cd7e80a98d..f04fb3cacbad
Created with:
gclient setdep -r src/third_party/skia@f04fb3cacbad
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-12 22:02:14 -05:00
Dan Field
877b3996d8
Avoid announcing text field when it lacks a11y focus ( flutter/engine#6830 )
...
* Avoid announcing text field when it lacks a11y focus
2018-11-12 16:08:59 -08:00
skia-flutter-autoroll
8d44bdef97
Roll src/third_party/skia 6b90dfed6742..82cd7e80a98d (4 commits) ( flutter/engine#6831 )
...
https://skia.googlesource.com/skia.git/+log/6b90dfed6742..82cd7e80a98d
Created with:
gclient setdep -r src/third_party/skia@82cd7e80a98d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-12 18:42:14 -05:00
Amir Hardon
3438348516
Release the surface texture entry when the platform view is disposed. ( flutter/engine#6829 )
...
We were leaking the texture after the view was disposed.
2018-11-12 14:23:25 -08:00
liyuqian
a8aa99c094
Respect offset in OpacityLayer's paint bounds ( flutter/engine#6826 )
...
This fixes https://github.com/flutter/flutter/issues/23890
I'll add unit tests to flutter/flutter shortly.
2018-11-12 12:52:18 -08:00
skia-flutter-autoroll
b81986255a
Roll src/third_party/skia eb4d641d9437..6b90dfed6742 (5 commits) ( flutter/engine#6828 )
...
https://skia.googlesource.com/skia.git/+log/eb4d641d9437..6b90dfed6742
Created with:
gclient setdep -r src/third_party/skia@6b90dfed6742
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-12 15:24:15 -05:00
KyleWong
159acc0b2b
Fix a minikin crash (nullptr& EXC_BAD_ACCESS) on iOS8. ( flutter/engine#6795 )
...
* Fix a minikin crash (nullptr& EXC_BAD_ACCESS) on iOS8.
* Use find for vector to avoid side effect.
2018-11-12 11:21:20 -08:00
Jason Simmons
16a1ab8413
Fix MakeRenderContextCurrent to handle software rendering ( flutter/engine#6827 )
2018-11-12 11:20:49 -08:00
Rusino
01e57d1939
SkPaint::FontMetrics -> SkFontMetrics ( flutter/engine#6824 )
...
* SkPaint::FontMetrics -> SkFontMetrics
* fix file formatting
* another attempt to correct file formatting
2018-11-12 12:55:34 -05:00
skia-flutter-autoroll
35eabd5347
Roll src/third_party/skia 0243949545eb..eb4d641d9437 (10 commits) ( flutter/engine#6825 )
...
https://skia.googlesource.com/skia.git/+log/0243949545eb..eb4d641d9437
Created with:
gclient setdep -r src/third_party/skia@eb4d641d9437
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-12 12:06:14 -05:00
skia-flutter-autoroll
8c4b501e55
Roll src/third_party/skia c7a34cae21d2..0243949545eb (11 commits) ( flutter/engine#6823 )
...
https://skia.googlesource.com/skia.git/+log/c7a34cae21d2..0243949545eb
Created with:
gclient setdep -r src/third_party/skia@0243949545eb
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-12 08:47:14 -05:00
Gary Qian
06969c2491
Document not passing empty-strings into Locale ( flutter/engine#6818 )
2018-11-11 03:42:28 -08:00
skia-flutter-autoroll
da9ff853dd
Roll src/third_party/skia 1c3f17fffa79..c7a34cae21d2 (2 commits) ( flutter/engine#6821 )
...
https://skia.googlesource.com/skia.git/+log/1c3f17fffa79..c7a34cae21d2
Created with:
gclient setdep -r src/third_party/skia@c7a34cae21d2
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-10 02:13:42 -05:00
skia-flutter-autoroll
d3d4627a9d
Roll src/third_party/skia 95af4726bf91..1c3f17fffa79 (1 commits) ( flutter/engine#6819 )
...
https://skia.googlesource.com/skia.git/+log/95af4726bf91..1c3f17fffa79
Created with:
gclient setdep -r src/third_party/skia@1c3f17fffa79
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-09 22:52:42 -05:00
Jason Simmons
c1c5977c07
Ensure that the EGL rendering context is bound to the GPU thread in Rasterizer::MakeRasterSnapshot ( flutter/engine#6816 )
...
Fixes https://github.com/flutter/flutter/issues/24083
2018-11-09 17:05:05 -08:00
Dan Field
a03e311cb0
fix log ( flutter/engine#6817 )
2018-11-09 16:46:49 -08:00
skia-flutter-autoroll
ed0270a84f
Roll src/third_party/skia ef4709b7850d..95af4726bf91 (22 commits) ( flutter/engine#6815 )
...
https://skia.googlesource.com/skia.git/+log/ef4709b7850d..95af4726bf91
Created with:
gclient setdep -r src/third_party/skia@95af4726bf91
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-09 19:20:42 -05:00
skia-flutter-autoroll
d0d14dd31c
Roll src/third_party/skia 06a477c3300d..ef4709b7850d (31 commits) ( flutter/engine#6811 )
...
https://skia.googlesource.com/skia.git/+log/06a477c3300d..ef4709b7850d
Created with:
gclient setdep -r src/third_party/skia@ef4709b7850d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-09 16:01:54 -05:00
Amir Hardon
3f3ce50597
Use the internal_nodes_canvas for all leaf node operations. ( flutter/engine#6804 )
...
This also renames the PaintContext's canvas to lead_nodes_canvas so that it
is more explicit on the call sites which canvas is being used.
2018-11-09 12:10:29 -08:00
Amir Hardon
e818420245
Synchronize Flutter's rendering with CA. ( flutter/engine#6807 )
...
Right now we do it whenever the platform views preview flag is on.
This is less efficient, filed
https://github.com/flutter/flutter/issues/24133 to only do this when
there's a platform view in the tree.
2018-11-09 12:10:09 -08:00
Jason Simmons
708c487c14
Update Vulkan headers to 1.1 ( flutter/engine#6806 )
2018-11-09 12:01:57 -08:00
Amir Hardon
18f0d35d05
Move the embedded view preview flag check to a common function. ( flutter/engine#6813 )
2018-11-09 11:24:14 -08:00
Amir Hardon
818cccfd47
Fix wrong flutter/platform_views protocol implementation on iOS. ( flutter/engine#6803 )
...
The `id` parameter of onDispose is passed as the method argument and not as
part of a map.
2018-11-09 10:21:44 -08:00
Amir Hardon
bfc1db2612
Support platform view overlays with GL rendering ( flutter/engine#6769 )
...
Moved the frame buffer specific logic from IOSGLContext to IOSGLRenderTarget.
use recording canvases for overlays
Support platform view overlays with gl rendering.
This also changes the overlay canvases (for both software and gl
rendering) be recording canvases, and only rasterize them after
finishing the paint traversal.
2018-11-08 19:52:43 -08:00
Jason Simmons
269879dc6e
Revert "Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) ( #6801 )" ( flutter/engine#6809 )
...
This reverts commit 061170fc32 .
2018-11-08 17:07:02 -08:00
Rusino
cfd68e9189
Update paint hinting for upcoming Skia API changes. ( flutter/engine#6802 )
2018-11-08 16:53:24 -05:00
skia-flutter-autoroll
061170fc32
Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) ( flutter/engine#6801 )
...
https://skia.googlesource.com/skia.git/+log/06a477c3300d..dd650c40d148
Created with:
gclient setdep -r src/third_party/skia@dd650c40d148
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 16:12:43 -05:00
Amir Hardon
271e82a7e4
Include vector in embedded_views.h ( flutter/engine#6800 )
2018-11-08 12:54:36 -08:00
Amir Hardon
df64376478
Make the FlutterPlatformViewFactory create FlutterPlatformViews. ( flutter/engine#6782 )
...
Handing a UIView refererence directly to the engine makes it challenging
for plugin authors to retain a controller for that UIView (e.g the
controller that talks over the platform channel) for as long as the
embedded view is needed.
We instead make the factory return a FlutterPlatformView which is a
wrapper around the UIView that the engine retains as long as the
platform view instance is needed. This allows plugin authors to keep
their control logic in the FlutterPlatformView and know that the engine
is responsible for retaining the reference.
2018-11-08 11:21:55 -08:00
Dan Field
3446f04895
Fix mDNS publishing for iOS simulator ( flutter/engine#6789 )
...
* Don't block the platfrorm thread on simulator mDNS publishing
2018-11-08 11:18:59 -08:00
Dan Field
c0ce728956
disable embedder_unittests ( flutter/engine#6798 )
2018-11-08 11:18:21 -08:00
skia-flutter-autoroll
24379a6752
Roll src/third_party/skia 5d58d09ae77d..06a477c3300d (5 commits) ( flutter/engine#6797 )
...
https://skia.googlesource.com/skia.git/+log/5d58d09ae77d..06a477c3300d
Created with:
gclient setdep -r src/third_party/skia@06a477c3300d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 12:53:43 -05:00
Amir Hardon
cbfe0c6713
Discard embedded UIViews on hot restart. ( flutter/engine#6772 )
2018-11-08 09:32:01 -08:00
Amir Hardon
d6e19afcb5
Add an internal_nodes_canvas to PaintContext. ( flutter/engine#6728 )
...
When we visit a PlatformViewLayer during the paint traversal it replaces
the PaintContext's canvas with a new one that is painted ontop of the
embedded view.
We need to make sure that operations applied by parent layers are also
applied to the new canvas.
To achieve this we collect all the canvases in a SkNWayCanvas and use
this canvas by non leaf nodes. Leaf nodes still paint only to the "current"
canvas.
This PR moves the overlay canvas creation from the paint phase to the
preroll phase, collects them into a SkNWayCanvas and set it in
PaintContext.
To keep this PR focused, I only used the internal_nodes_canvas in the
tranform_layer.
Will followup with a PR that changes all internal layers to use the
internal_nodes_canvas.
2018-11-08 09:31:40 -08:00
skia-flutter-autoroll
7f8c430aae
Roll src/third_party/skia fa8898747551..5d58d09ae77d (4 commits) ( flutter/engine#6796 )
...
https://skia.googlesource.com/skia.git/+log/fa8898747551..5d58d09ae77d
Created with:
gclient setdep -r src/third_party/skia@5d58d09ae77d
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 09:31:43 -05:00
skia-flutter-autoroll
e54317a95b
Roll src/third_party/skia 23d1f94faac1..fa8898747551 (1 commits) ( flutter/engine#6794 )
...
https://skia.googlesource.com/skia.git/+log/23d1f94faac1..fa8898747551
Created with:
gclient setdep -r src/third_party/skia@fa8898747551
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 07:20:18 -05:00
skia-flutter-autoroll
4cedf0fd96
Roll src/third_party/skia 2f8889b876d3..23d1f94faac1 (1 commits) ( flutter/engine#6793 )
...
https://skia.googlesource.com/skia.git/+log/2f8889b876d3..23d1f94faac1
Created with:
gclient setdep -r src/third_party/skia@23d1f94faac1
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 04:02:45 -05:00
skia-flutter-autoroll
fb6f923736
Roll src/third_party/skia 71bcc7d63f8c..2f8889b876d3 (1 commits) ( flutter/engine#6792 )
...
https://skia.googlesource.com/skia.git/+log/71bcc7d63f8c..2f8889b876d3
Created with:
gclient setdep -r src/third_party/skia@2f8889b876d3
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-08 00:43:18 -05:00
Dan Field
22f67d6ba3
avoid overreleasing FlutterView ( flutter/engine#6791 )
2018-11-07 21:19:14 -08:00
skia-flutter-autoroll
6e25fd04e8
Roll src/third_party/skia f49563bf9276..71bcc7d63f8c (3 commits) ( flutter/engine#6790 )
...
https://skia.googlesource.com/skia.git/+log/f49563bf9276..71bcc7d63f8c
Created with:
gclient setdep -r src/third_party/skia@71bcc7d63f8c
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 21:25:18 -05:00
Mehmet Fidanboylu
e8d852bac0
Skia Cleanup ( flutter/engine#6786 )
2018-11-07 15:29:52 -08:00
skia-flutter-autoroll
1c870b3ff5
Roll src/third_party/skia b52c273d3f05..f49563bf9276 (7 commits) ( flutter/engine#6785 )
...
https://skia.googlesource.com/skia.git/+log/b52c273d3f05..f49563bf9276
Created with:
gclient setdep -r src/third_party/skia@f49563bf9276
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 18:07:18 -05:00
Michael Goderbauer
4e289e704a
Delete unused license goldens and add check ( flutter/engine#6784 )
2018-11-07 13:23:18 -08:00
Michael Goderbauer
0def82ddb0
Unify copyright lines ( flutter/engine#6757 )
2018-11-07 12:24:35 -08:00
skia-flutter-autoroll
3f23fce292
Roll src/third_party/skia 62cc5f581747..b52c273d3f05 (13 commits) ( flutter/engine#6783 )
...
https://skia.googlesource.com/skia.git/+log/62cc5f581747..b52c273d3f05
Created with:
gclient setdep -r src/third_party/skia@b52c273d3f05
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 14:46:18 -05:00
Todd Volkert
18134d0114
Fix String comparison as if Java were Dart. ( flutter/engine#6781 )
...
This also removes unused imports and sorts imports correctly
2018-11-07 09:59:51 -08:00
skia-flutter-autoroll
96197b066d
Roll src/third_party/skia 273fa2f3bd0b..62cc5f581747 (7 commits) ( flutter/engine#6780 )
...
https://skia.googlesource.com/skia.git/+log/273fa2f3bd0b..62cc5f581747
Created with:
gclient setdep -r src/third_party/skia@62cc5f581747
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 11:27:18 -05:00
skia-flutter-autoroll
c580e2a430
Roll src/third_party/skia 67f5c0ceac22..273fa2f3bd0b (1 commits) ( flutter/engine#6779 )
...
https://skia.googlesource.com/skia.git/+log/67f5c0ceac22..273fa2f3bd0b
Created with:
gclient setdep -r src/third_party/skia@273fa2f3bd0b
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 08:06:18 -05:00
skia-flutter-autoroll
1b5ddab128
Roll src/third_party/skia 2a13921745eb..67f5c0ceac22 (2 commits) ( flutter/engine#6777 )
...
https://skia.googlesource.com/skia.git/+log/2a13921745eb..67f5c0ceac22
Created with:
gclient setdep -r src/third_party/skia@67f5c0ceac22
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-07 04:48:18 -05:00