firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
83,702 Commits 1 Branch 0 Tags
main
Commit Graph

49 Commits

Author SHA1 Message Date
Chikamatsu Kazuya
c8e34e067c Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (#161577) 
Original PR: #160241 (reverted in #161555 due to regression ), closes
#29068

In addition to the original PR, this includes a fix for the integration
test failure of
[flutter_gallery/transitions_perf_e2e](1b0441c18a/dev/integration_tests/flutter_gallery/test_driver).
Error log is
[here](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725826401212583777/+/u/run_flutter_gallery__transition_perf_e2e_ios/stdout).
Tested locally on iOS real device and confirmed it passes.

It seems that the next operation of the test was performed before the
page animation was finished because the PR makes the page transition
duration longer.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-22 19:13:01 +00:00
Michael Goderbauer
5491c8c146 Auto-format Framework (#160545) 
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.

**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
 2024-12-19 20:06:21 +00:00
Jonah Williams
295eeaf100 [devicelab] retain first frame data in certain integration tests. (#143419) 
Part of https://github.com/flutter/flutter/issues/143404

We currently drop the first N frames of all benchmarks. For the app based benchmarks (not microbenchmarks) this is harmful as we miss first time initialization costs in our CI.

Still need to do this with flutter/gallery, but that lives in a different repo.
 2024-02-14 03:58:58 +00:00
Tomasz Gucio
99c7e9f088 Add spaces after flow control statements (#126320) 2023-05-15 11:07:30 +02:00
Michael Goderbauer
10a7c9ba22 Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
Jonah Williams
98f0c3694b add old gallery page transition (#106701) 2022-06-27 23:36:06 +00:00
Zachary Anderson
070309687e Skip Video demo in integration tests of flutter_gallery (#100666) 2022-03-24 09:16:46 -07:00
Ian Hickson
ab89ce285f Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Ian Hickson
61a0add286 Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0 Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461) 
This reverts commit 5fd259be24.
 2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24 Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Jason Simmons
2004afae06 Use async timeline events for the phases of the scheduler binding (#88825) 2021-09-10 10:17:05 -07:00
Darren Austin
a1cd3f45e0 Updated some skip test comments that were missed in the audit. (#88893) 2021-08-25 11:49:04 -07:00
Ren You
3dea9f0251 Revert "Clean up the bindings APIs (#86438)" (#86484) 
This reverts commit d056500bfe.
 2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe Clean up the bindings APIs (#86438) 2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181 Revert "Clean up the bindings APIs (#86388)" (#86404) 
This reverts commit 31de052e3f.
 2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f Clean up the bindings APIs (#86388) 2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4 Revert "Clean up the bindings APIs (#83843)" (#86386) 
This reverts commit e2490f2906.
 2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906 Clean up the bindings APIs (#83843) 2021-07-13 12:41:03 -07:00
Dan Field
9c0bd18c40 Reland eliminate timeouts from integration tests (#85141) 2021-06-23 13:08:51 -07:00
Dan Field
69f2f8a18b Revert "Remove per-test timeouts from integration tests (#85098)" (#85133) 
This reverts commit b96c3c22ce.
 2021-06-23 08:17:27 -07:00
Dan Field
b96c3c22ce Remove per-test timeouts from integration tests (#85098) 2021-06-23 07:17:28 -07:00
Dan Field
eafadd8b1c Try to dump app again for run_demos.dart (#85048) 2021-06-22 10:43:54 -07:00
Dan Field
46c546684f Dump the app if we cannot tap the demo (#84996) 
To help deflake https://github.com/flutter/flutter/issues/83298
 2021-06-21 12:04:43 -07:00
Dan Field
a8232dd77d Add GC events to transitions perf test for gallery (#84956) 2021-06-21 08:09:03 -07:00
Dan Field
3794884fbb Deflake demo (#84593) 2021-06-14 14:41:47 -07:00
Greg Spencer
88f3811055 Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. (#84476) 
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.

Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
 2021-06-14 14:16:57 -07:00
Abhishek Ghaskata
3749ff02e1 Migrate gallery test to null safety (#84065) 2021-06-07 11:29:04 -07:00
Anis Alibegić
c99ed373b3 Fixed large amount of spelling errors (#83744) 2021-06-02 10:14:06 -07:00
Phil Quitslund
61c30c41b2 fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Dan Field
d377c1baed Always write full timeline before summary (#79310) 2021-03-31 13:01:28 -07:00
Jenn Magder
f2bb39d6b6 Gallery transition tests pass when device rotated (#75672) 2021-02-09 10:08:18 -08:00
Sam Rawlins
006638839c Remove "unnecessary" imports. (#74383) 2021-01-25 19:04:05 -08:00
Jonah Williams
28ecf05692 [null-safety] opt driver tests into null safety (#70245) 2020-11-10 16:29:13 -08:00
Emmanuel Garcia
21e802746b Migrate Flutter Gallery test to null safety (#70116) 2020-11-09 12:29:14 -08:00
Michael Thomsen
e4d94f7ccd Revert "Migrate Flutter gallery test to null safety (#69048)" (#70023) 
This reverts commit 7ba775a994.
 2020-11-07 12:15:22 +01:00
Emmanuel Garcia
7ba775a994 Migrate Flutter gallery test to null safety (#69048) 2020-11-06 20:38:12 -08:00
Jonah Williams
3e41962dff [null-safety] update tests and tool auto-detection for null safe dart (#69405) 
Disable null safety auto-detection for the web
 2020-10-30 13:42:54 -07:00
Yegor
2fa03438de add web_long_running_tests shard containing long-running web tests (#67324) 2020-10-29 14:23:02 -07:00
Ming Lyu (CareF)
92f82c7b88 Transport e2e based perforamnce test to integration_test and remove duplicate watchPerformance (#67594) 2020-10-17 20:37:03 -07:00
Michael R Fairhurst
7f3c9b6bda Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Yuqian Li
484f3f2646 Add FrameTiming delay to watchPerformance (#64780) 2020-09-02 11:15:08 -07:00
Yuqian Li
6f0ea92709 Change typo profileDemos to restDemos (#64364) 2020-08-21 15:36:04 -07:00
Jim Graham
9e86e9fb1e report list of detail files so devicelab can save them (#64009) 2020-08-20 10:58:25 -07:00
Ming Lyu (CareF)
360023e2bc Clean up flutter_gallery__transition_perf (#63609) 2020-08-13 14:41:04 -07:00
Ming Lyu (CareF)
2384376f64 Migrate gallery/transitions_perf test to e2e (#62064) 2020-08-12 13:36:07 -07:00
Ming Lyu (CareF)
c3217dac7f await timelinesummary to file (#60774) 2020-07-06 13:19:19 -04:00
Dan Field
c5318f7f07 Make debugSemantics available to profile mode (#58620) 2020-06-03 12:32:35 -07:00
Michael Thomsen
e167181444 Move flutter_gallery to the testing folder (#52532) 
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
 2020-03-16 10:31:42 +01:00