From ff7e5f3d736c8420351295e331ed25a66e8cefff Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 2 Oct 2024 08:36:40 -0700 Subject: [PATCH] update flutter create generated projects to use package:flutter_lints 5.0.0 (#156011) - update flutter create generated projects to use package:flutter_lints 5.0.0; this is a follow-up to publishing `package:flutter_lints` 5.0.0 - related to https://github.com/dart-lang/lints/issues/205 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- packages/flutter_tools/templates/app/pubspec.yaml.tmpl | 6 +++--- .../flutter_tools/templates/module/common/pubspec.yaml.tmpl | 2 +- .../templates/package/lib/projectName.dart.tmpl | 2 -- packages/flutter_tools/templates/package/pubspec.yaml.tmpl | 2 +- .../flutter_tools/templates/package_ffi/pubspec.yaml.tmpl | 2 +- .../flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl | 2 +- packages/flutter_tools/templates/skeleton/pubspec.yaml.tmpl | 2 +- 7 files changed, 8 insertions(+), 10 deletions(-) diff --git a/packages/flutter_tools/templates/app/pubspec.yaml.tmpl b/packages/flutter_tools/templates/app/pubspec.yaml.tmpl index 6c67639dda..78f4eca202 100644 --- a/packages/flutter_tools/templates/app/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/app/pubspec.yaml.tmpl @@ -14,7 +14,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 flutter: uses-material-design: true @@ -52,8 +52,8 @@ environment: dependencies: flutter: sdk: flutter - {{#withPluginHook}} + {{pluginProjectName}}: # When depending on this package from a real application you should use: # {{pluginProjectName}}: ^x.y.z @@ -80,7 +80,7 @@ dev_dependencies: # activated in the `analysis_options.yaml` file located at the root of your # package. See that file for information about deactivating specific lint # rules and activating additional ones. - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec diff --git a/packages/flutter_tools/templates/module/common/pubspec.yaml.tmpl b/packages/flutter_tools/templates/module/common/pubspec.yaml.tmpl index e8c927313b..d2052b7cf5 100644 --- a/packages/flutter_tools/templates/module/common/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/module/common/pubspec.yaml.tmpl @@ -31,7 +31,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec diff --git a/packages/flutter_tools/templates/package/lib/projectName.dart.tmpl b/packages/flutter_tools/templates/package/lib/projectName.dart.tmpl index 4048343a6d..298576d813 100644 --- a/packages/flutter_tools/templates/package/lib/projectName.dart.tmpl +++ b/packages/flutter_tools/templates/package/lib/projectName.dart.tmpl @@ -1,5 +1,3 @@ -library {{projectName}}; - /// A Calculator. class Calculator { /// Returns [value] plus 1. diff --git a/packages/flutter_tools/templates/package/pubspec.yaml.tmpl b/packages/flutter_tools/templates/package/pubspec.yaml.tmpl index e06c43d47e..5a6174c799 100644 --- a/packages/flutter_tools/templates/package/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/package/pubspec.yaml.tmpl @@ -14,7 +14,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec diff --git a/packages/flutter_tools/templates/package_ffi/pubspec.yaml.tmpl b/packages/flutter_tools/templates/package_ffi/pubspec.yaml.tmpl index f6386bbc7a..da146b06d9 100644 --- a/packages/flutter_tools/templates/package_ffi/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/package_ffi/pubspec.yaml.tmpl @@ -15,5 +15,5 @@ dependencies: dev_dependencies: ffi: ^2.1.3 ffigen: ^13.0.0 - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 test: ^1.25.8 diff --git a/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl b/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl index 2b9f6ac8ba..0b755b1d28 100644 --- a/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl @@ -24,7 +24,7 @@ dev_dependencies: {{/withFfi}} flutter_test: sdk: flutter - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec diff --git a/packages/flutter_tools/templates/skeleton/pubspec.yaml.tmpl b/packages/flutter_tools/templates/skeleton/pubspec.yaml.tmpl index 65b6c2489c..f4f092fdc1 100644 --- a/packages/flutter_tools/templates/skeleton/pubspec.yaml.tmpl +++ b/packages/flutter_tools/templates/skeleton/pubspec.yaml.tmpl @@ -19,7 +19,7 @@ dev_dependencies: flutter_test: sdk: flutter - flutter_lints: ^4.0.0 + flutter_lints: ^5.0.0 flutter: uses-material-design: true