From ff58db4ac3c564b83ab1a8ee5d4fa6db26be3fa9 Mon Sep 17 00:00:00 2001
From: debuggerx01 <dx8917312@163.com>
Date: Tue, 24 Apr 2018 04:47:47 +0800
Subject: [PATCH] Fix hue to 0.0 when red == green == blue. (#16872)

When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
---
 packages/flutter/lib/src/painting/colors.dart   | 4 +++-
 packages/flutter/test/painting/colors_test.dart | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/flutter/lib/src/painting/colors.dart b/packages/flutter/lib/src/painting/colors.dart
index c24bd9ef79..29ab0869e7 100644
--- a/packages/flutter/lib/src/painting/colors.dart
+++ b/packages/flutter/lib/src/painting/colors.dart
@@ -49,7 +49,9 @@ class HSVColor {
     } else if (max == blue) {
       hue = 60.0 * (((red - green) / delta) + 4);
     }
-
+    
+    /// fix hue to 0.0 when red == green == blue.
+    hue = hue.isNaN ? 0.0 : hue;
     final double saturation = max == 0.0 ? 0.0 : delta / max;
 
     return new HSVColor.fromAHSV(alpha, hue, saturation, max);
diff --git a/packages/flutter/test/painting/colors_test.dart b/packages/flutter/test/painting/colors_test.dart
index c0fcbab41c..42dfb23850 100644
--- a/packages/flutter/test/painting/colors_test.dart
+++ b/packages/flutter/test/painting/colors_test.dart
@@ -32,11 +32,13 @@ void main() {
     final HSVColor red = new HSVColor.fromColor(const Color.fromARGB(0xFF, 0xFF, 0x00, 0x00));
     final HSVColor green = new HSVColor.fromColor(const Color.fromARGB(0xFF, 0x00, 0xFF, 0x00));
     final HSVColor blue = new HSVColor.fromColor(const Color.fromARGB(0xFF, 0x00, 0x00, 0xFF));
+    final HSVColor grey = new HSVColor.fromColor(const Color.fromARGB(0xFF, 0x80, 0x80, 0x80));
 
     expect(black.toColor(), equals(const Color.fromARGB(0xFF, 0x00, 0x00, 0x00)));
     expect(red.toColor(), equals(const Color.fromARGB(0xFF, 0xFF, 0x00, 0x00)));
     expect(green.toColor(), equals(const Color.fromARGB(0xFF, 0x00, 0xFF, 0x00)));
     expect(blue.toColor(), equals(const Color.fromARGB(0xFF, 0x00, 0x00, 0xFF)));
+    expect(grey.toColor(), equals(const Color.fromARGB(0xFF, 0x80, 0x80, 0x80)));
   });
 
   test('ColorSwatch test', () {