From fd44d0bb650812d72b9593003b14d485fe026e14 Mon Sep 17 00:00:00 2001 From: amirh Date: Fri, 24 Aug 2018 12:43:56 -0700 Subject: [PATCH] Update the android_views integration test to the new Android views API. (#20999) This updates the test to match the engine API change introduced in: https://github.com/flutter/engine/pull/6081 This also rolls the engine, the roll includes only the relevant engine commit: ``` 091492601 Allow passing extra creation parameters for embedded Android views. (#6081) ``` --- bin/internal/engine.version | 2 +- .../flutter/integration/androidviews/SimpleViewFactory.java | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bin/internal/engine.version b/bin/internal/engine.version index 04614a1008..a4e783bbe8 100644 --- a/bin/internal/engine.version +++ b/bin/internal/engine.version @@ -1 +1 @@ -78e74d4d18160e745d3d0cc4336259800adabc92 +091492601479a6a234c7c4c91b19b7080fabfb6b diff --git a/dev/integration_tests/android_views/android/app/src/main/java/io/flutter/integration/androidviews/SimpleViewFactory.java b/dev/integration_tests/android_views/android/app/src/main/java/io/flutter/integration/androidviews/SimpleViewFactory.java index 338e6fdd6c..bffc807e21 100644 --- a/dev/integration_tests/android_views/android/app/src/main/java/io/flutter/integration/androidviews/SimpleViewFactory.java +++ b/dev/integration_tests/android_views/android/app/src/main/java/io/flutter/integration/androidviews/SimpleViewFactory.java @@ -11,15 +11,16 @@ import io.flutter.plugin.common.MethodChannel; import io.flutter.plugin.platform.PlatformView; import io.flutter.plugin.platform.PlatformViewFactory; -public class SimpleViewFactory implements PlatformViewFactory { +public class SimpleViewFactory extends PlatformViewFactory { final BinaryMessenger messenger; public SimpleViewFactory(BinaryMessenger messenger) { + super(null); this.messenger = messenger; } @Override - public PlatformView create(Context context, int id) { + public PlatformView create(Context context, int id, Object params) { MethodChannel methodChannel = new MethodChannel(messenger, "simple_view/" + id); return new SimplePlatformView(context, methodChannel); }