From fc76fc2a9625fe1d598ff0b4a75b4c2cfdb1be63 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Fri, 17 Apr 2020 10:47:12 -0700 Subject: [PATCH] Move GitHubTemplateCreator into reporting library (#55002) --- packages/flutter_tools/lib/runner.dart | 1 - .../lib/src/reporting/github_template.dart | 18 +----------------- .../lib/src/reporting/reporting.dart | 11 +++++++++++ .../general.shard/github_template_test.dart | 2 +- .../test/general.shard/runner/runner_test.dart | 1 - packages/flutter_tools/test/src/context.dart | 1 - 6 files changed, 13 insertions(+), 21 deletions(-) diff --git a/packages/flutter_tools/lib/runner.dart b/packages/flutter_tools/lib/runner.dart index 7499e7dc69..6b94d8606c 100644 --- a/packages/flutter_tools/lib/runner.dart +++ b/packages/flutter_tools/lib/runner.dart @@ -19,7 +19,6 @@ import 'src/base/process.dart'; import 'src/context_runner.dart'; import 'src/doctor.dart'; import 'src/globals.dart' as globals; -import 'src/reporting/github_template.dart'; import 'src/reporting/reporting.dart'; import 'src/runner/flutter_command.dart'; import 'src/runner/flutter_command_runner.dart'; diff --git a/packages/flutter_tools/lib/src/reporting/github_template.dart b/packages/flutter_tools/lib/src/reporting/github_template.dart index d36821885e..376a4d272e 100644 --- a/packages/flutter_tools/lib/src/reporting/github_template.dart +++ b/packages/flutter_tools/lib/src/reporting/github_template.dart @@ -2,23 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'dart:async'; - -import 'package:file/file.dart'; -import 'package:intl/intl.dart'; -import 'package:meta/meta.dart'; - -import '../base/file_system.dart'; -import '../base/io.dart'; -import '../base/logger.dart'; -import '../base/process.dart'; -import '../build_system/exceptions.dart'; -import '../convert.dart'; -import '../devfs.dart'; -import '../flutter_manifest.dart'; -import '../flutter_project_metadata.dart'; -import '../project.dart'; -import '../version.dart'; +part of reporting; /// Provide suggested GitHub issue templates to user when Flutter encounters an error. class GitHubTemplateCreator { diff --git a/packages/flutter_tools/lib/src/reporting/reporting.dart b/packages/flutter_tools/lib/src/reporting/reporting.dart index 66a9d2a048..e583eb4eb2 100644 --- a/packages/flutter_tools/lib/src/reporting/reporting.dart +++ b/packages/flutter_tools/lib/src/reporting/reporting.dart @@ -6,20 +6,31 @@ library reporting; import 'dart:async'; +import 'package:file/file.dart'; import 'package:http/http.dart' as http; +import 'package:intl/intl.dart'; import 'package:meta/meta.dart'; import 'package:usage/usage_io.dart'; import '../base/file_system.dart'; import '../base/io.dart'; +import '../base/logger.dart'; +import '../base/process.dart'; import '../base/time.dart'; +import '../build_system/exceptions.dart'; +import '../convert.dart'; +import '../devfs.dart'; import '../doctor.dart'; import '../features.dart'; +import '../flutter_manifest.dart'; +import '../flutter_project_metadata.dart'; import '../globals.dart' as globals; +import '../project.dart'; import '../runner/flutter_command.dart'; import '../version.dart'; part 'crash_reporting.dart'; part 'disabled_usage.dart'; part 'events.dart'; +part 'github_template.dart'; part 'usage.dart'; diff --git a/packages/flutter_tools/test/general.shard/github_template_test.dart b/packages/flutter_tools/test/general.shard/github_template_test.dart index 1082d51ea3..0fb74d4c6a 100644 --- a/packages/flutter_tools/test/general.shard/github_template_test.dart +++ b/packages/flutter_tools/test/general.shard/github_template_test.dart @@ -8,7 +8,7 @@ import 'package:flutter_tools/src/base/io.dart'; import 'package:flutter_tools/src/base/logger.dart'; import 'package:flutter_tools/src/devfs.dart'; import 'package:flutter_tools/src/project.dart'; -import 'package:flutter_tools/src/reporting/github_template.dart'; +import 'package:flutter_tools/src/reporting/reporting.dart'; import '../src/common.dart'; import '../src/context.dart'; diff --git a/packages/flutter_tools/test/general.shard/runner/runner_test.dart b/packages/flutter_tools/test/general.shard/runner/runner_test.dart index 3e4d8122e6..38ff6a4714 100644 --- a/packages/flutter_tools/test/general.shard/runner/runner_test.dart +++ b/packages/flutter_tools/test/general.shard/runner/runner_test.dart @@ -11,7 +11,6 @@ import 'package:flutter_tools/src/base/io.dart' as io; import 'package:flutter_tools/src/base/common.dart'; import 'package:flutter_tools/src/cache.dart'; import 'package:flutter_tools/src/globals.dart' as globals; -import 'package:flutter_tools/src/reporting/github_template.dart'; import 'package:flutter_tools/src/reporting/reporting.dart'; import 'package:flutter_tools/src/runner/flutter_command.dart'; import 'package:mockito/mockito.dart'; diff --git a/packages/flutter_tools/test/src/context.dart b/packages/flutter_tools/test/src/context.dart index ba5948bd92..42cbec52cf 100644 --- a/packages/flutter_tools/test/src/context.dart +++ b/packages/flutter_tools/test/src/context.dart @@ -29,7 +29,6 @@ import 'package:flutter_tools/src/ios/simulators.dart'; import 'package:flutter_tools/src/ios/xcodeproj.dart'; import 'package:flutter_tools/src/persistent_tool_state.dart'; import 'package:flutter_tools/src/project.dart'; -import 'package:flutter_tools/src/reporting/github_template.dart'; import 'package:flutter_tools/src/reporting/reporting.dart'; import 'package:flutter_tools/src/version.dart'; import 'package:flutter_tools/src/globals.dart' as globals;