From fa82b9aeac1d1fabbabdca9a0a6816f678dfccf2 Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Thu, 14 Nov 2019 04:08:28 +0000 Subject: [PATCH] Updated flutter/examples to further conform to new embedding: removed references to FlutterApplication, deleted all MainActivity's that were not necessary, removed all direct invocations of GeneratedPluginRegistrant. (#22529) (#44782) --- .../android/app/src/main/AndroidManifest.xml | 10 +--- .../animated_list/MainActivity.java | 13 ----- .../android/app/src/main/AndroidManifest.xml | 8 +--- .../io/flutter/demo/gallery/MainActivity.java | 2 - .../android/app/src/main/AndroidManifest.xml | 7 +-- .../java/com/example/view/MainActivity.java | 48 +++++++++++-------- .../main/res/layout/flutter_view_layout.xml | 2 +- .../android/app/src/main/AndroidManifest.xml | 10 +--- .../examples/hello_world/MainActivity.java | 13 ----- .../android/app/src/main/AndroidManifest.xml | 10 +--- .../com/example/image_list/MainActivity.java | 13 ----- .../android/app/src/main/AndroidManifest.xml | 10 +--- .../flutter/examples/Layers/MainActivity.java | 17 ------- .../android/app/src/main/AndroidManifest.xml | 2 +- .../example/platformchannel/MainActivity.java | 2 - .../android/app/src/main/AndroidManifest.xml | 7 --- .../examples/platform_view/MainActivity.java | 2 - .../android/app/src/main/AndroidManifest.xml | 10 +--- .../flutter/examples/stocks/MainActivity.java | 17 ------- 19 files changed, 41 insertions(+), 162 deletions(-) delete mode 100644 examples/catalog/android/app/src/main/java/com/yourcompany/animated_list/MainActivity.java delete mode 100644 examples/hello_world/android/app/src/main/java/io/flutter/examples/hello_world/MainActivity.java delete mode 100644 examples/image_list/android/app/src/main/java/com/example/image_list/MainActivity.java delete mode 100644 examples/layers/android/app/src/main/java/io/flutter/examples/Layers/MainActivity.java delete mode 100644 examples/stocks/android/app/src/main/java/io/flutter/examples/stocks/MainActivity.java diff --git a/examples/catalog/android/app/src/main/AndroidManifest.xml b/examples/catalog/android/app/src/main/AndroidManifest.xml index 332f2bf364..353c810793 100644 --- a/examples/catalog/android/app/src/main/AndroidManifest.xml +++ b/examples/catalog/android/app/src/main/AndroidManifest.xml @@ -7,14 +7,8 @@ --> - - - + - - + - - + (flutterView, CHANNEL, StringCodec.INSTANCE); + messageChannel = new BasicMessageChannel<>(flutterEngine.getDartExecutor(), CHANNEL, StringCodec.INSTANCE); messageChannel. setMessageHandler(new MessageHandler() { @Override @@ -97,22 +99,26 @@ public class MainActivity extends AppCompatActivity { } @Override - protected void onDestroy() { - if (flutterView != null) { - flutterView.destroy(); - } - super.onDestroy(); + protected void onResume() { + super.onResume(); + flutterEngine.getLifecycleChannel().appIsResumed(); } @Override protected void onPause() { super.onPause(); - flutterView.onPause(); + flutterEngine.getLifecycleChannel().appIsInactive(); } @Override - protected void onPostResume() { - super.onPostResume(); - flutterView.onPostResume(); + protected void onStop() { + super.onStop(); + flutterEngine.getLifecycleChannel().appIsPaused(); + } + + @Override + protected void onDestroy() { + flutterView.detachFromFlutterEngine(); + super.onDestroy(); } } diff --git a/examples/flutter_view/android/app/src/main/res/layout/flutter_view_layout.xml b/examples/flutter_view/android/app/src/main/res/layout/flutter_view_layout.xml index e78a0a215a..e434c3dab1 100644 --- a/examples/flutter_view/android/app/src/main/res/layout/flutter_view_layout.xml +++ b/examples/flutter_view/android/app/src/main/res/layout/flutter_view_layout.xml @@ -6,7 +6,7 @@ android:layout_height="match_parent" > - - - - + - + - - - + - + - - - - +