From f685568d901ae4787259aec4a97aa7e7adb87f43 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 10 May 2018 17:45:35 -0700 Subject: [PATCH] Update a TODO with issue number (#17494) Further digging revealed that the reason --no-sim-use-hardfp was required to be specified explicitly was that Android engine gen_snapshot binaries are built on Windows with target_os=win. --- packages/flutter_tools/lib/src/base/build.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/base/build.dart b/packages/flutter_tools/lib/src/base/build.dart index 1ee8166e3b..ec3919b73b 100644 --- a/packages/flutter_tools/lib/src/base/build.dart +++ b/packages/flutter_tools/lib/src/base/build.dart @@ -224,7 +224,7 @@ class AOTSnapshotter { if (platform == TargetPlatform.android_arm || iosArch == IOSArch.armv7) { // Use softfp for Android armv7 devices. // Note that this is the default for armv7 iOS builds, but harmless to set. - // TODO(cbracken) use TargetPlatform-specific gen_snapshot for Android so that this is defaulted. + // TODO(cbracken) eliminate this when we fix https://github.com/flutter/flutter/issues/17489 genSnapshotArgs.add('--no-sim-use-hardfp'); // Not supported by the Pixel in 32-bit mode.