From f0dc0b798f9d47135c48b6404855c62ff23fa0fa Mon Sep 17 00:00:00 2001 From: Mohellebi abdessalem Date: Tue, 19 Nov 2024 21:32:05 +0100 Subject: [PATCH] fix lint usage of `task` inside `resolve_dependecies.gradle` file (#158022) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit according to [Gradle](https://docs.gradle.org/current/userguide/task_configuration_avoidance.htmll) :`As of Gradle 5.1, we recommend that the configuration avoidance APIs be used whenever tasks are created.` ![writing-tasks-4](https://github.com/user-attachments/assets/407c79bb-7bfa-4bea-9b13-dec01c60dc1c) what android studio lint is failing ? ![Capture d’écran 2024-11-01 214856](https://github.com/user-attachments/assets/af745305-6310-406c-b427-fb8a5dd5755c) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- packages/flutter_tools/gradle/resolve_dependencies.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/gradle/resolve_dependencies.gradle b/packages/flutter_tools/gradle/resolve_dependencies.gradle index 6355654f2e..65b53fdbd3 100644 --- a/packages/flutter_tools/gradle/resolve_dependencies.gradle +++ b/packages/flutter_tools/gradle/resolve_dependencies.gradle @@ -19,7 +19,7 @@ String storageUrl = System.getenv('FLUTTER_STORAGE_BASE_URL') ?: "https://storag String engineRealm = Paths.get(flutterRoot.absolutePath, "bin", "internal", "engine.realm") .toFile().text.trim() if (engineRealm) { - engineRealm = engineRealm + "/" + engineRealm += "/" } repositories { @@ -58,7 +58,7 @@ dependencies { flutterDebug "io.flutter:x86_64_debug:1.0.0-$engineVersion" } -task resolveDependencies { +tasks.register('resolveDependencies') { configurations.each { configuration -> if (configuration.name.startsWith("flutter")) { configuration.resolve()