From efda66bcff69c93cb3ea327d767926c380a75b5e Mon Sep 17 00:00:00 2001
From: Zachary Anderson <zanderso@users.noreply.github.com>
Date: Thu, 29 Feb 2024 17:27:17 +0000
Subject: [PATCH] Use RBE for mac_clang_tidy (flutter/engine#51083)

---
 .../flutter/ci/builders/mac_clang_tidy.json   | 134 ++++++++++++++++--
 1 file changed, 125 insertions(+), 9 deletions(-)

diff --git a/engine/src/flutter/ci/builders/mac_clang_tidy.json b/engine/src/flutter/ci/builders/mac_clang_tidy.json
index f30089a826..6f50c27f0e 100644
--- a/engine/src/flutter/ci/builders/mac_clang_tidy.json
+++ b/engine/src/flutter/ci/builders/mac_clang_tidy.json
@@ -7,7 +7,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "gn": [
                 "--runtime-mode",
@@ -16,7 +17,10 @@
                 "--no-lto",
                 "--force-mac-arm64",
                 "--target-dir",
-                "host_debug_clang_tidy"
+                "host_debug_clang_tidy",
+                "--rbe",
+                "--no-goma",
+                "--xcode-symlinks"
             ],
             "name": "host_debug_clang_tidy",
             "ninja": {
@@ -30,7 +34,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "gn": [
                 "--ios",
@@ -40,7 +45,10 @@
                 "--no-lto",
                 "--force-mac-arm64",
                 "--target-dir",
-                "ios_debug_sim_clang_tidy"
+                "ios_debug_sim_clang_tidy",
+                "--rbe",
+                "--no-goma",
+                "--xcode-symlinks"
             ],
             "name": "ios_debug_sim_clang_tidy",
             "ninja": {
@@ -58,7 +66,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "dependencies": [
                 "host_debug_clang_tidy"
@@ -67,6 +76,23 @@
                 "osx_sdk"
             ],
             "tasks": [
+                {
+                    "name": "gn for host_debug",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--runtime-mode",
+                        "debug",
+                        "--prebuilt-dart-sdk",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "host_debug_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
                 {
                     "name": "test: lint host_debug",
                     "parameters": [
@@ -90,7 +116,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "dependencies": [
                 "host_debug_clang_tidy"
@@ -99,6 +126,23 @@
                 "osx_sdk"
             ],
             "tasks": [
+                {
+                    "name": "gn for host_debug",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--runtime-mode",
+                        "debug",
+                        "--prebuilt-dart-sdk",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "host_debug_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
                 {
                     "name": "test: lint host_debug",
                     "parameters": [
@@ -122,7 +166,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "dependencies": [
                 "host_debug_clang_tidy"
@@ -131,6 +176,23 @@
                 "osx_sdk"
             ],
             "tasks": [
+                {
+                    "name": "gn for host_debug",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--runtime-mode",
+                        "debug",
+                        "--prebuilt-dart-sdk",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "host_debug_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
                 {
                     "name": "test: lint host_debug",
                     "parameters": [
@@ -154,7 +216,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "dependencies": [
                 "host_debug_clang_tidy"
@@ -163,6 +226,23 @@
                 "osx_sdk"
             ],
             "tasks": [
+                {
+                    "name": "gn for host_debug",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--runtime-mode",
+                        "debug",
+                        "--prebuilt-dart-sdk",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "host_debug_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
                 {
                     "name": "test: lint host_debug",
                     "parameters": [
@@ -186,7 +266,8 @@
                 "cpu=arm64"
             ],
             "gclient_variables": {
-                "download_android_deps": false
+                "download_android_deps": false,
+                "use_rbe": true
             },
             "dependencies": [
                 "host_debug_clang_tidy",
@@ -196,6 +277,41 @@
                 "osx_sdk"
             ],
             "tasks": [
+                {
+                    "name": "gn for host_debug",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--runtime-mode",
+                        "debug",
+                        "--prebuilt-dart-sdk",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "host_debug_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
+                {
+                    "name": "gn for ios_debug_sim",
+                    "langauge": "python",
+                    "script": "flutter/tools/gn",
+                    "parameters": [
+                        "--ios",
+                        "--runtime-mode",
+                        "debug",
+                        "--simulator",
+                        "--no-lto",
+                        "--force-mac-arm64",
+                        "--target-dir",
+                        "ios_debug_sim_clang_tidy",
+                        "--rbe",
+                        "--no-goma",
+                        "--xcode-symlinks"
+                    ]
+                },
                 {
                     "name": "test: lint ios_debug_sim",
                     "parameters": [