From ecb6ee02cae512e2753b19ab8539be6573653d64 Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Wed, 29 Jul 2015 16:37:02 -0700 Subject: [PATCH] Fix spurious skyanalyzer failures We need to update our regexps because we moved the mojom and mojo packages. --- engine/src/flutter/sky/tools/skyanalyzer | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/sky/tools/skyanalyzer b/engine/src/flutter/sky/tools/skyanalyzer index 08825deb4e..fa6fdf5e66 100755 --- a/engine/src/flutter/sky/tools/skyanalyzer +++ b/engine/src/flutter/sky/tools/skyanalyzer @@ -26,7 +26,7 @@ _IGNORED_PATTERNS = [ re.compile(r'^([0-9]+|No) (error|warning|issue)s? found.'), # Ignore analyzer status output. - re.compile(r'^[0-9]+ errors, [0-9]+ warnings and [0-9]+ hints found.'), + re.compile(r'^[0-9]+ errors(, [0-9]+ warnings)? and [0-9]+ hints found.'), # Ignored because they don't affect Sky code re.compile(r'\[hint\] When compiled to JS, this test might return true when the left hand side is an int'), @@ -35,8 +35,8 @@ _IGNORED_PATTERNS = [ re.compile(r'^\[error\] Native functions can only be declared in'), # TODO: Fix all the warnings in the mojo packages - re.compile(r'.*/dart-pkg/mojom/'), - re.compile(r'.*/dart-pkg/mojo/'), + re.compile(r'.*dart-pub-cache.*/mojom-'), + re.compile(r'.*dart-pub-cache.*/mojo-'), re.compile(r'.*/mojo/public/dart/'), # TODO: Remove this once Sky no longer generates this warning.