From eb4cc7f8e9b337ff8ac467e1768b27ab69e4b2ae Mon Sep 17 00:00:00 2001 From: Mikkel Nygaard Ravn Date: Sun, 9 Apr 2017 00:34:43 +0200 Subject: [PATCH] Update unit test to also handle null and zero-byte message differently (flutter/engine#3579) --- .../darwin/ios/framework/Source/flutter_codecs_unittest.mm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/flutter_codecs_unittest.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/flutter_codecs_unittest.mm index 44e654917a..6f26ca8524 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/flutter_codecs_unittest.mm +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/flutter_codecs_unittest.mm @@ -13,8 +13,8 @@ TEST(FlutterStringCodec, CanEncodeAndDecodeNil) { TEST(FlutterStringCodec, CanEncodeAndDecodeEmptyString) { FlutterStringCodec* codec = [FlutterStringCodec sharedInstance]; - ASSERT_TRUE([codec encode:@""] == nil); - ASSERT_TRUE([codec decode:[NSData data]] == nil); + ASSERT_TRUE([[codec encode:@""] isEqualTo:[NSData data]]); + ASSERT_TRUE([[codec decode:[NSData data]] isEqualTo:@""]); } TEST(FlutterStringCodec, CanEncodeAndDecodeAsciiString) { @@ -42,10 +42,9 @@ TEST(FlutterStringCodec, CanEncodeAndDecodeNonBMPString) { } TEST(FlutterJSONCodec, CanEncodeAndDecodeNil) { - FlutterStringCodec* codec = [FlutterStringCodec sharedInstance]; + FlutterJSONMessageCodec* codec = [FlutterJSONMessageCodec sharedInstance]; ASSERT_TRUE([codec encode:nil] == nil); ASSERT_TRUE([codec decode:nil] == nil); - ASSERT_TRUE([codec decode:[NSData data]] == nil); } TEST(FlutterJSONCodec, CanEncodeAndDecodeArray) {