From e8b7889dfde8e65c8be4f1006d4624e7380149a7 Mon Sep 17 00:00:00 2001 From: Kate Lovett Date: Fri, 19 May 2023 14:40:51 -0500 Subject: [PATCH] Remove deprecated OverscrollIndicatorNotification.disallowGlow (#127050) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The deprecated OverscrollIndicatorNotification.disallowGlow has expired and is removed in the PR. The replacement is OverscrollIndicatorNotification.disallowIndicator. This deprecation was introduced in https://github.com/flutter/flutter/pull/87839 when the StretchingOverscrollIndicator was added. The name change made it clearer since there is now more than one overscroll indicator. This change is supported by dart fix. ✅ Part of https://github.com/flutter/flutter/issues/127042 --- .../lib/src/widgets/overscroll_indicator.dart | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/flutter/lib/src/widgets/overscroll_indicator.dart b/packages/flutter/lib/src/widgets/overscroll_indicator.dart index c2843d267f..1ae41dd5e2 100644 --- a/packages/flutter/lib/src/widgets/overscroll_indicator.dart +++ b/packages/flutter/lib/src/widgets/overscroll_indicator.dart @@ -26,8 +26,8 @@ import 'transitions.dart'; /// /// [GlowingOverscrollIndicator] generates [OverscrollIndicatorNotification] /// before showing an overscroll indication. To prevent the indicator from -/// showing the indication, call [OverscrollIndicatorNotification.disallowGlow] -/// on the notification. +/// showing the indication, call +/// [OverscrollIndicatorNotification.disallowIndicator] on the notification. /// /// Created automatically by [ScrollBehavior.buildOverscrollIndicator] on platforms /// (e.g., Android) that commonly use this type of overscroll indication. @@ -999,16 +999,6 @@ class OverscrollIndicatorNotification extends Notification with ViewportNotifica /// Defaults to true, cannot be null. bool accepted = true; - /// Call this method if the glow should be prevented. This method is - /// deprecated in favor of [disallowIndicator]. - @Deprecated( - 'Use disallowIndicator instead. ' - 'This feature was deprecated after v2.5.0-6.0.pre.', - ) - void disallowGlow() { - accepted = false; - } - /// Call this method if the overscroll indicator should be prevented. void disallowIndicator() { accepted = false;