From e6f69add99bfba88eadf398bee4241a4f541e177 Mon Sep 17 00:00:00 2001 From: Anurag Roy Date: Wed, 13 Jul 2022 02:01:07 +0530 Subject: [PATCH] [flutter_tools] Replace android v2 embedding broken doc link (#107456) --- packages/flutter_tools/lib/src/flutter_plugins.dart | 2 +- packages/flutter_tools/lib/src/project.dart | 2 +- .../test/commands.shard/permeable/create_test.dart | 2 +- .../flutter_tools/test/general.shard/plugins_test.dart | 2 +- .../flutter_tools/test/general.shard/project_test.dart | 10 +++++----- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/flutter_tools/lib/src/flutter_plugins.dart b/packages/flutter_tools/lib/src/flutter_plugins.dart index 8e7962e7a8..aaa7e2ef9d 100644 --- a/packages/flutter_tools/lib/src/flutter_plugins.dart +++ b/packages/flutter_tools/lib/src/flutter_plugins.dart @@ -436,7 +436,7 @@ Future _writeAndroidPluginRegistrant(FlutterProject project, List if (!supportsEmbeddingV1 && supportsEmbeddingV2) { throwToolExit( 'The plugin `${plugin['name']}` requires your app to be migrated to ' - 'the Android embedding v2. Follow the steps on https://flutter.dev/go/android-project-migration ' + 'the Android embedding v2. Follow the steps on the migration doc above ' 'and re-run this command.' ); } diff --git a/packages/flutter_tools/lib/src/project.dart b/packages/flutter_tools/lib/src/project.dart index 813a4698c6..09fbd6bb3a 100644 --- a/packages/flutter_tools/lib/src/project.dart +++ b/packages/flutter_tools/lib/src/project.dart @@ -602,7 +602,7 @@ Your Flutter application is created using an older version of the Android embedding. It is being deprecated in favor of Android embedding v2. Follow the steps at -https://flutter.dev/go/android-project-migration +https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects to migrate your project. You may also pass the --ignore-deprecation flag to ignore this check and continue with the deprecated v1 embedding. However, diff --git a/packages/flutter_tools/test/commands.shard/permeable/create_test.dart b/packages/flutter_tools/test/commands.shard/permeable/create_test.dart index e74ebf17c1..2fadb6b5e3 100644 --- a/packages/flutter_tools/test/commands.shard/permeable/create_test.dart +++ b/packages/flutter_tools/test/commands.shard/permeable/create_test.dart @@ -786,7 +786,7 @@ void main() { // Import for the new embedding class. expect(mainActivity.contains('import io.flutter.embedding.android.FlutterActivity'), true); - expect(logger.statusText, isNot(contains('https://flutter.dev/go/android-project-migration'))); + expect(logger.statusText, isNot(contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects'))); }, overrides: { Logger: () => logger, }); diff --git a/packages/flutter_tools/test/general.shard/plugins_test.dart b/packages/flutter_tools/test/general.shard/plugins_test.dart index 7de3ab4871..588ace6889 100644 --- a/packages/flutter_tools/test/general.shard/plugins_test.dart +++ b/packages/flutter_tools/test/general.shard/plugins_test.dart @@ -762,7 +762,7 @@ dependencies: }, throwsToolExit( message: 'The plugin `plugin1` requires your app to be migrated to the Android embedding v2. ' - 'Follow the steps on https://flutter.dev/go/android-project-migration and re-run this command.' + 'Follow the steps on the migration doc above and re-run this command.' ), ); }, overrides: { diff --git a/packages/flutter_tools/test/general.shard/project_test.dart b/packages/flutter_tools/test/general.shard/project_test.dart index cdef67bf82..a4bd7bbf53 100644 --- a/packages/flutter_tools/test/general.shard/project_test.dart +++ b/packages/flutter_tools/test/general.shard/project_test.dart @@ -195,7 +195,7 @@ void main() { // android:name="flutterEmbedding" android:value="2" />. project.checkForDeprecation(deprecationBehavior: DeprecationBehavior.ignore); - expect(testLogger.statusText, contains('https://flutter.dev/go/android-project-migration')); + expect(testLogger.statusText, contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects')); }); _testInMemory('Android project not on v2 embedding exits', () async { final FlutterProject project = await someProject(); @@ -207,7 +207,7 @@ void main() { Future.sync(() => project.checkForDeprecation(deprecationBehavior: DeprecationBehavior.exit)), contains('Build failed due to use of deprecated Android v1 embedding.') ); - expect(testLogger.statusText, contains('https://flutter.dev/go/android-project-migration')); + expect(testLogger.statusText, contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects')); expect(testLogger.statusText, contains('No `` in ')); }); _testInMemory('Project not on v2 embedding does not warn if deprecation status is irrelevant', () async { @@ -226,13 +226,13 @@ void main() { // android:name="flutterEmbedding" android:value="2" />. project.checkForDeprecation(deprecationBehavior: DeprecationBehavior.ignore); - expect(testLogger.statusText, contains('https://flutter.dev/go/android-project-migration')); + expect(testLogger.statusText, contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects')); }); _testInMemory('Android plugin project does not throw v1 embedding deprecation warning', () async { final FlutterProject project = await aPluginProject(); project.checkForDeprecation(deprecationBehavior: DeprecationBehavior.exit); - expect(testLogger.statusText, isNot(contains('https://flutter.dev/go/android-project-migration'))); + expect(testLogger.statusText, isNot(contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects'))); expect(testLogger.statusText, isNot(contains('No `` in '))); }); _testInMemory('Android plugin without example app does not show a warning', () async { @@ -240,7 +240,7 @@ void main() { project.example.directory.deleteSync(); await project.regeneratePlatformSpecificTooling(); - expect(testLogger.statusText, isNot(contains('https://flutter.dev/go/android-project-migration'))); + expect(testLogger.statusText, isNot(contains('https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects'))); }); _testInMemory('updates local properties for Android', () async { final FlutterProject project = await someProject();