From e69a8a15b38d497476748fe50bcb92dbbd8f06e3 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 18 Apr 2019 15:03:34 -0700 Subject: [PATCH] pass track widget creation flag through to build script (#31277) --- packages/flutter_tools/lib/src/commands/build_linux.dart | 1 + packages/flutter_tools/lib/src/commands/build_windows.dart | 1 + packages/flutter_tools/lib/src/macos/build_macos.dart | 1 + packages/flutter_tools/test/commands/build_linux_test.dart | 4 +++- packages/flutter_tools/test/commands/build_macos_test.dart | 1 + packages/flutter_tools/test/commands/build_windows_test.dart | 1 + 6 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/commands/build_linux.dart b/packages/flutter_tools/lib/src/commands/build_linux.dart index 29346dbd8a..a8326822a7 100644 --- a/packages/flutter_tools/lib/src/commands/build_linux.dart +++ b/packages/flutter_tools/lib/src/commands/build_linux.dart @@ -66,6 +66,7 @@ class BuildLinuxCommand extends BuildSubCommand { flutterProject.linux.buildScript.path, Cache.flutterRoot, buildInfo.isDebug ? 'debug' : 'release', + buildInfo?.trackWidgetCreation == true ? 'track-widget-creation' : 'no-track-widget-creation', ], runInShell: true); process.stderr .transform(utf8.decoder) diff --git a/packages/flutter_tools/lib/src/commands/build_windows.dart b/packages/flutter_tools/lib/src/commands/build_windows.dart index 4a53a6688a..a8d17406ca 100644 --- a/packages/flutter_tools/lib/src/commands/build_windows.dart +++ b/packages/flutter_tools/lib/src/commands/build_windows.dart @@ -66,6 +66,7 @@ class BuildWindowsCommand extends BuildSubCommand { flutterProject.windows.buildScript.path, Cache.flutterRoot, buildInfo.isDebug ? 'debug' : 'release', + buildInfo?.trackWidgetCreation == true ? 'track-widget-creation' : 'no-track-widget-creation', ], runInShell: true); process.stderr .transform(utf8.decoder) diff --git a/packages/flutter_tools/lib/src/macos/build_macos.dart b/packages/flutter_tools/lib/src/macos/build_macos.dart index 8ec7a61d32..4c149be968 100644 --- a/packages/flutter_tools/lib/src/macos/build_macos.dart +++ b/packages/flutter_tools/lib/src/macos/build_macos.dart @@ -18,6 +18,7 @@ Future buildMacOS(FlutterProject flutterProject, BuildInfo buildInfo) asyn flutterProject.macos.buildScript.path, Cache.flutterRoot, buildInfo?.isDebug == true ? 'debug' : 'release', + buildInfo?.trackWidgetCreation == true ? 'track-widget-creation' : 'no-track-widget-creation', ], runInShell: true); final Status status = logger.startProgress( 'Building macOS application...', diff --git a/packages/flutter_tools/test/commands/build_linux_test.dart b/packages/flutter_tools/test/commands/build_linux_test.dart index c8131a9414..4dd5a464b6 100644 --- a/packages/flutter_tools/test/commands/build_linux_test.dart +++ b/packages/flutter_tools/test/commands/build_linux_test.dart @@ -59,6 +59,7 @@ void main() { ), throwsA(isInstanceOf())); }, overrides: { Platform: () => notLinuxPlatform, + FileSystem: () => memoryFilesystem, }); testUsingContext('Linux build invokes build script', () async { @@ -70,7 +71,8 @@ void main() { when(mockProcessManager.start([ '/linux/build.sh', '/', - 'release' + 'release', + 'no-track-widget-creation', ], runInShell: true)).thenAnswer((Invocation invocation) async { return mockProcess; }); diff --git a/packages/flutter_tools/test/commands/build_macos_test.dart b/packages/flutter_tools/test/commands/build_macos_test.dart index 164858f7c3..df55f6cabd 100644 --- a/packages/flutter_tools/test/commands/build_macos_test.dart +++ b/packages/flutter_tools/test/commands/build_macos_test.dart @@ -71,6 +71,7 @@ void main() { '/macos/build.sh', '/', 'release', + 'no-track-widget-creation', ], runInShell: true)).thenAnswer((Invocation invocation) async { return mockProcess; }); diff --git a/packages/flutter_tools/test/commands/build_windows_test.dart b/packages/flutter_tools/test/commands/build_windows_test.dart index e5d98fcf25..3fabf9f303 100644 --- a/packages/flutter_tools/test/commands/build_windows_test.dart +++ b/packages/flutter_tools/test/commands/build_windows_test.dart @@ -72,6 +72,7 @@ void main() { r'C:\windows\build.bat', r'C:\', 'release', + 'no-track-widget-creation', ], runInShell: true)).thenAnswer((Invocation invocation) async { return mockProcess; });