From e05ae3cac799b26c36405f8bfdda2a15c2298b68 Mon Sep 17 00:00:00 2001 From: Polina Cherkasova Date: Tue, 26 Jul 2022 10:43:46 -0700 Subject: [PATCH] Dispose widgets to stop leaks. (#108193) --- packages/flutter/lib/src/material/ink_well.dart | 1 + packages/flutter/lib/src/widgets/scroll_position.dart | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/flutter/lib/src/material/ink_well.dart b/packages/flutter/lib/src/material/ink_well.dart index 29dfe58d5b..1f93c8600d 100644 --- a/packages/flutter/lib/src/material/ink_well.dart +++ b/packages/flutter/lib/src/material/ink_well.dart @@ -847,6 +847,7 @@ class _InkResponseState extends State<_InkResponseStateWidget> void dispose() { FocusManager.instance.removeHighlightModeListener(handleFocusHighlightModeChange); statesController.removeListener(handleStatesControllerChange); + internalStatesController?.dispose(); super.dispose(); } diff --git a/packages/flutter/lib/src/widgets/scroll_position.dart b/packages/flutter/lib/src/widgets/scroll_position.dart index 88b612d695..412179b0da 100644 --- a/packages/flutter/lib/src/widgets/scroll_position.dart +++ b/packages/flutter/lib/src/widgets/scroll_position.dart @@ -976,6 +976,7 @@ abstract class ScrollPosition extends ViewportOffset with ScrollMetrics { void dispose() { activity?.dispose(); // it will be null if it got absorbed by another ScrollPosition _activity = null; + isScrollingNotifier.dispose(); super.dispose(); }