From df719bde8d0336c3548b3ec853df6de2fbcc5edc Mon Sep 17 00:00:00 2001 From: Hixie Date: Mon, 5 Oct 2015 15:52:36 -0700 Subject: [PATCH] Fix Focus Focus.at() and company should be on Focus, not FocusState. _notifyDescendants() was using the wrong runtimeType. Let InheritedWidget update the descendants during build. When you setState() during build, assert that you're not markNeedsBuild()ing someone who isn't a descendant. Typo in Widget.toString(). --- .../flutter/examples/address_book/lib/main.dart | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/engine/src/flutter/examples/address_book/lib/main.dart b/engine/src/flutter/examples/address_book/lib/main.dart index 2bca9be10f..26c0e4aefa 100644 --- a/engine/src/flutter/examples/address_book/lib/main.dart +++ b/engine/src/flutter/examples/address_book/lib/main.dart @@ -53,14 +53,12 @@ class AddressBookHome extends StatelessComponent { ); } - static final GlobalKey nameKey = new GlobalKey(); - static final GlobalKey phoneKey = new GlobalKey(); - static final GlobalKey emailKey = new GlobalKey(); - static final GlobalKey addressKey = new GlobalKey(); - static final GlobalKey ringtoneKey = new GlobalKey(); - static final GlobalKey noteKey = new GlobalKey(); - static final GlobalKey fillKey = new GlobalKey(); - static final GlobalKey emoticonKey = new GlobalKey(); + static final GlobalKey nameKey = new GlobalKey(label: 'name field'); + static final GlobalKey phoneKey = new GlobalKey(label: 'phone field'); + static final GlobalKey emailKey = new GlobalKey(label: 'email field'); + static final GlobalKey addressKey = new GlobalKey(label: 'address field'); + static final GlobalKey ringtoneKey = new GlobalKey(label: 'ringtone field'); + static final GlobalKey noteKey = new GlobalKey(label: 'note field'); Widget buildBody(BuildContext context) { return new Material(