From dc0147d3d3fbb684770f38e323a617dbcae97885 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Mon, 7 Aug 2023 18:38:03 -0400 Subject: [PATCH] [web] Silence `pub get` when it's successful (flutter/engine#44445) In the spirit of keeping the happy path's output as clean as possible, let's hide the many lines printed by `pub get` even when it's successful. If `pub get` fails, its output will be printed on the terminal. --- engine/src/flutter/lib/web_ui/dev/felt | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/lib/web_ui/dev/felt b/engine/src/flutter/lib/web_ui/dev/felt index 2123792ad6..00062b705b 100755 --- a/engine/src/flutter/lib/web_ui/dev/felt +++ b/engine/src/flutter/lib/web_ui/dev/felt @@ -64,10 +64,24 @@ then FELT_DEBUG_FLAGS="--enable-vm-service --pause-isolates-on-start" fi +SILENT_LOG=/tmp/felt_pub_get_silent_log.txt +trap "rm -f $SILENT_LOG" EXIT + +verbose_on_failure() { + echo "FAILED with the following output:" + cat $SILENT_LOG + exit 1 +} + +silent_on_success() { + COMMAND=${1+"$@"} + $COMMAND > $SILENT_LOG 2>&1 || verbose_on_failure +} + install_deps() { # We need to run pub get here before we actually invoke felt. echo "Running \`dart pub get\` in 'engine/src/flutter/lib/web_ui'" - (cd "$WEB_UI_DIR"; $DART_PATH pub get) + (cd "$WEB_UI_DIR"; silent_on_success $DART_PATH pub get) } if [[ $KERNEL_NAME == *"Darwin"* ]]