From daea6e00bfc0452cbd3b1c46f3dd2d41a05da0a7 Mon Sep 17 00:00:00 2001 From: Jacob MacDonald Date: Thu, 21 Sep 2023 15:02:12 -0700 Subject: [PATCH] remove field override, assign to super field instead (#135165) Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class. Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint). --- .../test/commands.shard/hermetic/run_test.dart | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart index ca7564e59e..2a5a644a85 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart @@ -1335,13 +1335,10 @@ class FakeIOSDevice extends Fake implements IOSDevice { class TestRunCommandForUsageValues extends RunCommand { TestRunCommandForUsageValues({ - this.devices, - }); - - @override - // devices is not set within usageValues, so we override the field - // ignore: overridden_fields - List? devices; + List? devices, + }) { + this.devices = devices; + } @override Future getBuildInfo({ BuildMode? forcedBuildMode, File? forcedTargetFile }) async {