From d518bd2dc863632fa6382a792551785fed9f4ec7 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Tue, 20 Mar 2018 21:05:28 -0700 Subject: [PATCH] Pass shadowColor param to SceneBuilder (#15714) * pass shadowColor param to SceneBuilder * add doc comment and diagnostic node for shadowColor * Add missing shadowColor param --- packages/flutter/lib/src/rendering/layer.dart | 8 +++++++- packages/flutter/lib/src/rendering/proxy_box.dart | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/rendering/layer.dart b/packages/flutter/lib/src/rendering/layer.dart index 01c88ad8c5..386c90e423 100644 --- a/packages/flutter/lib/src/rendering/layer.dart +++ b/packages/flutter/lib/src/rendering/layer.dart @@ -764,9 +764,11 @@ class PhysicalModelLayer extends ContainerLayer { @required this.clipPath, @required this.elevation, @required this.color, + @required this.shadowColor, }) : assert(clipPath != null), assert(elevation != null), - assert(color != null); + assert(color != null), + assert(shadowColor != null); /// The path to clip in the parent's coordinate system. /// @@ -786,6 +788,9 @@ class PhysicalModelLayer extends ContainerLayer { /// (as described at [Layer]). Color color; + /// The shadow color. + Color shadowColor; + @override void addToScene(ui.SceneBuilder builder, Offset layerOffset) { if (!debugDisablePhysicalShapeLayers) @@ -793,6 +798,7 @@ class PhysicalModelLayer extends ContainerLayer { path: clipPath.shift(layerOffset), elevation: elevation, color: color, + shadowColor: shadowColor, ); addChildrenToScene(builder, layerOffset); if (!debugDisablePhysicalShapeLayers) diff --git a/packages/flutter/lib/src/rendering/proxy_box.dart b/packages/flutter/lib/src/rendering/proxy_box.dart index eb74c2cf04..905b38d29a 100644 --- a/packages/flutter/lib/src/rendering/proxy_box.dart +++ b/packages/flutter/lib/src/rendering/proxy_box.dart @@ -1495,6 +1495,7 @@ abstract class _RenderPhysicalModelBase extends _RenderCustomClip { super.debugFillProperties(description); description.add(new DoubleProperty('elevation', elevation)); description.add(new DiagnosticsProperty('color', color)); + description.add(new DiagnosticsProperty('shadowColor', color)); } } @@ -1596,6 +1597,7 @@ class RenderPhysicalModel extends _RenderPhysicalModelBase { clipPath: offsetClipPath, elevation: elevation, color: color, + shadowColor: shadowColor, ); context.pushLayer(physicalModel, super.paint, offset, childPaintBounds: offsetBounds); } else { @@ -1702,6 +1704,7 @@ class RenderPhysicalShape extends _RenderPhysicalModelBase { clipPath: offsetPath, elevation: elevation, color: color, + shadowColor: shadowColor, ); context.pushLayer(physicalModel, super.paint, offset, childPaintBounds: offsetBounds); } else {