From cbe5184edf9d85c41961cd00a464155ad8a3f023 Mon Sep 17 00:00:00 2001 From: Jonny Wang Date: Thu, 30 May 2024 11:26:47 -0700 Subject: [PATCH] Fuchsia api level 18 (flutter/engine#53115) b/335285098 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- engine/src/flutter/build/config/fuchsia/gn_configs.gni | 2 +- .../src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/src/flutter/build/config/fuchsia/gn_configs.gni b/engine/src/flutter/build/config/fuchsia/gn_configs.gni index 627e1cd29d..5f04aa7aca 100644 --- a/engine/src/flutter/build/config/fuchsia/gn_configs.gni +++ b/engine/src/flutter/build/config/fuchsia/gn_configs.gni @@ -25,7 +25,7 @@ declare_args() { # value to specify the API level the packages produced from this repository # should be targeting, e.g. in their top-level //.gn file. A value of -1 # means that no API level will be passed to the tools that consumes it. -fuchsia_target_api_level = 17 +fuchsia_target_api_level = 18 # The SDK manifest file. This is useful to include as a dependency # for some targets in order to cause a rebuild when the version of the diff --git a/engine/src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py b/engine/src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py index f5fcf879e8..316b867808 100755 --- a/engine/src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py +++ b/engine/src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py @@ -11,7 +11,7 @@ class BuildFuchsiaArtifactsTest(unittest.TestCase): # It's expected to update this test each time the fuchsia_target_api_level # in //flutter/build/config/fuchsia/gn_configs.gni is changed, so we don't # accidentally publish the artifacts with an incorrect api level suffix. - self.assertEqual(build_fuchsia_artifacts.ReadTargetAPILevel(), '17') + self.assertEqual(build_fuchsia_artifacts.ReadTargetAPILevel(), '18') if __name__ == '__main__':