From cbd9e7a1fa94202fda71f785eb8be0c44d61d56a Mon Sep 17 00:00:00 2001 From: Victoria Ashworth <15619084+vashworth@users.noreply.github.com> Date: Fri, 17 Nov 2023 10:08:02 -0600 Subject: [PATCH] Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139) Renable test now that https://github.com/flutter/flutter/issues/138193 is fixed. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- engine/src/flutter/testing/scenario_app/run_ios_tests.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/engine/src/flutter/testing/scenario_app/run_ios_tests.sh b/engine/src/flutter/testing/scenario_app/run_ios_tests.sh index 8ac15c6db1..772ea3b962 100755 --- a/engine/src/flutter/testing/scenario_app/run_ios_tests.sh +++ b/engine/src/flutter/testing/scenario_app/run_ios_tests.sh @@ -61,15 +61,12 @@ zip_and_upload_xcresult_to_luci () { echo "Running simulator tests with Skia" echo "" -# TODO(vashworth): Stop skipping testMultiplePlatformViewsWithOverlays once -# https://github.com/flutter/flutter/issues/138193 is resolved if set -o pipefail && xcodebuild -sdk iphonesimulator \ -scheme Scenarios \ -resultBundlePath "$RESULT_BUNDLE_PATH/ios_scenario.xcresult" \ -destination 'platform=iOS Simulator,OS=16.2,name=iPhone SE (3rd generation)' \ clean test \ - FLUTTER_ENGINE="$FLUTTER_ENGINE" \ - -skip-testing ScenariosUITests/UnobstructedPlatformViewTests/testMultiplePlatformViewsWithOverlays; then + FLUTTER_ENGINE="$FLUTTER_ENGINE"; then echo "test success." else echo "test failed."