firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reverts "Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)" (#145228)

Browse Source 
Reverts: flutter/flutter#145224
Initiated by: hellohuanlin
Reason for reverting: breaks the tree
Original PR Author: hellohuanlin

Reviewed By: {gmackall, jmagman}

This change reverts the following previous change:
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
This commit is contained in:
auto-submit[bot]
2024-03-15 20:09:18 +00:00
committed by GitHub
parent c770ca7e0c
commit ca2d4865cf
19 changed files with 33 additions and 556 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dev/devicelab/bin/tasks/platform_views_scroll_perf_ad_banners__timeline_summary.dart
View File

@@ -1,12 +0,0 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/perf_tests.dart';
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.ios;
await task(createUiKitViewScrollPerfAdBannersTest(enableImpeller: true));
}

11
dev/devicelab/lib/tasks/perf_tests.dart
View File

@@ -63,17 +63,6 @@ TaskFunction createUiKitViewScrollPerfTest({bool? enableImpeller}) {
).run;
}
TaskFunction createUiKitViewScrollPerfAdBannersTest({bool? enableImpeller}) {
return PerfTest(
'${flutterDirectory.path}/dev/benchmarks/platform_views_layout',
'test_driver/uikit_view_scroll_perf_ad_banners.dart',
'platform_views_scroll_perf_ad_banners',
testDriver: 'test_driver/scroll_perf_ad_banners_test.dart',
needsFullTimeline: false,
enableImpeller: enableImpeller,
).run;
}
TaskFunction createUiKitViewScrollPerfNonIntersectingTest({bool? enableImpeller}) {
return PerfTest(
'${flutterDirectory.path}/dev/benchmarks/platform_views_layout',