From c68c971e4c802bc6c7ebe1da3d4712e88009913a Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 31 Mar 2025 17:41:49 -0700 Subject: [PATCH] [android_engine_test] disable old HC mode tests. (#166293) Fixes https://github.com/flutter/flutter/issues/165032 These tests are flaky due to existing bugs in old HC mode. --- ...d_composition_platform_view_main_test.dart | 56 +++++++++++-------- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/dev/integration_tests/android_engine_test/test_driver/platform_view/hybrid_composition_platform_view_main_test.dart b/dev/integration_tests/android_engine_test/test_driver/platform_view/hybrid_composition_platform_view_main_test.dart index 9b04fa99b2..7f6097f6af 100644 --- a/dev/integration_tests/android_engine_test/test_driver/platform_view/hybrid_composition_platform_view_main_test.dart +++ b/dev/integration_tests/android_engine_test/test_driver/platform_view/hybrid_composition_platform_view_main_test.dart @@ -44,29 +44,39 @@ void main() async { await flutterDriver.close(); }); - test('should screenshot and match a blue -> orange gradient', () async { - // TODO(matanlurey): Determining if this is a failure (the screen is always black on CI) - // or timing dependent (if we would have waited X more seconds it would have rendered). - // See: - // - Vulkan: https://github.com/flutter/flutter/issues/162362 - // - OpenGLES: https://github.com/flutter/flutter/issues/162363 - await expectLater( - nativeDriver.screenshot(), - matchesGoldenFileWithRetries('$goldenPrefix.blue_orange_gradient_portrait.png'), - ); - }, timeout: Timeout.none); + test( + 'should screenshot and match a blue -> orange gradient', + () async { + // TODO(matanlurey): Determining if this is a failure (the screen is always black on CI) + // or timing dependent (if we would have waited X more seconds it would have rendered). + // See: + // - Vulkan: https://github.com/flutter/flutter/issues/162362 + // - OpenGLES: https://github.com/flutter/flutter/issues/162363 + await expectLater( + nativeDriver.screenshot(), + matchesGoldenFileWithRetries('$goldenPrefix.blue_orange_gradient_portrait.png'), + ); + }, + timeout: Timeout.none, + skip: true, // 'https://github.com/flutter/flutter/issues/165032' + ); - test('should rotate landscape and screenshot the gradient', () async { - await nativeDriver.rotateToLandscape(); - await expectLater( - nativeDriver.screenshot(), - matchesGoldenFile('$goldenPrefix.blue_orange_gradient_landscape_rotated.png'), - ); + test( + 'should rotate landscape and screenshot the gradient', + () async { + await nativeDriver.rotateToLandscape(); + await expectLater( + nativeDriver.screenshot(), + matchesGoldenFile('$goldenPrefix.blue_orange_gradient_landscape_rotated.png'), + ); - await nativeDriver.rotateResetDefault(); - await expectLater( - nativeDriver.screenshot(), - matchesGoldenFile('$goldenPrefix.blue_orange_gradient_portait_rotated_back.png'), - ); - }, timeout: Timeout.none); + await nativeDriver.rotateResetDefault(); + await expectLater( + nativeDriver.screenshot(), + matchesGoldenFile('$goldenPrefix.blue_orange_gradient_portait_rotated_back.png'), + ); + }, + timeout: Timeout.none, + skip: true, // https://github.com/flutter/flutter/issues/165032 + ); }