diff --git a/analysis_options.yaml b/analysis_options.yaml index 415aee1b1d..01199cb8d3 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -70,7 +70,7 @@ linter: # - avoid_setters_without_getters # not yet tested - avoid_slow_async_io # - avoid_types_on_closure_parameters # conflicts with always_specify_types - # - avoid_unused_constructor_parameters # not yet tested + # - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847 - await_only_futures - camel_case_types - cancel_subscriptions diff --git a/analysis_options_repo.yaml b/analysis_options_repo.yaml index fbde9c055d..594bb193f0 100644 --- a/analysis_options_repo.yaml +++ b/analysis_options_repo.yaml @@ -63,7 +63,7 @@ linter: # - avoid_setters_without_getters # not yet tested - avoid_slow_async_io # - avoid_types_on_closure_parameters # conflicts with always_specify_types - # - avoid_unused_constructor_parameters # not yet tested + # - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847 - await_only_futures - camel_case_types - cancel_subscriptions diff --git a/packages/flutter/lib/src/foundation/diagnostics.dart b/packages/flutter/lib/src/foundation/diagnostics.dart index 68a545ed75..14bfe96085 100644 --- a/packages/flutter/lib/src/foundation/diagnostics.dart +++ b/packages/flutter/lib/src/foundation/diagnostics.dart @@ -1955,7 +1955,6 @@ class DiagnosticableNode extends DiagnosticsNode { String name, @required this.value, @required DiagnosticsTreeStyle style, - String emptyBodyDescription, }) : assert(value != null), super( name: name, diff --git a/packages/flutter/lib/src/rendering/editable.dart b/packages/flutter/lib/src/rendering/editable.dart index 7e3d7fb843..89a3b0104e 100644 --- a/packages/flutter/lib/src/rendering/editable.dart +++ b/packages/flutter/lib/src/rendering/editable.dart @@ -127,6 +127,7 @@ class RenderEditable extends RenderBox { _showCursor = showCursor ?? new ValueNotifier(false), _hasFocus = hasFocus ?? false, _maxLines = maxLines, + _selectionColor = selectionColor, _selection = selection, _offset = offset { assert(_showCursor != null);