From c22b7f697fc8758a751e8bab76c6feb260cc97d4 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 4 Aug 2022 09:59:57 -0700 Subject: [PATCH] Add avoid_redundant_argument_values ignores back (#108984) --- .../hermetic/custom_devices_test.dart | 12 ++--- .../general.shard/web/devfs_web_test.dart | 44 +++++++++---------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart index 96ed7ceb1c..3a3f057c01 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart @@ -547,7 +547,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: const [ 'scp', '-r', @@ -637,7 +637,7 @@ void main() { '-w', '1', '192.168.178.1', ], - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: const [ 'scp', '-r', @@ -727,7 +727,7 @@ void main() { '-w', '1', '::1', ], - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: const [ 'scp', '-r', @@ -821,7 +821,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: [ 'scp', '-r', @@ -901,7 +901,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: const [ 'scp', '-r', @@ -1226,7 +1226,7 @@ void main() { 'testhostname', ], pingSuccessRegex: RegExp(r'[<=]\d+ms'), - postBuildCommand: null, + postBuildCommand: null, // ignore: avoid_redundant_argument_values installCommand: const [ 'scp', '-r', diff --git a/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart b/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart index c27712af1d..5562c7b9df 100644 --- a/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart +++ b/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart @@ -68,10 +68,10 @@ void main() { ); releaseAssetServer = ReleaseAssetServer( globals.fs.file('main.dart').uri, - fileSystem: null, - flutterRoot: null, - platform: null, - webBuildDirectory: null, + fileSystem: null, // ignore: avoid_redundant_argument_values + flutterRoot: null, // ignore: avoid_redundant_argument_values + platform: null, // ignore: avoid_redundant_argument_values + webBuildDirectory: null, // ignore: avoid_redundant_argument_values basePath: null, ); }, overrides: { @@ -662,7 +662,7 @@ void main() { hostname: 'localhost', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -678,8 +678,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullSafetyMode: NullSafetyMode.unsound, ); webDevFS.requireJS.createSync(recursive: true); @@ -775,7 +775,7 @@ void main() { hostname: 'localhost', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -790,8 +790,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -881,7 +881,7 @@ void main() { hostname: 'any', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -890,8 +890,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullAssertions: true, nativeNullAssertions: true, nullSafetyMode: NullSafetyMode.sound, @@ -916,7 +916,7 @@ void main() { hostname: 'localhost', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -934,8 +934,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -959,7 +959,7 @@ void main() { hostname: 'localhost', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -977,8 +977,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -1069,7 +1069,7 @@ void main() { hostname: 'localhost', port: 0, packagesFilePath: '.packages', - urlTunneller: null, + urlTunneller: null, // ignore: avoid_redundant_argument_values useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -1080,8 +1080,8 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, - chromiumLauncher: null, + expressionCompiler: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, // ignore: avoid_redundant_argument_values nullSafetyMode: NullSafetyMode.unsound, ); webDevFS.requireJS.createSync(recursive: true);