From bdfb56cee262e44b568ebf031252289e4f65bdd5 Mon Sep 17 00:00:00 2001 From: Gray Mackall <34871572+gmackall@users.noreply.github.com> Date: Mon, 18 Dec 2023 10:17:25 -0800 Subject: [PATCH] Only run dart files as a test in the Android preview tools test shard (#140099) I added a README at the end of https://github.com/flutter/flutter/pull/131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout). This makes it so we only run dart files as dart tests. --- dev/bots/test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index b4fcf523dc..2e14b41f8b 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -482,7 +482,7 @@ Future _runAndroidPreviewIntegrationToolTests() async { final List allTests = Directory(path.join(_toolsPath, 'test', 'android_preview_integration.shard')) .listSync(recursive: true).whereType() .map((FileSystemEntity entry) => path.relative(entry.path, from: _toolsPath)) - .toList(); + .where((String testPath) => path.basename(testPath).endsWith('_test.dart')).toList(); await _runDartTest( _toolsPath,