Prefer const constructors (#11853)

* upgrade to linter-0.1.35

* re-enable lint prefer_const_constructors

* address review comments

analysis_options.yaml

@@ -71,6 +71,7 @@ linter:
     # === style rules ===
     - always_declare_return_types
     - always_put_control_body_on_new_line
+    # - always_put_required_named_parameters_first # we prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
     - always_require_non_null_named_parameters
     - always_specify_types
     - annotate_overrides
@@ -108,9 +109,11 @@ linter:
     - package_prefixed_library_names
     # - parameter_assignments # we do this commonly
     - prefer_adjacent_string_concatenation
+    # - prefer_asserts_in_initializer_lists # not yet tested
     - prefer_collection_literals
     # - prefer_conditional_assignment # not yet tested
-    # - prefer_const_constructors # https://github.com/dart-lang/linter/issues/752
+    - prefer_const_constructors
+    # - prefer_const_constructors_in_immutables # not yet tested
     # - prefer_constructors_over_static_methods # not yet tested
     - prefer_contains
     # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
@@ -122,6 +125,7 @@ linter:
     # - prefer_interpolation_to_compose_strings # not yet tested
     - prefer_is_empty
     - prefer_is_not_empty
+    # - prefer_single_quote_strings # not yet tested
     # - public_member_api_docs # this is the only difference from analysis_options_repo.yaml
     # - recursive_getters # https://github.com/dart-lang/linter/issues/452
     - slash_for_doc_comments