From b7f00a643d121f48d2772607541b7febcf18f190 Mon Sep 17 00:00:00 2001 From: Todd Volkert Date: Mon, 6 Mar 2017 11:40:14 -0800 Subject: [PATCH] Defensively handle case of VMservice message that has no id. (#8587) --- packages/flutter_tools/lib/src/vmservice_record_replay.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/flutter_tools/lib/src/vmservice_record_replay.dart b/packages/flutter_tools/lib/src/vmservice_record_replay.dart index af948e0051..2b6470ce03 100644 --- a/packages/flutter_tools/lib/src/vmservice_record_replay.dart +++ b/packages/flutter_tools/lib/src/vmservice_record_replay.dart @@ -83,6 +83,10 @@ abstract class _Message implements Comparable<_Message> { @override int compareTo(_Message other) { + if (id == null) { + printError('Invalid VMService message data detected: $data'); + return -1; + } final int result = id.compareTo(other.id); if (result != 0) { return result;