From af8a3a62af3c573a826fd1e4f7241ad91e9ce73d Mon Sep 17 00:00:00 2001
From: Brandon DeRosier <bdero@google.com>
Date: Fri, 28 Apr 2023 10:24:18 -0700
Subject: [PATCH] [Impeller] Always enable validation for goldens
 (flutter/engine#41574)

Enable validation for release builds of the golden tests.
---
 engine/src/flutter/impeller/aiks/BUILD.gn      | 5 ++++-
 engine/src/flutter/impeller/base/validation.cc | 2 +-
 engine/src/flutter/impeller/base/validation.h  | 6 ++++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/engine/src/flutter/impeller/aiks/BUILD.gn b/engine/src/flutter/impeller/aiks/BUILD.gn
index 16df517cbf..dc90d43447 100644
--- a/engine/src/flutter/impeller/aiks/BUILD.gn
+++ b/engine/src/flutter/impeller/aiks/BUILD.gn
@@ -61,7 +61,10 @@ impeller_component("aiks_unittests") {
 impeller_component("aiks_unittests_golden") {
   testonly = true
 
-  defines = [ "IMPELLER_GOLDEN_TESTS" ]
+  defines = [
+    "IMPELLER_GOLDEN_TESTS",
+    "IMPELLER_ENABLE_VALIDATION=1",
+  ]
 
   sources = [ "aiks_unittests.cc" ]
   deps = [
diff --git a/engine/src/flutter/impeller/base/validation.cc b/engine/src/flutter/impeller/base/validation.cc
index 5e2e3e76b5..d3a7031622 100644
--- a/engine/src/flutter/impeller/base/validation.cc
+++ b/engine/src/flutter/impeller/base/validation.cc
@@ -39,7 +39,7 @@ std::ostream& ValidationLog::GetStream() {
 
 void ImpellerValidationBreak(const char* message) {
 // Nothing to do. Exists for the debugger.
-#ifdef IMPELLER_DEBUG
+#ifdef IMPELLER_ENABLE_VALIDATION
   std::stringstream stream;
   stream << "Break on '" << __FUNCTION__
          << "' to inspect point of failure: " << message;
diff --git a/engine/src/flutter/impeller/base/validation.h b/engine/src/flutter/impeller/base/validation.h
index 60ed89df71..efa1d98ef4 100644
--- a/engine/src/flutter/impeller/base/validation.h
+++ b/engine/src/flutter/impeller/base/validation.h
@@ -4,6 +4,12 @@
 
 #pragma once
 
+#ifndef IMPELLER_ENABLE_VALIDATION
+#ifdef IMPELLER_DEBUG
+#define IMPELLER_ENABLE_VALIDATION 1
+#endif
+#endif
+
 #include <sstream>
 
 #include "flutter/fml/macros.h"