From a97cf4b5792c000b24c8ea0c6cbd5bfd1afe13ba Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Thu, 20 Oct 2016 12:11:31 -0700 Subject: [PATCH] Adapt to vm isolate and isolate snapshot pieces being emitted as assembly. (#6433) --- .../lib/src/commands/build_aot.dart | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/build_aot.dart b/packages/flutter_tools/lib/src/commands/build_aot.dart index 453ac2901b..fc05dca03a 100644 --- a/packages/flutter_tools/lib/src/commands/build_aot.dart +++ b/packages/flutter_tools/lib/src/commands/build_aot.dart @@ -269,38 +269,13 @@ Future _buildAotSnapshot( if (platform == TargetPlatform.ios) { printStatus('Building app.dylib...'); - // These names are known to from the engine. - const String kDartVmIsolateSnapshotBuffer = 'kDartVmIsolateSnapshotBuffer'; - const String kDartIsolateSnapshotBuffer = 'kDartIsolateSnapshotBuffer'; - - runCheckedSync(['mv', vmIsolateSnapshot, path.join(outputDir.path, kDartVmIsolateSnapshotBuffer)]); - runCheckedSync(['mv', isolateSnapshot, path.join(outputDir.path, kDartIsolateSnapshotBuffer)]); - - String kDartVmIsolateSnapshotBufferC = path.join(outputDir.path, '$kDartVmIsolateSnapshotBuffer.c'); - String kDartIsolateSnapshotBufferC = path.join(outputDir.path, '$kDartIsolateSnapshotBuffer.c'); - - runCheckedSync([ - 'xxd', '--include', kDartVmIsolateSnapshotBuffer, path.basename(kDartVmIsolateSnapshotBufferC) - ], workingDirectory: outputDir.path); - runCheckedSync([ - 'xxd', '--include', kDartIsolateSnapshotBuffer, path.basename(kDartIsolateSnapshotBufferC) - ], workingDirectory: outputDir.path); - String assemblyO = path.join(outputDir.path, 'snapshot_assembly.o'); - String kDartVmIsolateSnapshotBufferO = path.join(outputDir.path, '$kDartVmIsolateSnapshotBuffer.o'); - String kDartIsolateSnapshotBufferO = path.join(outputDir.path, '$kDartIsolateSnapshotBuffer.o'); List commonBuildOptions = ['-arch', 'arm64', '-miphoneos-version-min=8.0']; if (!interpreter) runCheckedSync(['xcrun', 'cc'] ..addAll(commonBuildOptions) ..addAll(['-c', assembly, '-o', assemblyO])); - runCheckedSync(['xcrun', 'cc'] - ..addAll(commonBuildOptions) - ..addAll(['-c', kDartVmIsolateSnapshotBufferC, '-o', kDartVmIsolateSnapshotBufferO])); - runCheckedSync(['xcrun', 'cc'] - ..addAll(commonBuildOptions) - ..addAll(['-c', kDartIsolateSnapshotBufferC, '-o', kDartIsolateSnapshotBufferO])); String appSo = path.join(outputDir.path, 'app.dylib'); @@ -312,8 +287,6 @@ Future _buildAotSnapshot( '-Xlinker', '-rpath', '-Xlinker', '@loader_path/Frameworks', '-install_name', '@rpath/app.dylib', '-o', appSo, - kDartVmIsolateSnapshotBufferO, - kDartIsolateSnapshotBufferO, ]); if (!interpreter) linkCommand.add(assemblyO);